[GitHub] [cassandra] bowensong commented on a change in pull request #1249: Cassandra 16956 - remove Windows support

[GitBox <gi...@apache.org>]

bowensong commented on a change in pull request #1249:
URL: https://github.com/apache/cassandra/pull/1249#discussion_r799718489



##########
File path: pylib/cqlshlib/test/run_cqlsh.py
##########
@@ -111,36 +103,6 @@ def timing_out_itimer(seconds):
         finally:
             signal.setitimer(signal.ITIMER_REAL, 0)
 
-@contextlib.contextmanager
-def timing_out_alarm(seconds):

Review comment:
       @josh-mckenzie @smiklosovic
   
   No, the removed method is not Windows specific.
   
   The reason for removal:
   1. the only code referenced to this method was under the `if is_win(): ... else: ...` branch below, between line 129 and 143. That chunk of code is removed because they are Windows specific.
   2. Python 2.6 support was ended in 2013, nearly 9 years ago. This code has been practically sitting in an unreachable branch since then.
   3. the comment says it was kept for potentially faster tests, but the there's no test using it.
   
   Any reason to keep the unused and unreachable code in the there? I can add it back if this is a blocker.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org