You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/11/05 08:59:05 UTC
[GitHub] [hudi] danny0405 commented on a change in pull request #3928: [HUDI-2685] Support scheduling online compaction plan when there are …
danny0405 commented on a change in pull request #3928:
URL: https://github.com/apache/hudi/pull/3928#discussion_r743484893
##########
File path: hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java
##########
@@ -221,11 +223,15 @@ public void notifyCheckpointComplete(long checkpointId) {
// the stream write task snapshot and flush the data buffer synchronously in sequence,
// so a successful checkpoint subsumes the old one(follows the checkpoint subsuming contract)
final boolean committed = commitInstant(this.instant, checkpointId);
+
+ if (tableState.scheduleCompaction) {
+ // if async compaction is on, schedule the compaction
+ metaClient.reloadActiveTimeline();
Review comment:
can we move these 3 lines into the `CompactionUtil#scheduleCompaction(metaClient)` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org