You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/07/01 06:45:20 UTC

Review Request 23191: Revert "Returning a message when no tasks to kill."

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23191/
-----------------------------------------------------------

Review request for Aurora and Bill Farner.


Bugs: AURORA-564
    https://issues.apache.org/jira/browse/AURORA-564


Repository: aurora


Description
-------

Backing out of this change as there is no clean way to fix this now.

Instead of piling up on top of SchedulerCore, I intend to finally address the AURORA-94 and fix killTasks messaging as part of that refactoring. 


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 5d21e5ebe80cda75957475afa9c2b94e202b73b2 
  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 2b9edd41631b48dd729ec1dafcf0cd20808e9c7c 

Diff: https://reviews.apache.org/r/23191/diff/


Testing
-------

gradle -Pq build


Thanks,

Maxim Khutornenko

Re: Review Request 23191: Revert "Returning a message when no tasks to kill."

Posted by Bill Farner <wf...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23191/#review47124
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On July 1, 2014, 4:45 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23191/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 4:45 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-564
>     https://issues.apache.org/jira/browse/AURORA-564
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Backing out of this change as there is no clean way to fix this now.
> 
> Instead of piling up on top of SchedulerCore, I intend to finally address the AURORA-94 and fix killTasks messaging as part of that refactoring. 
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 5d21e5ebe80cda75957475afa9c2b94e202b73b2 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 2b9edd41631b48dd729ec1dafcf0cd20808e9c7c 
> 
> Diff: https://reviews.apache.org/r/23191/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>