[GitHub] [incubator-doris] imay commented on a change in pull request #2308: Add BinaryPrefixPage

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #2308: Add BinaryPrefixPage
URL: https://github.com/apache/incubator-doris/pull/2308#discussion_r351329144
 
 

 ##########
 File path: be/src/olap/rowset/segment_v2/rle_page.h
 ##########
 @@ -133,6 +151,8 @@ class RlePageBuilder : public PageBuilder {
     int _bit_width;
     RleEncoder<CppType>* _rle_encoder;
     faststring _buf;
+    CppType _first_value;
+    CppType _last_value;
 
 Review comment:
   It seems that _first_value and _last_value are not set. And better to add test case to avoid it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org