You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/05 02:30:37 UTC

[GitHub] [dolphinscheduler] lenboo commented on a diff in pull request #11264: [Feature] Add Api service optional whether to register ZK.

lenboo commented on code in PR #11264:
URL: https://github.com/apache/dolphinscheduler/pull/11264#discussion_r938392018


##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/NodeType.java:
##########
@@ -18,5 +18,5 @@
 package org.apache.dolphinscheduler.common.enums;
 
 public enum NodeType {
-    MASTER, WORKER, DEAD_SERVER
+    API, MASTER, WORKER, DEAD_SERVER

Review Comment:
   It's better to put the new enum in the last index.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org