[GitHub] [spark] LuciferYang commented on a diff in pull request #38238: [SPARK-40733][SQL] Make the contents of `SERDEPROPERTIES` in the result of `ShowCreateTableAsSerdeCommand` have a fixed order

[GitBox <gi...@apache.org>]

LuciferYang commented on code in PR #38238:
URL: https://github.com/apache/spark/pull/38238#discussion_r994564013


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala:
##########
@@ -1342,7 +1342,7 @@ case class ShowCreateTableAsSerdeCommand(
     storage.serde.foreach { serde =>
       builder ++= s"ROW FORMAT SERDE '$serde'\n"
 
-      val serdeProps = conf.redactOptions(metadata.storage.properties).map {
+      val serdeProps = conf.redactOptions(metadata.storage.properties).toSeq.sortBy(_._1).map {

Review Comment:
   https://github.com/apache/spark/blob/1cb8250d166f5d877f24f6ea097d27d7168ecf15/sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala#L1202-L1210
   
   `showDataSourceTableOptions` already do the similar work in https://github.com/apache/spark/pull/34753
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org