You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/06/16 05:37:17 UTC
[GitHub] [apisix-go-plugin-runner] soulbird opened a new pull request, #88: refactor: rename Response to ReqResponse
soulbird opened a new pull request, #88:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/88
We will add `response.go` and `Response` interface to support response phase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander commented on pull request #88: refactor: rename Response to ReqResponse
Posted by GitBox <gi...@apache.org>.
spacewander commented on PR #88:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/88#issuecomment-1158416632
Please make the CI pass, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] codecov-commenter commented on pull request #88: refactor: rename Response to ReqResponse
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #88:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/88#issuecomment-1157257191
# [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/88?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#88](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/88?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5065423) into [master](https://codecov.io/gh/apache/apisix-go-plugin-runner/commit/413b90306370882b7d271e57b526fb501f819617?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (413b903) will **not change** coverage.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #88 +/- ##
=======================================
Coverage 81.23% 81.23%
=======================================
Files 11 11
Lines 746 746
=======================================
Hits 606 606
Misses 102 102
Partials 38 38
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/88?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [internal/http/req-response.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/88/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvaHR0cC9yZXEtcmVzcG9uc2UuZ28=) | `100.00% <100.00%> (ø)` | |
| [internal/plugin/plugin.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/88/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvcGx1Z2luL3BsdWdpbi5nbw==) | `78.68% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/88?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/88?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [413b903...5065423](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/88?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander merged pull request #88: refactor: rename Response to ReqResponse
Posted by GitBox <gi...@apache.org>.
spacewander merged PR #88:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/88
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org