You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/11/21 23:39:04 UTC
[GitHub] [trafficserver] jplevyak opened a new pull request #7350: Convert RamCache auxkey form 2 uint32_t to 1 uint64_t.
jplevyak opened a new pull request #7350:
URL: https://github.com/apache/trafficserver/pull/7350
Signed-off-by: John Plevyak <jp...@apache.org>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode merged pull request #7350: Convert RamCache auxkey from 2 uint32_t to 1 uint64_t.
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode merged pull request #7350:
URL: https://github.com/apache/trafficserver/pull/7350
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7350: Convert RamCache auxkey from 2 uint32_t to 1 uint64_t.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7350:
URL: https://github.com/apache/trafficserver/pull/7350#issuecomment-747776358
[approve ci Debian]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7350: Convert RamCache auxkey from 2 uint32_t to 1 uint64_t.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7350:
URL: https://github.com/apache/trafficserver/pull/7350#issuecomment-757064039
> Looks reasonable. IIRC the main reason the ram cache key is 32 bits is because no one was willing to change it when we moved to 64 bit support. I would like, however, to not use "uint64_t" but put in a `using` like `using RamCacheKey = uint64_t;`. I think this will make the code clearer and make it easier to tweak later.
Is there a reason you didn't approve this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on pull request #7350: Convert RamCache auxkey from 2 uint32_t to 1 uint64_t.
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on pull request #7350:
URL: https://github.com/apache/trafficserver/pull/7350#issuecomment-771183921
I was hoping for the `using` fix but I suppose I can just do that myself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7350: Convert RamCache auxkey from 2 uint32_t to 1 uint64_t.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7350:
URL: https://github.com/apache/trafficserver/pull/7350#issuecomment-757064039
> Looks reasonable. IIRC the main reason the ram cache key is 32 bits is because no one was willing to change it when we moved to 64 bit support. I would like, however, to not use "uint64_t" but put in a `using` like `using RamCacheKey = uint64_t;`. I think this will make the code clearer and make it easier to tweak later.
Is there a reason you didn't approve this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on pull request #7350: Convert RamCache auxkey form 2 uint32_t to 1 uint64_t.
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on pull request #7350:
URL: https://github.com/apache/trafficserver/pull/7350#issuecomment-732343561
Looks reasonable. IIRC the main reason the ram cache key is 32 bits is because no one was willing to change it when we moved to 64 bit support. I would like, however, to not use "uint64_t" but put in a `using` like `using RamCacheKey = uint64_t;`. I think this will make the code clearer and make it easier to tweak later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode merged pull request #7350: Convert RamCache auxkey from 2 uint32_t to 1 uint64_t.
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode merged pull request #7350:
URL: https://github.com/apache/trafficserver/pull/7350
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras removed a comment on pull request #7350: Convert RamCache auxkey from 2 uint32_t to 1 uint64_t.
Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #7350:
URL: https://github.com/apache/trafficserver/pull/7350#issuecomment-747776358
[approve ci Debian]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org