Re: [PR] KAFKA-14121: AlterPartitionReassignments API should allow callers to specify the option of preserving the replication factor [kafka]

["brandboat (via GitHub)" <gi...@apache.org>]

brandboat commented on code in PR #18983:
URL: https://github.com/apache/kafka/pull/18983#discussion_r1976647014


##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -2406,6 +2414,31 @@ private void updatePartitionInfo(
             newPartInfo.elr);
     }
 
+    private void validatePartitionReplicationFactorUnchanged(
+            PartitionRegistration part,

Review Comment:
   The code style in this class is somewhat inconsistent, and the formatting isn't fully aligned. That said, I can address this comment. Perhaps in the future, we could consider adding a checkstyle rule to standardize the argument alignment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org