You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2011/07/19 01:28:59 UTC

[jira] [Commented] (PIG-2077) Project UDF output inside a non-foreach statement fail on 0.8

    [ https://issues.apache.org/jira/browse/PIG-2077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067390#comment-13067390 ] 

jiraposter@reviews.apache.org commented on PIG-2077:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/767/#review1105
-----------------------------------------------------------

Ship it!


+1

- thejas


On 2011-05-19 22:26:01, Daniel Dai wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/767/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-05-19 22:26:01)
bq.  
bq.  
bq.  Review request for pig and thejas.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  See PIG-2077
bq.  
bq.  
bq.  This addresses bug PIG-2077.
bq.      https://issues.apache.org/jira/browse/PIG-2077
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    branches/branch-0.8/src/org/apache/pig/newplan/logical/LogicalExpPlanMigrationVistor.java 1104455 
bq.    branches/branch-0.8/test/org/apache/pig/test/TestEvalPipeline2.java 1104455 
bq.  
bq.  Diff: https://reviews.apache.org/r/767/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Test patch:
bq.       [exec] +1 overall.  
bq.       [exec] 
bq.       [exec]     +1 @author.  The patch does not contain any @author tags.
bq.       [exec] 
bq.       [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
bq.       [exec] 
bq.       [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
bq.       [exec] 
bq.       [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
bq.       [exec] 
bq.       [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
bq.       [exec] 
bq.       [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
bq.  
bq.  Unit test:
bq.      all pass
bq.  
bq.  End to end test:
bq.      all pass
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Daniel
bq.  
bq.



> Project UDF output inside a non-foreach statement fail on 0.8
> -------------------------------------------------------------
>
>                 Key: PIG-2077
>                 URL: https://issues.apache.org/jira/browse/PIG-2077
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.8.1
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.8.1
>
>         Attachments: PIG-2077-1.patch
>
>
> The following script fail on 0.8:
> {code}
> A = load '1.txt' as (tracking_id, day:chararray);
> B = load '2.txt' as (tracking_id, timestamp:chararray);
> C = JOIN A by (tracking_id, day) LEFT OUTER, B by (tracking_id,  STRSPLIT(timestamp, ' ').$0);
> explain C;
> {code}
> Error stack:
> Caused by: java.lang.ArrayIndexOutOfBoundsException: -1
>         at java.util.ArrayList.get(ArrayList.java:324)
>         at org.apache.pig.newplan.logical.expression.ProjectExpression.findReferent(ProjectExpression.java:207)
>         at org.apache.pig.newplan.logical.expression.ProjectExpression.getFieldSchema(ProjectExpression.java:121)
>         at org.apache.pig.newplan.logical.optimizer.FieldSchemaResetter.execute(SchemaResetter.java:193)
>         at org.apache.pig.newplan.logical.expression.AllSameExpressionVisitor.visit(AllSameExpressionVisitor.java:53)
>         at org.apache.pig.newplan.logical.expression.ProjectExpression.accept(ProjectExpression.java:75)
>         at org.apache.pig.newplan.ReverseDependencyOrderWalker.walk(ReverseDependencyOrderWalker.java:70)
>         at org.apache.pig.newplan.PlanVisitor.visit(PlanVisitor.java:50)
>         at org.apache.pig.newplan.logical.optimizer.SchemaResetter.visit(SchemaResetter.java:83)
>         at org.apache.pig.newplan.logical.relational.LOJoin.accept(LOJoin.java:149)
>         at org.apache.pig.newplan.DependencyOrderWalker.walk(DependencyOrderWalker.java:75)
>         at org.apache.pig.newplan.PlanVisitor.visit(PlanVisitor.java:50)
>         at org.apache.pig.backend.hadoop.executionengine.HExecutionEngine.compile(HExecutionEngine.java:262)
> This is not a problem on 0.9, trunk, since LogicalExpPlanMigrationVistor is dropped in 0.9.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira