You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by we...@apache.org on 2010/05/15 16:50:31 UTC

svn commit: r944654 - /myfaces/core/trunk/api/src/main/javascript/META-INF/resources/myfaces/_impl/_util/_Dom.js

Author: werpu
Date: Sat May 15 14:50:30 2010
New Revision: 944654

URL: http://svn.apache.org/viewvc?rev=944654&view=rev
Log:
https://issues.apache.org/jira/browse/MYFACES-2716

browser specific performance improvements in the dom area, adding additional comments
fixes for some minor issues where ie8 broke the javascript specs on the closure
array apply area!

Cleaned up the javascript eval code, it now should work faster and is more readable
thanks to our new performance improved dom routines.

Modified:
    myfaces/core/trunk/api/src/main/javascript/META-INF/resources/myfaces/_impl/_util/_Dom.js

Modified: myfaces/core/trunk/api/src/main/javascript/META-INF/resources/myfaces/_impl/_util/_Dom.js
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/javascript/META-INF/resources/myfaces/_impl/_util/_Dom.js?rev=944654&r1=944653&r2=944654&view=diff
==============================================================================
--- myfaces/core/trunk/api/src/main/javascript/META-INF/resources/myfaces/_impl/_util/_Dom.js (original)
+++ myfaces/core/trunk/api/src/main/javascript/META-INF/resources/myfaces/_impl/_util/_Dom.js Sat May 15 14:50:30 2010
@@ -307,8 +307,8 @@ myfaces._impl.core._Runtime.singletonExt
             if (fragment.nodeType == 1 && filter(fragment)) {
                 result = (result == null) ? [] : _Lang.objToArray(result);
                 result.push(fragment);
-                return result;
             }
+            return result;
         }
         //if we are not in a html 5 environment which supports node selectors
         //we use the usual recursive fallback.
@@ -330,8 +330,8 @@ myfaces._impl.core._Runtime.singletonExt
             if (fragment.nodeType == 1 && filter(fragment)) {
                 result = (result == null) ? [] : _Lang.objToArray(result);
                 result.push(fragment);
-                return result;
             }
+            return result;
         }
 
         return this.findAll(fragment, filter, deepScan);
@@ -371,7 +371,6 @@ myfaces._impl.core._Runtime.singletonExt
                 result = (result == null) ? [] : result;
                 result = _Lang.objToArrayl(result);
                 result.push(fragment);
-                return result;
             }
             return result;
         }