[jira] [Commented] (KAFKA-1694) kafka command line and centralized operations

["Jun Rao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245091#comment-14245091 ] 

Jun Rao commented on KAFKA-1694:
--------------------------------

Thanks for the patch. A few comments.

10. I still don't think having a single admin request/response is a good idea. Since the args for different sub admin requests are quite different, it's very hard to reason about what the format in args is. Ideally, we should be able to figure out the request format just from the protocol definition. It seems to me it's cleaner to just create the following standalone requests/responses.

1. create topic
2. alter topic
3. delete topic
4. list topic
5. describe topic (this will be used to replace TopicMetadataRequest eventually)
6. describe cluster (return all brokers and the controller)

11. We can reuse the java request objects in the scala request (see HeartbeatRequestAndHeader.scala as an example).

12. describe topic : I am not sure that we need to include the following options in the request. We can just return the info (replicas, isrs, etc) of all partitions and let the client decide what to do with them.
reportUnderReplicatedPartitions
reportUnavailablePartitions

Since this is a large patch, could you submit an RB using the patch review tool?

> kafka command line and centralized operations
> ---------------------------------------------
>
>                 Key: KAFKA-1694
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1694
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Joe Stein
>            Priority: Critical
>             Fix For: 0.8.3
>
>         Attachments: KAFKA-1772_1802_1775_1774_v2.patch
>
>
> https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Command+Line+and+Related+Improvements



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)