You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2024/06/16 23:02:34 UTC
(commons-net) 09/11: Fix PMD UnnecessaryModifier
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git
commit 2e7764c54e9c41da547f7e84272cfcfe3a4150d0
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Jun 16 18:57:28 2024 -0400
Fix PMD UnnecessaryModifier
---
src/main/java/org/apache/commons/net/imap/AuthenticatingIMAPClient.java | 2 +-
src/main/java/org/apache/commons/net/imap/IMAPCommand.java | 2 +-
src/main/java/org/apache/commons/net/pop3/ExtendedPOP3Client.java | 2 +-
src/main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/main/java/org/apache/commons/net/imap/AuthenticatingIMAPClient.java b/src/main/java/org/apache/commons/net/imap/AuthenticatingIMAPClient.java
index 05e88570..2babe295 100644
--- a/src/main/java/org/apache/commons/net/imap/AuthenticatingIMAPClient.java
+++ b/src/main/java/org/apache/commons/net/imap/AuthenticatingIMAPClient.java
@@ -65,7 +65,7 @@ public class AuthenticatingIMAPClient extends IMAPSClient {
*
* @return The name of the given authentication method suitable for the server.
*/
- public final String getAuthName() {
+ public String getAuthName() {
return authName;
}
}
diff --git a/src/main/java/org/apache/commons/net/imap/IMAPCommand.java b/src/main/java/org/apache/commons/net/imap/IMAPCommand.java
index a14a1b91..0794812d 100644
--- a/src/main/java/org/apache/commons/net/imap/IMAPCommand.java
+++ b/src/main/java/org/apache/commons/net/imap/IMAPCommand.java
@@ -156,7 +156,7 @@ public enum IMAPCommand {
* @param command the {@link IMAPCommand} whose command string is required. Must not be null.
* @return The IMAP protocol string command corresponding to a command code.
*/
- public static final String getCommand(final IMAPCommand command) {
+ public static String getCommand(final IMAPCommand command) {
return command.getIMAPCommand();
}
diff --git a/src/main/java/org/apache/commons/net/pop3/ExtendedPOP3Client.java b/src/main/java/org/apache/commons/net/pop3/ExtendedPOP3Client.java
index 3cd19432..eb333b3d 100644
--- a/src/main/java/org/apache/commons/net/pop3/ExtendedPOP3Client.java
+++ b/src/main/java/org/apache/commons/net/pop3/ExtendedPOP3Client.java
@@ -55,7 +55,7 @@ public class ExtendedPOP3Client extends POP3SClient {
*
* @return The name of the given authentication method suitable for the server.
*/
- public final String getAuthName() {
+ public String getAuthName() {
return this.methodName;
}
}
diff --git a/src/main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java b/src/main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java
index e626f78a..a8f9be55 100644
--- a/src/main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java
+++ b/src/main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java
@@ -62,7 +62,7 @@ public class AuthenticatingSMTPClient extends SMTPSClient {
* @param method The authentication method to get the name for.
* @return The name of the given authentication method suitable for the server.
*/
- public static final String getAuthName(final AUTH_METHOD method) {
+ public static String getAuthName(final AUTH_METHOD method) {
if (method.equals(PLAIN)) {
return "PLAIN";
}