You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Veena Basavaraj <vb...@cloudera.com> on 2014/09/29 22:34:37 UTC
Review Request 26145: SQOOP-1498: Sqoop2 Repository Object
refactoring + renamaing forms to configs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26145/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1498
https://issues.apache.org/jira/browse/SQOOP-1498
Repository: sqoop-SQOOP-1367
Description
-------
Sqoop2 Repository Object refactoring
- see JIRA for the details on the changes to the model objects MConnector, MJob, MLink, M*Config
- rename forms to configs
- renames to the db repository to accomodate the renames in models/ fields
-
Diffs
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java d7e6768
client/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.java 7b2ddc2
client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java 54ea3d2
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java 465dd69
common/src/main/java/org/apache/sqoop/json/DriverConfigBean.java a2cc8b8
common/src/main/java/org/apache/sqoop/json/JobBean.java a3e6071
common/src/main/java/org/apache/sqoop/json/JobValidationBean.java 34c0a4b
common/src/main/java/org/apache/sqoop/json/LinkBean.java 8981ea7
common/src/main/java/org/apache/sqoop/json/LinkValidationBean.java a6a6b65
common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 77f6191
common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java 20ee5f3
common/src/main/java/org/apache/sqoop/model/Config.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigClass.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigUtils.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigurationClass.java 73374d8
common/src/main/java/org/apache/sqoop/model/ConfigurationGroupClass.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/Form.java 4321582
common/src/main/java/org/apache/sqoop/model/FormClass.java 6048d03
common/src/main/java/org/apache/sqoop/model/FormUtils.java ae025ab
common/src/main/java/org/apache/sqoop/model/MConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConfigList.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConfigType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConnectionForms.java 457ccdb
common/src/main/java/org/apache/sqoop/model/MConnector.java 3dc1014
common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 62eb197
common/src/main/java/org/apache/sqoop/model/MForm.java ff94660
common/src/main/java/org/apache/sqoop/model/MFormList.java 9130ada
common/src/main/java/org/apache/sqoop/model/MFormType.java 2f403df
common/src/main/java/org/apache/sqoop/model/MFromConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MJob.java c9b45a5
common/src/main/java/org/apache/sqoop/model/MJobForms.java 08b9a78
common/src/main/java/org/apache/sqoop/model/MLink.java 6a8c424
common/src/main/java/org/apache/sqoop/model/MLinkConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MToConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/Validation.java fce6e88
common/src/main/java/org/apache/sqoop/validation/ValidationError.java 264d6e3
common/src/main/java/org/apache/sqoop/validation/ValidationRunner.java f36faf2
common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java e078474
common/src/test/java/org/apache/sqoop/json/TestDriverConfigBean.java 4309f10
common/src/test/java/org/apache/sqoop/json/TestJobBean.java c6461bf
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 8235275
common/src/test/java/org/apache/sqoop/json/TestUtil.java eaf9122
common/src/test/java/org/apache/sqoop/json/TestValidationBean.java f5f3389
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/util/TestFormSerialization.java c4223ec
common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestFormUtils.java ba85d11
common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java d56e165
common/src/test/java/org/apache/sqoop/model/TestMConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMConnectionForms.java e2d2717
common/src/test/java/org/apache/sqoop/model/TestMConnector.java 3fde47b
common/src/test/java/org/apache/sqoop/model/TestMDriverConfig.java 9c23cc3
common/src/test/java/org/apache/sqoop/model/TestMForm.java 0bd55d9
common/src/test/java/org/apache/sqoop/model/TestMFormList.java c7ee682
common/src/test/java/org/apache/sqoop/model/TestMJob.java 96c316a
common/src/test/java/org/apache/sqoop/model/TestMJobConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMJobForms.java 81a8614
common/src/test/java/org/apache/sqoop/model/TestMLink.java 1be37a1
common/src/test/java/org/apache/sqoop/model/TestMLinkConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/validation/TestValidation.java bf0ade5
common/src/test/java/org/apache/sqoop/validation/TestValidationRunner.java 647abe0
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java 8deddb0
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java 8b23144
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfiguration.java b036421
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfig.java 7b76eeb
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfiguration.java 7d614f7
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfig.java a42a6ec
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfiguration.java ad68681
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java e10a5b4
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java 47b186c
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 2c98051
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfiguration.java f861237
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java b689854
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfiguration.java 4970821
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java b1308db
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfiguration.java bba249c
core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java dbfdc03
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java c87df84
core/src/main/java/org/apache/sqoop/driver/Driver.java 5297bde
core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 8d6eb78
core/src/main/java/org/apache/sqoop/driver/DriverValidator.java 9cc51dd
core/src/main/java/org/apache/sqoop/driver/JobManager.java 277c6be
core/src/main/java/org/apache/sqoop/driver/JobRequest.java 63e1e49
core/src/main/java/org/apache/sqoop/driver/configuration/DriverConfiguration.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.java 908a4eb
core/src/main/java/org/apache/sqoop/driver/configuration/LinkConfiguration.java 3202844
core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingConfig.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingForm.java e73007e
core/src/main/java/org/apache/sqoop/repository/Repository.java ea1608a
core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java ae7be82
core/src/main/resources/driver-config.properties 9ec5d9e
core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java 9c39d23
core/src/test/java/org/apache/sqoop/driver/TestJobManager.java 80f45e5
core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 796b021
execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 83c670c
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 2ed06a8
execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 869c727
execution/mapreduce/src/test/java/org/apache/sqoop/job/io/TestData.java 91df426
execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 1447e00
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 61dc3b4
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 5dd7970
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 58eed2d
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java ad42901
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 998f5b7
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java 8a5823d
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverConfigHandling.java 567dda6
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java c4a5829
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java f22c351
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 7378eda
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 38a995f
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java d1b6b9a
server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java c0d363e
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java b61d3f5
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 23fc9f1
shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java 97d8e6f
shell/src/main/java/org/apache/sqoop/shell/CloneLinkFunction.java d9babe0
shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java ccfed31
shell/src/main/java/org/apache/sqoop/shell/CreateLinkFunction.java 33d60c8
shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java 2ba75b4
shell/src/main/java/org/apache/sqoop/shell/ShowDriverConfigFunction.java e6e1004
shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java e3f1f47
shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java f500b9e
shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java 5d69c2a
shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java 96d1fd8
shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 30bb63e
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 4d3838c
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/DynamicConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/DynamicFormOptions.java cc63610
shell/src/main/java/org/apache/sqoop/shell/utils/FormDisplayer.java dcbccef
shell/src/main/java/org/apache/sqoop/shell/utils/FormFiller.java a0a5dc2
shell/src/main/java/org/apache/sqoop/shell/utils/FormOptions.java efd002e
shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicFormOptions.java 87c0776
shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicFormOptions.java 2952be2
spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java e00b404
submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java fe92ac4
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 6074d36
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java 5e1abc1
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 2dc0613
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java 729f95e
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java 562a6a6
test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java 507ac53
Diff: https://reviews.apache.org/r/26145/diff/
Testing
-------
mvn test, pending more db testing
Thanks,
Veena Basavaraj
Re: Review Request 26145: SQOOP-1498: Sqoop2 Repository Object
refactoring + renamaing forms to configs
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26145/#review55043
-----------------------------------------------------------
Ship it!
Hey Veena,
At a high level looks fine except for a couple of nits. Try to remove all extra spaces and watch out for typos! As soon as that's in... cool with me!
client/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.java
<https://reviews.apache.org/r/26145/#comment95372>
Space
client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java
<https://reviews.apache.org/r/26145/#comment95373>
Naming is weird? getConnectoConfigBundle = getConnectorConfigBundle?
client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java
<https://reviews.apache.org/r/26145/#comment95375>
getConnectoConfigBundle => getConnectorConfigBundle
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java
<https://reviews.apache.org/r/26145/#comment95379>
Space
common/src/main/java/org/apache/sqoop/json/DriverConfigBean.java
<https://reviews.apache.org/r/26145/#comment95380>
Probably MJobConfig?
common/src/main/java/org/apache/sqoop/json/JobValidationBean.java
<https://reviews.apache.org/r/26145/#comment95381>
Space
common/src/main/java/org/apache/sqoop/json/ThrowableBean.java
<https://reviews.apache.org/r/26145/#comment95382>
Unnecessary change.
common/src/main/java/org/apache/sqoop/model/MConnector.java
<https://reviews.apache.org/r/26145/#comment95383>
Space
common/src/main/java/org/apache/sqoop/model/MConnector.java
<https://reviews.apache.org/r/26145/#comment95384>
Space.
common/src/main/java/org/apache/sqoop/model/MJob.java
<https://reviews.apache.org/r/26145/#comment95385>
Space
- Abraham Elmahrek
On Sept. 30, 2014, 4:13 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26145/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2014, 4:13 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1498
> https://issues.apache.org/jira/browse/SQOOP-1498
>
>
> Repository: sqoop-SQOOP-1367
>
>
> Description
> -------
>
> Sqoop2 Repository Object refactoring
>
> - see JIRA for the details on the changes to the model objects MConnector, MJob, MLink, M*Config
> - rename forms to configs
> - renames to the db repository to accomodate the renames in models/ fields
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java d7e6768
> client/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.java 7b2ddc2
> client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java 54ea3d2
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java 465dd69
> common/src/main/java/org/apache/sqoop/json/DriverConfigBean.java a2cc8b8
> common/src/main/java/org/apache/sqoop/json/JobBean.java a3e6071
> common/src/main/java/org/apache/sqoop/json/JobValidationBean.java 34c0a4b
> common/src/main/java/org/apache/sqoop/json/LinkBean.java 8981ea7
> common/src/main/java/org/apache/sqoop/json/LinkValidationBean.java a6a6b65
> common/src/main/java/org/apache/sqoop/json/ThrowableBean.java fc63ed4
> common/src/main/java/org/apache/sqoop/json/ValidationResultBean.java 89bc8db
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 77f6191
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java 20ee5f3
> common/src/main/java/org/apache/sqoop/model/Config.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/ConfigClass.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/ConfigurationClass.java 73374d8
> common/src/main/java/org/apache/sqoop/model/ConfigurationGroupClass.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/Form.java 4321582
> common/src/main/java/org/apache/sqoop/model/FormClass.java 6048d03
> common/src/main/java/org/apache/sqoop/model/FormUtils.java ae025ab
> common/src/main/java/org/apache/sqoop/model/MConfig.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MConfigList.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MConfigType.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MConnectionForms.java 457ccdb
> common/src/main/java/org/apache/sqoop/model/MConnector.java 3dc1014
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 62eb197
> common/src/main/java/org/apache/sqoop/model/MForm.java ff94660
> common/src/main/java/org/apache/sqoop/model/MFormList.java 9130ada
> common/src/main/java/org/apache/sqoop/model/MFormType.java 2f403df
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MJob.java c9b45a5
> common/src/main/java/org/apache/sqoop/model/MJobForms.java 08b9a78
> common/src/main/java/org/apache/sqoop/model/MLink.java 6a8c424
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MToConfig.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/validation/ConfigValidationError.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/validation/ConfigValidationResult.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/validation/ConfigValidationRunner.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/validation/Validation.java fce6e88
> common/src/main/java/org/apache/sqoop/validation/ValidationError.java 264d6e3
> common/src/main/java/org/apache/sqoop/validation/ValidationResult.java ae8f1d1
> common/src/main/java/org/apache/sqoop/validation/ValidationRunner.java f36faf2
> common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java e078474
> common/src/test/java/org/apache/sqoop/json/TestDriverConfigBean.java 4309f10
> common/src/test/java/org/apache/sqoop/json/TestJobBean.java c6461bf
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 8235275
> common/src/test/java/org/apache/sqoop/json/TestUtil.java eaf9122
> common/src/test/java/org/apache/sqoop/json/TestValidationBean.java f5f3389
> common/src/test/java/org/apache/sqoop/json/TestValidationResultBean.java d9c2043
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/util/TestFormSerialization.java c4223ec
> common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/model/TestFormUtils.java ba85d11
> common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java d56e165
> common/src/test/java/org/apache/sqoop/model/TestMConfig.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/model/TestMConnectionForms.java e2d2717
> common/src/test/java/org/apache/sqoop/model/TestMConnector.java 3fde47b
> common/src/test/java/org/apache/sqoop/model/TestMDriverConfig.java 9c23cc3
> common/src/test/java/org/apache/sqoop/model/TestMForm.java 0bd55d9
> common/src/test/java/org/apache/sqoop/model/TestMFormList.java c7ee682
> common/src/test/java/org/apache/sqoop/model/TestMJob.java 96c316a
> common/src/test/java/org/apache/sqoop/model/TestMJobConfig.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/model/TestMJobForms.java 81a8614
> common/src/test/java/org/apache/sqoop/model/TestMLink.java 1be37a1
> common/src/test/java/org/apache/sqoop/model/TestMLinkConfig.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/validation/TestValidation.java bf0ade5
> common/src/test/java/org/apache/sqoop/validation/TestValidationRunner.java 647abe0
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java b4b6966
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java 8deddb0
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java ad1ee5c
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java 8b23144
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfiguration.java b036421
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfig.java 7b76eeb
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfiguration.java 7d614f7
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfig.java a42a6ec
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfiguration.java ad68681
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java e10a5b4
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java 00c2aab
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java 47b186c
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 70833a0
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsValidator.java dfa3659
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 2c98051
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfiguration.java f861237
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java b689854
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfiguration.java 4970821
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java b1308db
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfiguration.java bba249c
> core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java dbfdc03
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java c87df84
> core/src/main/java/org/apache/sqoop/driver/Driver.java 5297bde
> core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 8d6eb78
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/driver/DriverValidator.java 9cc51dd
> core/src/main/java/org/apache/sqoop/driver/JobManager.java 277c6be
> core/src/main/java/org/apache/sqoop/driver/JobRequest.java 63e1e49
> core/src/main/java/org/apache/sqoop/driver/configuration/DriverConfiguration.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.java 908a4eb
> core/src/main/java/org/apache/sqoop/driver/configuration/LinkConfiguration.java 3202844
> core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingConfig.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingForm.java e73007e
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3466116
> core/src/main/java/org/apache/sqoop/repository/Repository.java ea1608a
> core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java ae7be82
> core/src/main/resources/driver-config.properties 9ec5d9e
> core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java 9c39d23
> core/src/test/java/org/apache/sqoop/driver/TestJobManager.java 80f45e5
> core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 796b021
> execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 83c670c
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 2ed06a8
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java aecde40
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java eea0623
> execution/mapreduce/src/test/java/org/apache/sqoop/job/JobUtils.java 09e5ec5
> execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 869c727
> execution/mapreduce/src/test/java/org/apache/sqoop/job/io/TestData.java 91df426
> execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 1447e00
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 61dc3b4
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 5dd7970
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 58eed2d
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java ad42901
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 998f5b7
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java 8a5823d
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverConfigHandling.java 567dda6
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java c4a5829
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java f22c351
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 7378eda
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 38a995f
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java d1b6b9a
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java c0d363e
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java b61d3f5
> server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 23fc9f1
> shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java 97d8e6f
> shell/src/main/java/org/apache/sqoop/shell/CloneLinkFunction.java d9babe0
> shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java ccfed31
> shell/src/main/java/org/apache/sqoop/shell/CreateLinkFunction.java 33d60c8
> shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java 2ba75b4
> shell/src/main/java/org/apache/sqoop/shell/ShowDriverConfigFunction.java e6e1004
> shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java e3f1f47
> shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java f500b9e
> shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java 5d69c2a
> shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java 96d1fd8
> shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 30bb63e
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 4d3838c
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigOptions.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/DynamicConfigOptions.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/DynamicFormOptions.java cc63610
> shell/src/main/java/org/apache/sqoop/shell/utils/FormDisplayer.java dcbccef
> shell/src/main/java/org/apache/sqoop/shell/utils/FormFiller.java a0a5dc2
> shell/src/main/java/org/apache/sqoop/shell/utils/FormOptions.java efd002e
> shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicConfigOptions.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicFormOptions.java 87c0776
> shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicConfigOptions.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicFormOptions.java 2952be2
> spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java e00b404
> spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 7b78ba0
> spi/src/main/java/org/apache/sqoop/validation/Validator.java 894f412
> submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java fe92ac4
> test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 6074d36
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java 5e1abc1
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 2dc0613
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java 729f95e
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java 562a6a6
> test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java 507ac53
>
> Diff: https://reviews.apache.org/r/26145/diff/
>
>
> Testing
> -------
>
> mvn test, integration tests
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 26145: SQOOP-1498: Sqoop2 Repository Object
refactoring + renamaing forms to configs
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26145/#review55285
-----------------------------------------------------------
Almost there I think. Can we keep ConfigurationGroupClass as ConfigurationClass? It seems much more intuitive to return a configuration class than a group of configurations from a developers standpoint.
- Abraham Elmahrek
On Oct. 2, 2014, 11:02 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26145/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 11:02 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1498
> https://issues.apache.org/jira/browse/SQOOP-1498
>
>
> Repository: sqoop-SQOOP-1367
>
>
> Description
> -------
>
> Sqoop2 Repository Object refactoring
>
> - see JIRA for the details on the changes to the model objects MConnector, MJob, MLink, M*Config
> - rename forms to configs
> - renames to the db repository to accomodate the renames in models/ fields
> - rename validator to reflect that they actually validate configs
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java d7e6768
> client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java 2855de6
> client/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.java 7b2ddc2
> client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java fd858ec
> client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java 2b784c8
> client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java 54ea3d2
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d726a14
> common/src/main/java/org/apache/sqoop/json/DriverConfigBean.java a2cc8b8
> common/src/main/java/org/apache/sqoop/json/JobBean.java a3e6071
> common/src/main/java/org/apache/sqoop/json/JobValidationBean.java 34c0a4b
> common/src/main/java/org/apache/sqoop/json/LinkBean.java 8981ea7
> common/src/main/java/org/apache/sqoop/json/LinkValidationBean.java a6a6b65
> common/src/main/java/org/apache/sqoop/json/ThrowableBean.java fc63ed4
> common/src/main/java/org/apache/sqoop/json/ValidationResultBean.java 89bc8db
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 77f6191
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java 20ee5f3
> common/src/main/java/org/apache/sqoop/model/Config.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/ConfigClass.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/ConfigurationClass.java 73374d8
> common/src/main/java/org/apache/sqoop/model/ConfigurationGroupClass.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/Form.java 4321582
> common/src/main/java/org/apache/sqoop/model/FormClass.java 6048d03
> common/src/main/java/org/apache/sqoop/model/FormUtils.java ae025ab
> common/src/main/java/org/apache/sqoop/model/MConfig.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MConfigList.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MConfigType.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MConnectionForms.java 457ccdb
> common/src/main/java/org/apache/sqoop/model/MConnector.java 7999b08
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 62eb197
> common/src/main/java/org/apache/sqoop/model/MForm.java ff94660
> common/src/main/java/org/apache/sqoop/model/MFormList.java 9130ada
> common/src/main/java/org/apache/sqoop/model/MFormType.java 2f403df
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MJob.java c9b45a5
> common/src/main/java/org/apache/sqoop/model/MJobForms.java 08b9a78
> common/src/main/java/org/apache/sqoop/model/MLink.java 6a8c424
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MToConfig.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/ModelError.java 470b61c
> common/src/main/java/org/apache/sqoop/utils/ClassUtils.java eca9f7e
> common/src/main/java/org/apache/sqoop/validation/ConfigValidationError.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/validation/ConfigValidationResult.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/validation/ConfigValidationRunner.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/validation/Message.java cb55b6a
> common/src/main/java/org/apache/sqoop/validation/Validation.java fce6e88
> common/src/main/java/org/apache/sqoop/validation/ValidationError.java 264d6e3
> common/src/main/java/org/apache/sqoop/validation/ValidationResult.java ae8f1d1
> common/src/main/java/org/apache/sqoop/validation/ValidationRunner.java f36faf2
> common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java fe75ee0
> common/src/test/java/org/apache/sqoop/json/TestDriverConfigBean.java fcce7b5
> common/src/test/java/org/apache/sqoop/json/TestJobBean.java 78a3420
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 9ca6b64
> common/src/test/java/org/apache/sqoop/json/TestUtil.java 9875219
> common/src/test/java/org/apache/sqoop/json/TestValidationBean.java f5f3389
> common/src/test/java/org/apache/sqoop/json/TestValidationResultBean.java 5c094fb
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/util/TestFormSerialization.java c4223ec
> common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/model/TestFormUtils.java 18c9692
> common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java af0f450
> common/src/test/java/org/apache/sqoop/model/TestMConfig.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/model/TestMConnectionForms.java 243fff9
> common/src/test/java/org/apache/sqoop/model/TestMConnector.java d8bc94d
> common/src/test/java/org/apache/sqoop/model/TestMDriverConfig.java 9c23cc3
> common/src/test/java/org/apache/sqoop/model/TestMForm.java 536b650
> common/src/test/java/org/apache/sqoop/model/TestMFormList.java b8d3d37
> common/src/test/java/org/apache/sqoop/model/TestMJob.java 8f2943e
> common/src/test/java/org/apache/sqoop/model/TestMJobConfig.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/model/TestMJobForms.java e59b282
> common/src/test/java/org/apache/sqoop/model/TestMLink.java 77fa2a9
> common/src/test/java/org/apache/sqoop/model/TestMLinkConfig.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/validation/TestValidation.java 85e9e1c
> common/src/test/java/org/apache/sqoop/validation/TestValidationRunner.java 647abe0
> common/src/test/java/org/apache/sqoop/validation/validators/TestClassAvailable.java 62b2e0a
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java b4b6966
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java 8deddb0
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExtractor.java e52610a
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromDestroyer.java d3a893f
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java 9d0c178
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcLoader.java 991e686
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 6b11228
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToDestroyer.java 7bed1d9
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java 5d0ec93
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java ad1ee5c
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java 8b23144
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfiguration.java b036421
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfigurationGroup.java PRE-CREATION
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfig.java 7b76eeb
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfiguration.java 7d614f7
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfigurationGroup.java PRE-CREATION
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfig.java a42a6ec
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfiguration.java ad68681
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfigurationGroup.java PRE-CREATION
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java 1022370
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExtractor.java fbdf9c6
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestFromInitializer.java 54e6acf
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestLoader.java 144b92a
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java ec75e1e
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java a87ce7a
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java 47b186c
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java cd5350e
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 436d243
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsInitializer.java c2dc1a5
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java 4c546ba
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsPartitioner.java 6828de8
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsValidator.java dfa3659
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 2c98051
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfiguration.java f861237
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfigurationGroup.java PRE-CREATION
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java b689854
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfiguration.java 4970821
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfigurationGroup.java PRE-CREATION
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java b1308db
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfiguration.java bba249c
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfigurationGroup.java PRE-CREATION
> connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java c6d2f90
> connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java 552a751
> connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestPartitioner.java 9d177ec
> connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java 3954039
> core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java dbfdc03
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java c87df84
> core/src/main/java/org/apache/sqoop/driver/Driver.java 5297bde
> core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 8d6eb78
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/driver/DriverValidator.java 9cc51dd
> core/src/main/java/org/apache/sqoop/driver/JobManager.java e91c436
> core/src/main/java/org/apache/sqoop/driver/JobRequest.java 63e1e49
> core/src/main/java/org/apache/sqoop/driver/configuration/DriverConfigurationGroup.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.java 908a4eb
> core/src/main/java/org/apache/sqoop/driver/configuration/LinkConfiguration.java 3202844
> core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingConfig.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingForm.java e73007e
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3466116
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java a743491
> core/src/main/java/org/apache/sqoop/repository/Repository.java ea1608a
> core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java ae7be82
> core/src/main/resources/driver-config.properties 9ec5d9e
> core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java 9c39d23
> core/src/test/java/org/apache/sqoop/driver/TestJobManager.java aa3af89
> core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 19b0023
> execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 83c670c
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java b533837
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java aecde40
> execution/mapreduce/src/test/java/org/apache/sqoop/job/JobUtils.java b5435ff
> execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 5662120
> execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 1447e00
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 61dc3b4
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 5dd7970
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 58eed2d
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java ad42901
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 4b95687
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java 15306c2
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverConfigHandling.java 9b18bd3
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java d744693
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java 47350ea
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 8dd1ce2
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java cf0944d
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java d1b6b9a
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java c0d363e
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java b61d3f5
> server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 23fc9f1
> shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java 97d8e6f
> shell/src/main/java/org/apache/sqoop/shell/CloneLinkFunction.java d9babe0
> shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java ccfed31
> shell/src/main/java/org/apache/sqoop/shell/CreateLinkFunction.java 33d60c8
> shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java 2ba75b4
> shell/src/main/java/org/apache/sqoop/shell/ShowDriverConfigFunction.java e6e1004
> shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java e3f1f47
> shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java f500b9e
> shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java 5d69c2a
> shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java 96d1fd8
> shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 30bb63e
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 4d3838c
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigOptions.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/DynamicConfigOptions.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/DynamicFormOptions.java cc63610
> shell/src/main/java/org/apache/sqoop/shell/utils/FormDisplayer.java dcbccef
> shell/src/main/java/org/apache/sqoop/shell/utils/FormFiller.java a0a5dc2
> shell/src/main/java/org/apache/sqoop/shell/utils/FormOptions.java efd002e
> shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicConfigOptions.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicFormOptions.java 87c0776
> shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicConfigOptions.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicFormOptions.java 2952be2
> shell/src/main/resources/shell-resource.properties c0f86f7
> spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java e00b404
> spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 7b78ba0
> spi/src/main/java/org/apache/sqoop/job/etl/Destroyer.java f965bdd
> spi/src/main/java/org/apache/sqoop/job/etl/Extractor.java 34f02c9
> spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java c9ae540
> spi/src/main/java/org/apache/sqoop/job/etl/Loader.java 434dcf6
> spi/src/main/java/org/apache/sqoop/job/etl/Partitioner.java 8156762
> spi/src/main/java/org/apache/sqoop/validation/Validator.java 894f412
> submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 25255ae
> test/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.java 9ecc9da
> test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 6074d36
> test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 63736ab
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java 5e1abc1
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 2dc0613
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java 729f95e
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java 562a6a6
> test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java 507ac53
>
> Diff: https://reviews.apache.org/r/26145/diff/
>
>
> Testing
> -------
>
> mvn test, integration tests
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 26145: SQOOP-1498: Sqoop2 Repository Object
refactoring + renamaing forms to configs
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26145/
-----------------------------------------------------------
(Updated Oct. 2, 2014, 4:02 p.m.)
Review request for Sqoop.
Bugs: SQOOP-1498
https://issues.apache.org/jira/browse/SQOOP-1498
Repository: sqoop-SQOOP-1367
Description
-------
Sqoop2 Repository Object refactoring
- see JIRA for the details on the changes to the model objects MConnector, MJob, MLink, M*Config
- rename forms to configs
- renames to the db repository to accomodate the renames in models/ fields
- rename validator to reflect that they actually validate configs
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java d7e6768
client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java 2855de6
client/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.java 7b2ddc2
client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java fd858ec
client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java 2b784c8
client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java 54ea3d2
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d726a14
common/src/main/java/org/apache/sqoop/json/DriverConfigBean.java a2cc8b8
common/src/main/java/org/apache/sqoop/json/JobBean.java a3e6071
common/src/main/java/org/apache/sqoop/json/JobValidationBean.java 34c0a4b
common/src/main/java/org/apache/sqoop/json/LinkBean.java 8981ea7
common/src/main/java/org/apache/sqoop/json/LinkValidationBean.java a6a6b65
common/src/main/java/org/apache/sqoop/json/ThrowableBean.java fc63ed4
common/src/main/java/org/apache/sqoop/json/ValidationResultBean.java 89bc8db
common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 77f6191
common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java 20ee5f3
common/src/main/java/org/apache/sqoop/model/Config.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigClass.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigUtils.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigurationClass.java 73374d8
common/src/main/java/org/apache/sqoop/model/ConfigurationGroupClass.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/Form.java 4321582
common/src/main/java/org/apache/sqoop/model/FormClass.java 6048d03
common/src/main/java/org/apache/sqoop/model/FormUtils.java ae025ab
common/src/main/java/org/apache/sqoop/model/MConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConfigList.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConfigType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConnectionForms.java 457ccdb
common/src/main/java/org/apache/sqoop/model/MConnector.java 7999b08
common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 62eb197
common/src/main/java/org/apache/sqoop/model/MForm.java ff94660
common/src/main/java/org/apache/sqoop/model/MFormList.java 9130ada
common/src/main/java/org/apache/sqoop/model/MFormType.java 2f403df
common/src/main/java/org/apache/sqoop/model/MFromConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MJob.java c9b45a5
common/src/main/java/org/apache/sqoop/model/MJobForms.java 08b9a78
common/src/main/java/org/apache/sqoop/model/MLink.java 6a8c424
common/src/main/java/org/apache/sqoop/model/MLinkConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MToConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ModelError.java 470b61c
common/src/main/java/org/apache/sqoop/utils/ClassUtils.java eca9f7e
common/src/main/java/org/apache/sqoop/validation/ConfigValidationError.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/ConfigValidationResult.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/ConfigValidationRunner.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/Message.java cb55b6a
common/src/main/java/org/apache/sqoop/validation/Validation.java fce6e88
common/src/main/java/org/apache/sqoop/validation/ValidationError.java 264d6e3
common/src/main/java/org/apache/sqoop/validation/ValidationResult.java ae8f1d1
common/src/main/java/org/apache/sqoop/validation/ValidationRunner.java f36faf2
common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java fe75ee0
common/src/test/java/org/apache/sqoop/json/TestDriverConfigBean.java fcce7b5
common/src/test/java/org/apache/sqoop/json/TestJobBean.java 78a3420
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 9ca6b64
common/src/test/java/org/apache/sqoop/json/TestUtil.java 9875219
common/src/test/java/org/apache/sqoop/json/TestValidationBean.java f5f3389
common/src/test/java/org/apache/sqoop/json/TestValidationResultBean.java 5c094fb
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/util/TestFormSerialization.java c4223ec
common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestFormUtils.java 18c9692
common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java af0f450
common/src/test/java/org/apache/sqoop/model/TestMConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMConnectionForms.java 243fff9
common/src/test/java/org/apache/sqoop/model/TestMConnector.java d8bc94d
common/src/test/java/org/apache/sqoop/model/TestMDriverConfig.java 9c23cc3
common/src/test/java/org/apache/sqoop/model/TestMForm.java 536b650
common/src/test/java/org/apache/sqoop/model/TestMFormList.java b8d3d37
common/src/test/java/org/apache/sqoop/model/TestMJob.java 8f2943e
common/src/test/java/org/apache/sqoop/model/TestMJobConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMJobForms.java e59b282
common/src/test/java/org/apache/sqoop/model/TestMLink.java 77fa2a9
common/src/test/java/org/apache/sqoop/model/TestMLinkConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/validation/TestValidation.java 85e9e1c
common/src/test/java/org/apache/sqoop/validation/TestValidationRunner.java 647abe0
common/src/test/java/org/apache/sqoop/validation/validators/TestClassAvailable.java 62b2e0a
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java b4b6966
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java 8deddb0
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExtractor.java e52610a
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromDestroyer.java d3a893f
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java 9d0c178
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcLoader.java 991e686
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 6b11228
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToDestroyer.java 7bed1d9
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java 5d0ec93
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java ad1ee5c
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java 8b23144
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfiguration.java b036421
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfigurationGroup.java PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfig.java 7b76eeb
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfiguration.java 7d614f7
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfigurationGroup.java PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfig.java a42a6ec
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfiguration.java ad68681
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfigurationGroup.java PRE-CREATION
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java 1022370
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExtractor.java fbdf9c6
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestFromInitializer.java 54e6acf
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestLoader.java 144b92a
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java ec75e1e
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java a87ce7a
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java 47b186c
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java cd5350e
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 436d243
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsInitializer.java c2dc1a5
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java 4c546ba
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsPartitioner.java 6828de8
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsValidator.java dfa3659
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 2c98051
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfiguration.java f861237
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfigurationGroup.java PRE-CREATION
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java b689854
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfiguration.java 4970821
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfigurationGroup.java PRE-CREATION
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java b1308db
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfiguration.java bba249c
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfigurationGroup.java PRE-CREATION
connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java c6d2f90
connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java 552a751
connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestPartitioner.java 9d177ec
connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java 3954039
core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java dbfdc03
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java c87df84
core/src/main/java/org/apache/sqoop/driver/Driver.java 5297bde
core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 8d6eb78
core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/DriverValidator.java 9cc51dd
core/src/main/java/org/apache/sqoop/driver/JobManager.java e91c436
core/src/main/java/org/apache/sqoop/driver/JobRequest.java 63e1e49
core/src/main/java/org/apache/sqoop/driver/configuration/DriverConfigurationGroup.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.java 908a4eb
core/src/main/java/org/apache/sqoop/driver/configuration/LinkConfiguration.java 3202844
core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingConfig.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingForm.java e73007e
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3466116
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java a743491
core/src/main/java/org/apache/sqoop/repository/Repository.java ea1608a
core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java ae7be82
core/src/main/resources/driver-config.properties 9ec5d9e
core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java 9c39d23
core/src/test/java/org/apache/sqoop/driver/TestJobManager.java aa3af89
core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 19b0023
execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 83c670c
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java b533837
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java aecde40
execution/mapreduce/src/test/java/org/apache/sqoop/job/JobUtils.java b5435ff
execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 5662120
execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 1447e00
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 61dc3b4
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 5dd7970
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 58eed2d
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java ad42901
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 4b95687
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java 15306c2
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverConfigHandling.java 9b18bd3
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java d744693
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java 47350ea
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 8dd1ce2
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java cf0944d
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java d1b6b9a
server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java c0d363e
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java b61d3f5
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 23fc9f1
shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java 97d8e6f
shell/src/main/java/org/apache/sqoop/shell/CloneLinkFunction.java d9babe0
shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java ccfed31
shell/src/main/java/org/apache/sqoop/shell/CreateLinkFunction.java 33d60c8
shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java 2ba75b4
shell/src/main/java/org/apache/sqoop/shell/ShowDriverConfigFunction.java e6e1004
shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java e3f1f47
shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java f500b9e
shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java 5d69c2a
shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java 96d1fd8
shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 30bb63e
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 4d3838c
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/DynamicConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/DynamicFormOptions.java cc63610
shell/src/main/java/org/apache/sqoop/shell/utils/FormDisplayer.java dcbccef
shell/src/main/java/org/apache/sqoop/shell/utils/FormFiller.java a0a5dc2
shell/src/main/java/org/apache/sqoop/shell/utils/FormOptions.java efd002e
shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicFormOptions.java 87c0776
shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicFormOptions.java 2952be2
shell/src/main/resources/shell-resource.properties c0f86f7
spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java e00b404
spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 7b78ba0
spi/src/main/java/org/apache/sqoop/job/etl/Destroyer.java f965bdd
spi/src/main/java/org/apache/sqoop/job/etl/Extractor.java 34f02c9
spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java c9ae540
spi/src/main/java/org/apache/sqoop/job/etl/Loader.java 434dcf6
spi/src/main/java/org/apache/sqoop/job/etl/Partitioner.java 8156762
spi/src/main/java/org/apache/sqoop/validation/Validator.java 894f412
submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 25255ae
test/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.java 9ecc9da
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 6074d36
test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 63736ab
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java 5e1abc1
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 2dc0613
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java 729f95e
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java 562a6a6
test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java 507ac53
Diff: https://reviews.apache.org/r/26145/diff/
Testing
-------
mvn test, integration tests
Thanks,
Veena Basavaraj
Re: Review Request 26145: SQOOP-1498: Sqoop2 Repository Object
refactoring + renamaing forms to configs
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26145/
-----------------------------------------------------------
(Updated Oct. 2, 2014, 3:47 p.m.)
Review request for Sqoop.
Changes
-------
remove the class files that got into the RB accidentally. ( discard rev 5, do not consider it when reviewing)
also renamed the config group related entities
Bugs: SQOOP-1498
https://issues.apache.org/jira/browse/SQOOP-1498
Repository: sqoop-SQOOP-1367
Description
-------
Sqoop2 Repository Object refactoring
- see JIRA for the details on the changes to the model objects MConnector, MJob, MLink, M*Config
- rename forms to configs
- renames to the db repository to accomodate the renames in models/ fields
- rename validator to reflect that they actually validate configs
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java d7e6768
client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java 2855de6
client/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.java 7b2ddc2
client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java fd858ec
client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java 2b784c8
client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java 54ea3d2
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d726a14
common/src/main/java/org/apache/sqoop/json/DriverConfigBean.java a2cc8b8
common/src/main/java/org/apache/sqoop/json/JobBean.java a3e6071
common/src/main/java/org/apache/sqoop/json/JobValidationBean.java 34c0a4b
common/src/main/java/org/apache/sqoop/json/LinkBean.java 8981ea7
common/src/main/java/org/apache/sqoop/json/LinkValidationBean.java a6a6b65
common/src/main/java/org/apache/sqoop/json/ThrowableBean.java fc63ed4
common/src/main/java/org/apache/sqoop/json/ValidationResultBean.java 89bc8db
common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 77f6191
common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java 20ee5f3
common/src/main/java/org/apache/sqoop/model/Config.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigClass.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigUtils.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigurationClass.java 73374d8
common/src/main/java/org/apache/sqoop/model/ConfigurationGroupClass.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/Form.java 4321582
common/src/main/java/org/apache/sqoop/model/FormClass.java 6048d03
common/src/main/java/org/apache/sqoop/model/FormUtils.java ae025ab
common/src/main/java/org/apache/sqoop/model/MConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConfigList.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConfigType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConnectionForms.java 457ccdb
common/src/main/java/org/apache/sqoop/model/MConnector.java 7999b08
common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 62eb197
common/src/main/java/org/apache/sqoop/model/MForm.java ff94660
common/src/main/java/org/apache/sqoop/model/MFormList.java 9130ada
common/src/main/java/org/apache/sqoop/model/MFormType.java 2f403df
common/src/main/java/org/apache/sqoop/model/MFromConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MJob.java c9b45a5
common/src/main/java/org/apache/sqoop/model/MJobForms.java 08b9a78
common/src/main/java/org/apache/sqoop/model/MLink.java 6a8c424
common/src/main/java/org/apache/sqoop/model/MLinkConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MToConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ModelError.java 470b61c
common/src/main/java/org/apache/sqoop/utils/ClassUtils.java eca9f7e
common/src/main/java/org/apache/sqoop/validation/ConfigValidationError.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/ConfigValidationResult.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/ConfigValidationRunner.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/Message.java cb55b6a
common/src/main/java/org/apache/sqoop/validation/Validation.java fce6e88
common/src/main/java/org/apache/sqoop/validation/ValidationError.java 264d6e3
common/src/main/java/org/apache/sqoop/validation/ValidationResult.java ae8f1d1
common/src/main/java/org/apache/sqoop/validation/ValidationRunner.java f36faf2
common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java fe75ee0
common/src/test/java/org/apache/sqoop/json/TestDriverConfigBean.java fcce7b5
common/src/test/java/org/apache/sqoop/json/TestJobBean.java 78a3420
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 9ca6b64
common/src/test/java/org/apache/sqoop/json/TestUtil.java 9875219
common/src/test/java/org/apache/sqoop/json/TestValidationBean.java f5f3389
common/src/test/java/org/apache/sqoop/json/TestValidationResultBean.java 5c094fb
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/util/TestFormSerialization.java c4223ec
common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestFormUtils.java 18c9692
common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java af0f450
common/src/test/java/org/apache/sqoop/model/TestMConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMConnectionForms.java 243fff9
common/src/test/java/org/apache/sqoop/model/TestMConnector.java d8bc94d
common/src/test/java/org/apache/sqoop/model/TestMDriverConfig.java 9c23cc3
common/src/test/java/org/apache/sqoop/model/TestMForm.java 536b650
common/src/test/java/org/apache/sqoop/model/TestMFormList.java b8d3d37
common/src/test/java/org/apache/sqoop/model/TestMJob.java 8f2943e
common/src/test/java/org/apache/sqoop/model/TestMJobConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMJobForms.java e59b282
common/src/test/java/org/apache/sqoop/model/TestMLink.java 77fa2a9
common/src/test/java/org/apache/sqoop/model/TestMLinkConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/validation/TestValidation.java 85e9e1c
common/src/test/java/org/apache/sqoop/validation/TestValidationRunner.java 647abe0
common/src/test/java/org/apache/sqoop/validation/validators/TestClassAvailable.java 62b2e0a
connector/connector-generic-jdbc/.gitignore PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java b4b6966
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java 8deddb0
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExtractor.java e52610a
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromDestroyer.java d3a893f
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java 9d0c178
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcLoader.java 991e686
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 6b11228
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToDestroyer.java 7bed1d9
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java 5d0ec93
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java ad1ee5c
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java 8b23144
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfiguration.java b036421
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfigurationGroup.java PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfig.java 7b76eeb
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfiguration.java 7d614f7
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfigurationGroup.java PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfig.java a42a6ec
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfiguration.java ad68681
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfigurationGroup.java PRE-CREATION
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java 1022370
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExtractor.java fbdf9c6
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestFromInitializer.java 54e6acf
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestLoader.java 144b92a
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java ec75e1e
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java a87ce7a
connector/connector-hdfs/.gitignore PRE-CREATION
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java 47b186c
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java cd5350e
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 436d243
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsInitializer.java c2dc1a5
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java 4c546ba
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsPartitioner.java 6828de8
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsValidator.java dfa3659
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 2c98051
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfiguration.java f861237
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfigurationGroup.java PRE-CREATION
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java b689854
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfiguration.java 4970821
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfigurationGroup.java PRE-CREATION
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java b1308db
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfiguration.java bba249c
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfigurationGroup.java PRE-CREATION
connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java c6d2f90
connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java 552a751
connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestPartitioner.java 9d177ec
connector/connector-sdk/.gitignore PRE-CREATION
connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java 3954039
core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java dbfdc03
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java c87df84
core/src/main/java/org/apache/sqoop/driver/Driver.java 5297bde
core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 8d6eb78
core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/DriverValidator.java 9cc51dd
core/src/main/java/org/apache/sqoop/driver/JobManager.java e91c436
core/src/main/java/org/apache/sqoop/driver/JobRequest.java 63e1e49
core/src/main/java/org/apache/sqoop/driver/configuration/DriverConfigurationGroup.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.java 908a4eb
core/src/main/java/org/apache/sqoop/driver/configuration/LinkConfiguration.java 3202844
core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingConfig.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingForm.java e73007e
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3466116
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java a743491
core/src/main/java/org/apache/sqoop/repository/Repository.java ea1608a
core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java ae7be82
core/src/main/resources/driver-config.properties 9ec5d9e
core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java 9c39d23
core/src/test/java/org/apache/sqoop/driver/TestJobManager.java aa3af89
core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 19b0023
execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 83c670c
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java b533837
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java aecde40
execution/mapreduce/src/test/java/org/apache/sqoop/job/JobUtils.java b5435ff
execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 5662120
execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 1447e00
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 61dc3b4
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 5dd7970
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 58eed2d
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java ad42901
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 4b95687
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java 15306c2
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverConfigHandling.java 9b18bd3
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java d744693
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java 47350ea
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 8dd1ce2
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java cf0944d
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java d1b6b9a
server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java c0d363e
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java b61d3f5
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 23fc9f1
shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java 97d8e6f
shell/src/main/java/org/apache/sqoop/shell/CloneLinkFunction.java d9babe0
shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java ccfed31
shell/src/main/java/org/apache/sqoop/shell/CreateLinkFunction.java 33d60c8
shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java 2ba75b4
shell/src/main/java/org/apache/sqoop/shell/ShowDriverConfigFunction.java e6e1004
shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java e3f1f47
shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java f500b9e
shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java 5d69c2a
shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java 96d1fd8
shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 30bb63e
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 4d3838c
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/DynamicConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/DynamicFormOptions.java cc63610
shell/src/main/java/org/apache/sqoop/shell/utils/FormDisplayer.java dcbccef
shell/src/main/java/org/apache/sqoop/shell/utils/FormFiller.java a0a5dc2
shell/src/main/java/org/apache/sqoop/shell/utils/FormOptions.java efd002e
shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicFormOptions.java 87c0776
shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicFormOptions.java 2952be2
shell/src/main/resources/shell-resource.properties c0f86f7
spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java e00b404
spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 7b78ba0
spi/src/main/java/org/apache/sqoop/job/etl/Destroyer.java f965bdd
spi/src/main/java/org/apache/sqoop/job/etl/Extractor.java 34f02c9
spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java c9ae540
spi/src/main/java/org/apache/sqoop/job/etl/Loader.java 434dcf6
spi/src/main/java/org/apache/sqoop/job/etl/Partitioner.java 8156762
spi/src/main/java/org/apache/sqoop/validation/Validator.java 894f412
submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 25255ae
test/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.java 9ecc9da
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 6074d36
test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 63736ab
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java 5e1abc1
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 2dc0613
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java 729f95e
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java 562a6a6
test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java 507ac53
Diff: https://reviews.apache.org/r/26145/diff/
Testing
-------
mvn test, integration tests
Thanks,
Veena Basavaraj
Re: Review Request 26145: SQOOP-1498: Sqoop2 Repository Object
refactoring + renamaing forms to configs
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 2, 2014, 3:12 p.m., Abraham Elmahrek wrote:
> > Noticed a couple of things:
> > 1. There are a few .gitignore files that shouldn't be in the code base.
> > 2. ConfigurationGroupClass is a bit unintuitive with the SPI SqoopConnector. I don't think we should change SqoopConnector, can we have this be ConfigurationClass? Or LinkConfiguration/FromJobConfiguration/ToJobConfiguration? Or ConfigurationClass(type=From/To/Link)?
> >
> > LGTM other than this.
As discussed, I have created another ticket to add more descriptive annotation for the 3 types.
https://issues.apache.org/jira/browse/SQOOP-1552
sad abt .gitignore creeping in.
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26145/#review55258
-----------------------------------------------------------
On Oct. 2, 2014, 3:47 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26145/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 3:47 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1498
> https://issues.apache.org/jira/browse/SQOOP-1498
>
>
> Repository: sqoop-SQOOP-1367
>
>
> Description
> -------
>
> Sqoop2 Repository Object refactoring
>
> - see JIRA for the details on the changes to the model objects MConnector, MJob, MLink, M*Config
> - rename forms to configs
> - renames to the db repository to accomodate the renames in models/ fields
> - rename validator to reflect that they actually validate configs
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java d7e6768
> client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java 2855de6
> client/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.java 7b2ddc2
> client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java fd858ec
> client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java 2b784c8
> client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java 54ea3d2
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d726a14
> common/src/main/java/org/apache/sqoop/json/DriverConfigBean.java a2cc8b8
> common/src/main/java/org/apache/sqoop/json/JobBean.java a3e6071
> common/src/main/java/org/apache/sqoop/json/JobValidationBean.java 34c0a4b
> common/src/main/java/org/apache/sqoop/json/LinkBean.java 8981ea7
> common/src/main/java/org/apache/sqoop/json/LinkValidationBean.java a6a6b65
> common/src/main/java/org/apache/sqoop/json/ThrowableBean.java fc63ed4
> common/src/main/java/org/apache/sqoop/json/ValidationResultBean.java 89bc8db
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 77f6191
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java 20ee5f3
> common/src/main/java/org/apache/sqoop/model/Config.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/ConfigClass.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/ConfigurationClass.java 73374d8
> common/src/main/java/org/apache/sqoop/model/ConfigurationGroupClass.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/Form.java 4321582
> common/src/main/java/org/apache/sqoop/model/FormClass.java 6048d03
> common/src/main/java/org/apache/sqoop/model/FormUtils.java ae025ab
> common/src/main/java/org/apache/sqoop/model/MConfig.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MConfigList.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MConfigType.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MConnectionForms.java 457ccdb
> common/src/main/java/org/apache/sqoop/model/MConnector.java 7999b08
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 62eb197
> common/src/main/java/org/apache/sqoop/model/MForm.java ff94660
> common/src/main/java/org/apache/sqoop/model/MFormList.java 9130ada
> common/src/main/java/org/apache/sqoop/model/MFormType.java 2f403df
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MJob.java c9b45a5
> common/src/main/java/org/apache/sqoop/model/MJobForms.java 08b9a78
> common/src/main/java/org/apache/sqoop/model/MLink.java 6a8c424
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MToConfig.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/ModelError.java 470b61c
> common/src/main/java/org/apache/sqoop/utils/ClassUtils.java eca9f7e
> common/src/main/java/org/apache/sqoop/validation/ConfigValidationError.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/validation/ConfigValidationResult.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/validation/ConfigValidationRunner.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/validation/Message.java cb55b6a
> common/src/main/java/org/apache/sqoop/validation/Validation.java fce6e88
> common/src/main/java/org/apache/sqoop/validation/ValidationError.java 264d6e3
> common/src/main/java/org/apache/sqoop/validation/ValidationResult.java ae8f1d1
> common/src/main/java/org/apache/sqoop/validation/ValidationRunner.java f36faf2
> common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java fe75ee0
> common/src/test/java/org/apache/sqoop/json/TestDriverConfigBean.java fcce7b5
> common/src/test/java/org/apache/sqoop/json/TestJobBean.java 78a3420
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 9ca6b64
> common/src/test/java/org/apache/sqoop/json/TestUtil.java 9875219
> common/src/test/java/org/apache/sqoop/json/TestValidationBean.java f5f3389
> common/src/test/java/org/apache/sqoop/json/TestValidationResultBean.java 5c094fb
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/util/TestFormSerialization.java c4223ec
> common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/model/TestFormUtils.java 18c9692
> common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java af0f450
> common/src/test/java/org/apache/sqoop/model/TestMConfig.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/model/TestMConnectionForms.java 243fff9
> common/src/test/java/org/apache/sqoop/model/TestMConnector.java d8bc94d
> common/src/test/java/org/apache/sqoop/model/TestMDriverConfig.java 9c23cc3
> common/src/test/java/org/apache/sqoop/model/TestMForm.java 536b650
> common/src/test/java/org/apache/sqoop/model/TestMFormList.java b8d3d37
> common/src/test/java/org/apache/sqoop/model/TestMJob.java 8f2943e
> common/src/test/java/org/apache/sqoop/model/TestMJobConfig.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/model/TestMJobForms.java e59b282
> common/src/test/java/org/apache/sqoop/model/TestMLink.java 77fa2a9
> common/src/test/java/org/apache/sqoop/model/TestMLinkConfig.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/validation/TestValidation.java 85e9e1c
> common/src/test/java/org/apache/sqoop/validation/TestValidationRunner.java 647abe0
> common/src/test/java/org/apache/sqoop/validation/validators/TestClassAvailable.java 62b2e0a
> connector/connector-generic-jdbc/.gitignore PRE-CREATION
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java b4b6966
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java 8deddb0
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExtractor.java e52610a
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromDestroyer.java d3a893f
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java 9d0c178
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcLoader.java 991e686
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java 6b11228
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToDestroyer.java 7bed1d9
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java 5d0ec93
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java ad1ee5c
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java 8b23144
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfiguration.java b036421
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfigurationGroup.java PRE-CREATION
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfig.java 7b76eeb
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfiguration.java 7d614f7
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfigurationGroup.java PRE-CREATION
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfig.java a42a6ec
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfiguration.java ad68681
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfigurationGroup.java PRE-CREATION
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java 1022370
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExtractor.java fbdf9c6
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestFromInitializer.java 54e6acf
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestLoader.java 144b92a
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java ec75e1e
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java a87ce7a
> connector/connector-hdfs/.gitignore PRE-CREATION
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java 47b186c
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java cd5350e
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 436d243
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsInitializer.java c2dc1a5
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java 4c546ba
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsPartitioner.java 6828de8
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsValidator.java dfa3659
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 2c98051
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfiguration.java f861237
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfigurationGroup.java PRE-CREATION
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java b689854
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfiguration.java 4970821
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfigurationGroup.java PRE-CREATION
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java b1308db
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfiguration.java bba249c
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfigurationGroup.java PRE-CREATION
> connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java c6d2f90
> connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java 552a751
> connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestPartitioner.java 9d177ec
> connector/connector-sdk/.gitignore PRE-CREATION
> connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java 3954039
> core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java dbfdc03
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java c87df84
> core/src/main/java/org/apache/sqoop/driver/Driver.java 5297bde
> core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 8d6eb78
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/driver/DriverValidator.java 9cc51dd
> core/src/main/java/org/apache/sqoop/driver/JobManager.java e91c436
> core/src/main/java/org/apache/sqoop/driver/JobRequest.java 63e1e49
> core/src/main/java/org/apache/sqoop/driver/configuration/DriverConfigurationGroup.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.java 908a4eb
> core/src/main/java/org/apache/sqoop/driver/configuration/LinkConfiguration.java 3202844
> core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingConfig.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingForm.java e73007e
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3466116
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java a743491
> core/src/main/java/org/apache/sqoop/repository/Repository.java ea1608a
> core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java ae7be82
> core/src/main/resources/driver-config.properties 9ec5d9e
> core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java 9c39d23
> core/src/test/java/org/apache/sqoop/driver/TestJobManager.java aa3af89
> core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 19b0023
> execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 83c670c
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java b533837
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java aecde40
> execution/mapreduce/src/test/java/org/apache/sqoop/job/JobUtils.java b5435ff
> execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 5662120
> execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 1447e00
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 61dc3b4
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 5dd7970
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 58eed2d
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java ad42901
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 4b95687
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java 15306c2
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverConfigHandling.java 9b18bd3
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java d744693
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java 47350ea
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 8dd1ce2
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java cf0944d
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java d1b6b9a
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java c0d363e
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java b61d3f5
> server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 23fc9f1
> shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java 97d8e6f
> shell/src/main/java/org/apache/sqoop/shell/CloneLinkFunction.java d9babe0
> shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java ccfed31
> shell/src/main/java/org/apache/sqoop/shell/CreateLinkFunction.java 33d60c8
> shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java 2ba75b4
> shell/src/main/java/org/apache/sqoop/shell/ShowDriverConfigFunction.java e6e1004
> shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java e3f1f47
> shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java f500b9e
> shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java 5d69c2a
> shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java 96d1fd8
> shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 30bb63e
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 4d3838c
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigOptions.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/DynamicConfigOptions.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/DynamicFormOptions.java cc63610
> shell/src/main/java/org/apache/sqoop/shell/utils/FormDisplayer.java dcbccef
> shell/src/main/java/org/apache/sqoop/shell/utils/FormFiller.java a0a5dc2
> shell/src/main/java/org/apache/sqoop/shell/utils/FormOptions.java efd002e
> shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicConfigOptions.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicFormOptions.java 87c0776
> shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicConfigOptions.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicFormOptions.java 2952be2
> shell/src/main/resources/shell-resource.properties c0f86f7
> spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java e00b404
> spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 7b78ba0
> spi/src/main/java/org/apache/sqoop/job/etl/Destroyer.java f965bdd
> spi/src/main/java/org/apache/sqoop/job/etl/Extractor.java 34f02c9
> spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java c9ae540
> spi/src/main/java/org/apache/sqoop/job/etl/Loader.java 434dcf6
> spi/src/main/java/org/apache/sqoop/job/etl/Partitioner.java 8156762
> spi/src/main/java/org/apache/sqoop/validation/Validator.java 894f412
> submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 25255ae
> test/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.java 9ecc9da
> test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 6074d36
> test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 63736ab
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java 5e1abc1
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 2dc0613
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java 729f95e
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java 562a6a6
> test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java 507ac53
>
> Diff: https://reviews.apache.org/r/26145/diff/
>
>
> Testing
> -------
>
> mvn test, integration tests
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 26145: SQOOP-1498: Sqoop2 Repository Object
refactoring + renamaing forms to configs
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26145/#review55258
-----------------------------------------------------------
Ship it!
Noticed a couple of things:
1. There are a few .gitignore files that shouldn't be in the code base.
2. ConfigurationGroupClass is a bit unintuitive with the SPI SqoopConnector. I don't think we should change SqoopConnector, can we have this be ConfigurationClass? Or LinkConfiguration/FromJobConfiguration/ToJobConfiguration? Or ConfigurationClass(type=From/To/Link)?
LGTM other than this.
- Abraham Elmahrek
On Oct. 2, 2014, 8:09 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26145/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 8:09 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1498
> https://issues.apache.org/jira/browse/SQOOP-1498
>
>
> Repository: sqoop-SQOOP-1367
>
>
> Description
> -------
>
> Sqoop2 Repository Object refactoring
>
> - see JIRA for the details on the changes to the model objects MConnector, MJob, MLink, M*Config
> - rename forms to configs
> - renames to the db repository to accomodate the renames in models/ fields
> - rename validator to reflect that they actually validate configs
>
>
> Diffs
> -----
>
> client/bin/pom.xml PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/ClientError.class PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/SqoopClient$SubmissionStatus.class PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/SqoopClient.class PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/SubmissionCallback.class PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.class PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.class PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.class PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.class PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/request/ResourceRequest$ServerExceptionFilter.class PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/request/ResourceRequest.class PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.class PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.class PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/request/VersionResourceRequest.class PRE-CREATION
> client/bin/src/main/resources/log4j.properties PRE-CREATION
> client/bin/src/test/java/org/apache/sqoop/client/TestSqoopClient.class PRE-CREATION
> client/bin/src/test/resources/log4j.properties PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java d7e6768
> client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java 2855de6
> client/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.java 7b2ddc2
> client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java fd858ec
> client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java 2b784c8
> client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java 54ea3d2
> common/.gitignore PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d726a14
> common/src/main/java/org/apache/sqoop/json/DriverConfigBean.java a2cc8b8
> common/src/main/java/org/apache/sqoop/json/JobBean.java a3e6071
> common/src/main/java/org/apache/sqoop/json/JobValidationBean.java 34c0a4b
> common/src/main/java/org/apache/sqoop/json/LinkBean.java 8981ea7
> common/src/main/java/org/apache/sqoop/json/LinkValidationBean.java a6a6b65
> common/src/main/java/org/apache/sqoop/json/ThrowableBean.java fc63ed4
> common/src/main/java/org/apache/sqoop/json/ValidationResultBean.java 89bc8db
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 77f6191
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java 20ee5f3
> common/src/main/java/org/apache/sqoop/model/Config.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/ConfigClass.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/ConfigurationClass.java 73374d8
> common/src/main/java/org/apache/sqoop/model/ConfigurationGroupClass.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/Form.java 4321582
> common/src/main/java/org/apache/sqoop/model/FormClass.java 6048d03
> common/src/main/java/org/apache/sqoop/model/FormUtils.java ae025ab
> common/src/main/java/org/apache/sqoop/model/MConfig.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MConfigList.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MConfigType.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MConnectionForms.java 457ccdb
> common/src/main/java/org/apache/sqoop/model/MConnector.java 7999b08
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 62eb197
> common/src/main/java/org/apache/sqoop/model/MForm.java ff94660
> common/src/main/java/org/apache/sqoop/model/MFormList.java 9130ada
> common/src/main/java/org/apache/sqoop/model/MFormType.java 2f403df
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MJob.java c9b45a5
> common/src/main/java/org/apache/sqoop/model/MJobForms.java 08b9a78
> common/src/main/java/org/apache/sqoop/model/MLink.java 6a8c424
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MToConfig.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/ModelError.java 470b61c
> common/src/main/java/org/apache/sqoop/validation/ConfigValidationError.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/validation/ConfigValidationResult.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/validation/ConfigValidationRunner.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/validation/Validation.java fce6e88
> common/src/main/java/org/apache/sqoop/validation/ValidationError.java 264d6e3
> common/src/main/java/org/apache/sqoop/validation/ValidationResult.java ae8f1d1
> common/src/main/java/org/apache/sqoop/validation/ValidationRunner.java f36faf2
> common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java fe75ee0
> common/src/test/java/org/apache/sqoop/json/TestDriverConfigBean.java fcce7b5
> common/src/test/java/org/apache/sqoop/json/TestJobBean.java 78a3420
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 9ca6b64
> common/src/test/java/org/apache/sqoop/json/TestUtil.java 9875219
> common/src/test/java/org/apache/sqoop/json/TestValidationBean.java f5f3389
> common/src/test/java/org/apache/sqoop/json/TestValidationResultBean.java 5c094fb
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/util/TestFormSerialization.java c4223ec
> common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/model/TestFormUtils.java 18c9692
> common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java af0f450
> common/src/test/java/org/apache/sqoop/model/TestMConfig.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/model/TestMConnectionForms.java 243fff9
> common/src/test/java/org/apache/sqoop/model/TestMConnector.java d8bc94d
> common/src/test/java/org/apache/sqoop/model/TestMDriverConfig.java 9c23cc3
> common/src/test/java/org/apache/sqoop/model/TestMForm.java 536b650
> common/src/test/java/org/apache/sqoop/model/TestMFormList.java b8d3d37
> common/src/test/java/org/apache/sqoop/model/TestMJob.java 8f2943e
> common/src/test/java/org/apache/sqoop/model/TestMJobConfig.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/model/TestMJobForms.java e59b282
> common/src/test/java/org/apache/sqoop/model/TestMLink.java 77fa2a9
> common/src/test/java/org/apache/sqoop/model/TestMLinkConfig.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/validation/TestValidation.java 85e9e1c
> common/src/test/java/org/apache/sqoop/validation/TestValidationRunner.java 647abe0
> connector/connector-generic-jdbc/.gitignore PRE-CREATION
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java b4b6966
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java 8deddb0
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java ad1ee5c
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java 8b23144
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfiguration.java b036421
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfig.java 7b76eeb
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfiguration.java 7d614f7
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfig.java a42a6ec
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfiguration.java ad68681
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java 1022370
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java a87ce7a
> connector/connector-hdfs/.gitignore PRE-CREATION
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java 47b186c
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java cd5350e
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsValidator.java dfa3659
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 2c98051
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfiguration.java f861237
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java b689854
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfiguration.java 4970821
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java b1308db
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfiguration.java bba249c
> connector/connector-sdk/.gitignore PRE-CREATION
> core/bin/pom.xml PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/audit/AuditLogger.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/audit/AuditLoggerConstants.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/audit/AuditLoggerError.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/audit/FileAuditLogger.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/connector/ConnectorError.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/connector/ConnectorHandler.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/connector/ConnectorManager.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/connector/ConnectorManagerUtils.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/core/ConfigurationConstants.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/core/ConfigurationListener.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/core/ConfigurationProvider.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/core/CoreError.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/core/PropertiesConfigurationProvider$ConfigFilePoller.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/core/PropertiesConfigurationProvider.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/core/Reconfigurable.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/core/SqoopConfiguration$CoreConfigurationListener.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/core/SqoopConfiguration.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/core/SqoopServer.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/Driver.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/DriverConstants.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/DriverError.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/DriverValidator.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/ExecutionEngine.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/JobManager$PurgeThread.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/JobManager$UpdateThread.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/JobManager.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/JobRequest.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/SubmissionEngine.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/configuration/LinkConfiguration.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingForm.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/JdbcRepository$DoWithConnection.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/JdbcRepository.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/JdbcRepositoryContext.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/JdbcRepositoryTransaction.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/JdbcRepositoryTransactionFactory.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/JdbcTransactionIsolation.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/RepoConfigurationConstants.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/Repository.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/RepositoryError.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/RepositoryManager.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/RepositoryProvider.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/RepositoryTransaction.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/request/HttpEventContext.class PRE-CREATION
> core/bin/src/main/resources/driver-config.properties PRE-CREATION
> core/bin/src/test/java/org/apache/sqoop/core/MockInvalidConfigurationProvider.class PRE-CREATION
> core/bin/src/test/java/org/apache/sqoop/core/TestSqoopConfiguration.class PRE-CREATION
> core/bin/src/test/java/org/apache/sqoop/core/TestUtils.class PRE-CREATION
> core/bin/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.class PRE-CREATION
> core/bin/src/test/java/org/apache/sqoop/driver/TestJobManager.class PRE-CREATION
> core/bin/src/test/java/org/apache/sqoop/driver/TestJobRequest.class PRE-CREATION
> core/bin/src/test/java/org/apache/sqoop/repository/TestJdbcRepository$EmptyConfigurationClass.class PRE-CREATION
> core/bin/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.class PRE-CREATION
> core/bin/src/test/java/org/apache/sqoop/repository/TestRepositoryManager.class PRE-CREATION
> core/bin/src/test/resources/log4j.properties PRE-CREATION
> core/bin/src/test/resources/test_config.properties PRE-CREATION
> core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java dbfdc03
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java c87df84
> core/src/main/java/org/apache/sqoop/driver/Driver.java 5297bde
> core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 8d6eb78
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/driver/DriverValidator.java 9cc51dd
> core/src/main/java/org/apache/sqoop/driver/JobManager.java e91c436
> core/src/main/java/org/apache/sqoop/driver/JobRequest.java 63e1e49
> core/src/main/java/org/apache/sqoop/driver/configuration/DriverConfiguration.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.java 908a4eb
> core/src/main/java/org/apache/sqoop/driver/configuration/LinkConfiguration.java 3202844
> core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingConfig.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingForm.java e73007e
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3466116
> core/src/main/java/org/apache/sqoop/repository/Repository.java ea1608a
> core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java ae7be82
> core/src/main/resources/driver-config.properties 9ec5d9e
> core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java 9c39d23
> core/src/test/java/org/apache/sqoop/driver/TestJobManager.java aa3af89
> core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 19b0023
> docs/.gitignore PRE-CREATION
> execution/mapreduce/bin/pom.xml PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/execution/mapreduce/MRJobRequest.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/JobConstants.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/io/Data.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/io/FieldTypes.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/io/SqoopWritable.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/ProgressRunnable.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat$DestroyerFileOutputCommitter.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat$SqoopRecordReader.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopMapper$SqoopMapDataWriter.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat$DestroyerOutputCommitter.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor$ConsumerThread.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor$SqoopOutputFormatDataReader.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor$SqoopRecordWriter.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.class PRE-CREATION
> execution/mapreduce/bin/src/main/resources/META-INF/log4j.properties PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/JobUtils.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyExtractor.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyFromDestroyer.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyLoader.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyOutputFormat$DummyOutputCommitter.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyOutputFormat$DummyRecordWriter.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyOutputFormat.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyPartition.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyPartitioner.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyToDestroyer.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/io/TestData.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils$Config.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils$F.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor$GoodContinuousLoader.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor$GoodLoader.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor$ThrowingContinuousLoader.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor$ThrowingLoader.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.class PRE-CREATION
> execution/mapreduce/bin/src/test/resources/log4j.properties PRE-CREATION
> execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 83c670c
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java b533837
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java aecde40
> execution/mapreduce/src/test/java/org/apache/sqoop/job/JobUtils.java b5435ff
> execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 5662120
> execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 1447e00
> repository/repository-derby/bin/pom.xml PRE-CREATION
> repository/repository-derby/bin/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.class PRE-CREATION
> repository/repository-derby/bin/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.class PRE-CREATION
> repository/repository-derby/bin/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.class PRE-CREATION
> repository/repository-derby/bin/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.class PRE-CREATION
> repository/repository-derby/bin/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.class PRE-CREATION
> repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.class PRE-CREATION
> repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.class PRE-CREATION
> repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/TestDriverConfigHandling.class PRE-CREATION
> repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.class PRE-CREATION
> repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/TestInternals$TestDerbyRepositoryHandler.class PRE-CREATION
> repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/TestInternals.class PRE-CREATION
> repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.class PRE-CREATION
> repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.class PRE-CREATION
> repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.class PRE-CREATION
> repository/repository-derby/bin/src/test/resources/log4j.properties PRE-CREATION
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 61dc3b4
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 5dd7970
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 58eed2d
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java ad42901
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 4b95687
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java 15306c2
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverConfigHandling.java 9b18bd3
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java d744693
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java 47350ea
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 8dd1ce2
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java cf0944d
> server/bin/pom.xml PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/handler/JobRequestHandler.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/server/RequestContext$Method.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/server/RequestContext.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/server/RequestHandler.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/server/ServerInitializer.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/server/SqoopProtocolServlet.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/server/VersionServlet.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/server/common/ServerError.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/server/v1/JobServlet.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/server/v1/LinkServlet.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.class PRE-CREATION
> server/bin/src/main/webapp/WEB-INF/web.xml PRE-CREATION
> server/bin/src/main/webapp/index.html PRE-CREATION
> server/bin/src/test/resources/log4j.properties PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java d1b6b9a
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java c0d363e
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java b61d3f5
> server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 23fc9f1
> shell/bin/pom.xml PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/CloneCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/CloneJobFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/CloneLinkFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/CreateCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/CreateJobFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/CreateLinkFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/DeleteCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/DeleteJobFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/DeleteLinkFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/DisableCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/DisableJobFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/DisableLinkFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/EnableCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/EnableJobFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/EnableLinkFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/HelpCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/SetCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/SetOptionFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/SetServerFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/ShellEnvironment.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/ShowCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/ShowDriverConfigFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/ShowJobFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/ShowOptionFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/ShowServerFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/ShowSubmissionFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/ShowVersionFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/SqoopCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/SqoopFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/SqoopShell.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/StartCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/StartJobFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/StatusCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/StatusJobFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/StopCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/StopJobFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/UpdateCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/core/Constants.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/core/ShellError.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/utils/DynamicFormOptions.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/utils/FormDisplayer.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/utils/FormFiller.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/utils/FormOptions.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/utils/JobDynamicFormOptions.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicFormOptions.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/utils/SubmissionDisplayer.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/utils/TableDisplayer.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/utils/ThrowableDisplayer.class PRE-CREATION
> shell/bin/src/main/resources/log4j.properties PRE-CREATION
> shell/bin/src/main/resources/shell-resource.properties PRE-CREATION
> shell/bin/src/test/resources/log4j.properties PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java 97d8e6f
> shell/src/main/java/org/apache/sqoop/shell/CloneLinkFunction.java d9babe0
> shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java ccfed31
> shell/src/main/java/org/apache/sqoop/shell/CreateLinkFunction.java 33d60c8
> shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java 2ba75b4
> shell/src/main/java/org/apache/sqoop/shell/ShowDriverConfigFunction.java e6e1004
> shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java e3f1f47
> shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java f500b9e
> shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java 5d69c2a
> shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java 96d1fd8
> shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 30bb63e
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 4d3838c
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigOptions.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/DynamicConfigOptions.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/DynamicFormOptions.java cc63610
> shell/src/main/java/org/apache/sqoop/shell/utils/FormDisplayer.java dcbccef
> shell/src/main/java/org/apache/sqoop/shell/utils/FormFiller.java a0a5dc2
> shell/src/main/java/org/apache/sqoop/shell/utils/FormOptions.java efd002e
> shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicConfigOptions.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicFormOptions.java 87c0776
> shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicConfigOptions.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicFormOptions.java 2952be2
> spi/bin/pom.xml PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/job/Constants.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/job/etl/Destroyer.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/job/etl/Extractor.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/job/etl/From.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/job/etl/Initializer.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/job/etl/Loader.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/job/etl/Partition.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/job/etl/Partitioner.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/job/etl/To.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/job/etl/Transferable.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/validation/Validator$EmptyClass.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/validation/Validator.class PRE-CREATION
> spi/bin/src/test/resources/log4j.properties PRE-CREATION
> spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java e00b404
> spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 7b78ba0
> spi/src/main/java/org/apache/sqoop/validation/Validator.java 894f412
> submission/mapreduce/bin/pom.xml PRE-CREATION
> submission/mapreduce/bin/src/main/java/org/apache/sqoop/submission/mapreduce/Constants.class PRE-CREATION
> submission/mapreduce/bin/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.class PRE-CREATION
> submission/mapreduce/bin/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionError.class PRE-CREATION
> submission/mapreduce/bin/src/test/resources/log4j.properties PRE-CREATION
> submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 25255ae
> test/bin/pom.xml PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/asserts/HdfsAsserts.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/asserts/ProviderAsserts.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/data/Cities.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/data/DataSet.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/data/UbuntuReleases.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/db/DatabaseProvider.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/db/DatabaseProviderFactory.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/db/DerbyProvider.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/db/MySQLProvider.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/db/NetezzaProvider.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/db/OracleProvider.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/db/PostgreSQLProvider.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/db/SqlServerProvider.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/db/TeradataProvider.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/hadoop/HadoopLocalRunner.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/hadoop/HadoopMiniClusterRunner.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/hadoop/HadoopRunner.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/hadoop/HadoopRunnerFactory.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/minicluster/InProcessSqoopMiniCluster.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/utils/HdfsUtils.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/utils/ParametrizedUtils.class PRE-CREATION
> test/bin/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.class PRE-CREATION
> test/bin/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.class PRE-CREATION
> test/bin/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.class PRE-CREATION
> test/bin/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.class PRE-CREATION
> test/bin/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.class PRE-CREATION
> test/bin/src/test/java/org/apache/sqoop/integration/server/VersionTest.class PRE-CREATION
> test/bin/src/test/resources/log4j.properties PRE-CREATION
> test/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.java 9ecc9da
> test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 6074d36
> test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 63736ab
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java 5e1abc1
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 2dc0613
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java 729f95e
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java 562a6a6
> test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java 507ac53
> tomcat/bin/pom.xml PRE-CREATION
> tomcat/bin/src/main/java/org/apache/sqoop/tomcat/TomcatToolRunner.class PRE-CREATION
> tools/bin/pom.xml PRE-CREATION
> tools/bin/src/main/java/org/apache/sqoop/tools/ConfiguredTool.class PRE-CREATION
> tools/bin/src/main/java/org/apache/sqoop/tools/Tool.class PRE-CREATION
> tools/bin/src/main/java/org/apache/sqoop/tools/ToolRunner.class PRE-CREATION
> tools/bin/src/main/java/org/apache/sqoop/tools/tool/BuiltinTools.class PRE-CREATION
> tools/bin/src/main/java/org/apache/sqoop/tools/tool/UpgradeTool.class PRE-CREATION
> tools/bin/src/main/java/org/apache/sqoop/tools/tool/VerifyTool.class PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26145/diff/
>
>
> Testing
> -------
>
> mvn test, integration tests
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 26145: SQOOP-1498: Sqoop2 Repository Object
refactoring + renamaing forms to configs
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26145/#review55259
-----------------------------------------------------------
Noticed a couple of things:
1. There are a few .gitignore files that shouldn't be in the code base.
2. ConfigurationGroupClass is a bit unintuitive with the SPI SqoopConnector. I don't think we should change SqoopConnector, can we have this be ConfigurationClass? Or LinkConfiguration/FromJobConfiguration/ToJobConfiguration? Or ConfigurationClass(type=From/To/Link)?
LGTM other than this.
- Abraham Elmahrek
On Oct. 2, 2014, 8:09 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26145/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 8:09 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1498
> https://issues.apache.org/jira/browse/SQOOP-1498
>
>
> Repository: sqoop-SQOOP-1367
>
>
> Description
> -------
>
> Sqoop2 Repository Object refactoring
>
> - see JIRA for the details on the changes to the model objects MConnector, MJob, MLink, M*Config
> - rename forms to configs
> - renames to the db repository to accomodate the renames in models/ fields
> - rename validator to reflect that they actually validate configs
>
>
> Diffs
> -----
>
> client/bin/pom.xml PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/ClientError.class PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/SqoopClient$SubmissionStatus.class PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/SqoopClient.class PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/SubmissionCallback.class PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.class PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.class PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.class PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.class PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/request/ResourceRequest$ServerExceptionFilter.class PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/request/ResourceRequest.class PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.class PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.class PRE-CREATION
> client/bin/src/main/java/org/apache/sqoop/client/request/VersionResourceRequest.class PRE-CREATION
> client/bin/src/main/resources/log4j.properties PRE-CREATION
> client/bin/src/test/java/org/apache/sqoop/client/TestSqoopClient.class PRE-CREATION
> client/bin/src/test/resources/log4j.properties PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java d7e6768
> client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java 2855de6
> client/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.java 7b2ddc2
> client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java fd858ec
> client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java 2b784c8
> client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java 54ea3d2
> common/.gitignore PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d726a14
> common/src/main/java/org/apache/sqoop/json/DriverConfigBean.java a2cc8b8
> common/src/main/java/org/apache/sqoop/json/JobBean.java a3e6071
> common/src/main/java/org/apache/sqoop/json/JobValidationBean.java 34c0a4b
> common/src/main/java/org/apache/sqoop/json/LinkBean.java 8981ea7
> common/src/main/java/org/apache/sqoop/json/LinkValidationBean.java a6a6b65
> common/src/main/java/org/apache/sqoop/json/ThrowableBean.java fc63ed4
> common/src/main/java/org/apache/sqoop/json/ValidationResultBean.java 89bc8db
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 77f6191
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java 20ee5f3
> common/src/main/java/org/apache/sqoop/model/Config.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/ConfigClass.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/ConfigurationClass.java 73374d8
> common/src/main/java/org/apache/sqoop/model/ConfigurationGroupClass.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/Form.java 4321582
> common/src/main/java/org/apache/sqoop/model/FormClass.java 6048d03
> common/src/main/java/org/apache/sqoop/model/FormUtils.java ae025ab
> common/src/main/java/org/apache/sqoop/model/MConfig.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MConfigList.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MConfigType.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MConnectionForms.java 457ccdb
> common/src/main/java/org/apache/sqoop/model/MConnector.java 7999b08
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 62eb197
> common/src/main/java/org/apache/sqoop/model/MForm.java ff94660
> common/src/main/java/org/apache/sqoop/model/MFormList.java 9130ada
> common/src/main/java/org/apache/sqoop/model/MFormType.java 2f403df
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MJob.java c9b45a5
> common/src/main/java/org/apache/sqoop/model/MJobForms.java 08b9a78
> common/src/main/java/org/apache/sqoop/model/MLink.java 6a8c424
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MToConfig.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/ModelError.java 470b61c
> common/src/main/java/org/apache/sqoop/validation/ConfigValidationError.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/validation/ConfigValidationResult.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/validation/ConfigValidationRunner.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/validation/Validation.java fce6e88
> common/src/main/java/org/apache/sqoop/validation/ValidationError.java 264d6e3
> common/src/main/java/org/apache/sqoop/validation/ValidationResult.java ae8f1d1
> common/src/main/java/org/apache/sqoop/validation/ValidationRunner.java f36faf2
> common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java fe75ee0
> common/src/test/java/org/apache/sqoop/json/TestDriverConfigBean.java fcce7b5
> common/src/test/java/org/apache/sqoop/json/TestJobBean.java 78a3420
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 9ca6b64
> common/src/test/java/org/apache/sqoop/json/TestUtil.java 9875219
> common/src/test/java/org/apache/sqoop/json/TestValidationBean.java f5f3389
> common/src/test/java/org/apache/sqoop/json/TestValidationResultBean.java 5c094fb
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/util/TestFormSerialization.java c4223ec
> common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/model/TestFormUtils.java 18c9692
> common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java af0f450
> common/src/test/java/org/apache/sqoop/model/TestMConfig.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/model/TestMConnectionForms.java 243fff9
> common/src/test/java/org/apache/sqoop/model/TestMConnector.java d8bc94d
> common/src/test/java/org/apache/sqoop/model/TestMDriverConfig.java 9c23cc3
> common/src/test/java/org/apache/sqoop/model/TestMForm.java 536b650
> common/src/test/java/org/apache/sqoop/model/TestMFormList.java b8d3d37
> common/src/test/java/org/apache/sqoop/model/TestMJob.java 8f2943e
> common/src/test/java/org/apache/sqoop/model/TestMJobConfig.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/model/TestMJobForms.java e59b282
> common/src/test/java/org/apache/sqoop/model/TestMLink.java 77fa2a9
> common/src/test/java/org/apache/sqoop/model/TestMLinkConfig.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/validation/TestValidation.java 85e9e1c
> common/src/test/java/org/apache/sqoop/validation/TestValidationRunner.java 647abe0
> connector/connector-generic-jdbc/.gitignore PRE-CREATION
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java b4b6966
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java 8deddb0
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java ad1ee5c
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java 8b23144
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfiguration.java b036421
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfig.java 7b76eeb
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfiguration.java 7d614f7
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfig.java a42a6ec
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfiguration.java ad68681
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java 1022370
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java a87ce7a
> connector/connector-hdfs/.gitignore PRE-CREATION
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java 47b186c
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java cd5350e
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsValidator.java dfa3659
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 2c98051
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfiguration.java f861237
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java b689854
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfiguration.java 4970821
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java b1308db
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfiguration.java bba249c
> connector/connector-sdk/.gitignore PRE-CREATION
> core/bin/pom.xml PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/audit/AuditLogger.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/audit/AuditLoggerConstants.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/audit/AuditLoggerError.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/audit/FileAuditLogger.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/connector/ConnectorError.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/connector/ConnectorHandler.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/connector/ConnectorManager.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/connector/ConnectorManagerUtils.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/core/ConfigurationConstants.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/core/ConfigurationListener.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/core/ConfigurationProvider.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/core/CoreError.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/core/PropertiesConfigurationProvider$ConfigFilePoller.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/core/PropertiesConfigurationProvider.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/core/Reconfigurable.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/core/SqoopConfiguration$CoreConfigurationListener.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/core/SqoopConfiguration.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/core/SqoopServer.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/Driver.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/DriverConstants.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/DriverError.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/DriverValidator.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/ExecutionEngine.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/JobManager$PurgeThread.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/JobManager$UpdateThread.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/JobManager.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/JobRequest.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/SubmissionEngine.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/configuration/LinkConfiguration.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingForm.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/JdbcRepository$DoWithConnection.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/JdbcRepository.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/JdbcRepositoryContext.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/JdbcRepositoryTransaction.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/JdbcRepositoryTransactionFactory.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/JdbcTransactionIsolation.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/RepoConfigurationConstants.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/Repository.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/RepositoryError.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/RepositoryManager.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/RepositoryProvider.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/repository/RepositoryTransaction.class PRE-CREATION
> core/bin/src/main/java/org/apache/sqoop/request/HttpEventContext.class PRE-CREATION
> core/bin/src/main/resources/driver-config.properties PRE-CREATION
> core/bin/src/test/java/org/apache/sqoop/core/MockInvalidConfigurationProvider.class PRE-CREATION
> core/bin/src/test/java/org/apache/sqoop/core/TestSqoopConfiguration.class PRE-CREATION
> core/bin/src/test/java/org/apache/sqoop/core/TestUtils.class PRE-CREATION
> core/bin/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.class PRE-CREATION
> core/bin/src/test/java/org/apache/sqoop/driver/TestJobManager.class PRE-CREATION
> core/bin/src/test/java/org/apache/sqoop/driver/TestJobRequest.class PRE-CREATION
> core/bin/src/test/java/org/apache/sqoop/repository/TestJdbcRepository$EmptyConfigurationClass.class PRE-CREATION
> core/bin/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.class PRE-CREATION
> core/bin/src/test/java/org/apache/sqoop/repository/TestRepositoryManager.class PRE-CREATION
> core/bin/src/test/resources/log4j.properties PRE-CREATION
> core/bin/src/test/resources/test_config.properties PRE-CREATION
> core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java dbfdc03
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java c87df84
> core/src/main/java/org/apache/sqoop/driver/Driver.java 5297bde
> core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 8d6eb78
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/driver/DriverValidator.java 9cc51dd
> core/src/main/java/org/apache/sqoop/driver/JobManager.java e91c436
> core/src/main/java/org/apache/sqoop/driver/JobRequest.java 63e1e49
> core/src/main/java/org/apache/sqoop/driver/configuration/DriverConfiguration.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.java 908a4eb
> core/src/main/java/org/apache/sqoop/driver/configuration/LinkConfiguration.java 3202844
> core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingConfig.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingForm.java e73007e
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3466116
> core/src/main/java/org/apache/sqoop/repository/Repository.java ea1608a
> core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java ae7be82
> core/src/main/resources/driver-config.properties 9ec5d9e
> core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java 9c39d23
> core/src/test/java/org/apache/sqoop/driver/TestJobManager.java aa3af89
> core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 19b0023
> docs/.gitignore PRE-CREATION
> execution/mapreduce/bin/pom.xml PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/execution/mapreduce/MRJobRequest.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/JobConstants.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/io/Data.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/io/FieldTypes.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/io/SqoopWritable.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/ProgressRunnable.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat$DestroyerFileOutputCommitter.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat$SqoopRecordReader.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopMapper$SqoopMapDataWriter.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat$DestroyerOutputCommitter.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor$ConsumerThread.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor$SqoopOutputFormatDataReader.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor$SqoopRecordWriter.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.class PRE-CREATION
> execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.class PRE-CREATION
> execution/mapreduce/bin/src/main/resources/META-INF/log4j.properties PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/JobUtils.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyExtractor.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyFromDestroyer.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyLoader.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyOutputFormat$DummyOutputCommitter.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyOutputFormat$DummyRecordWriter.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyOutputFormat.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyPartition.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyPartitioner.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyToDestroyer.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/io/TestData.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils$Config.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils$F.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor$GoodContinuousLoader.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor$GoodLoader.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor$ThrowingContinuousLoader.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor$ThrowingLoader.class PRE-CREATION
> execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.class PRE-CREATION
> execution/mapreduce/bin/src/test/resources/log4j.properties PRE-CREATION
> execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 83c670c
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java b533837
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java aecde40
> execution/mapreduce/src/test/java/org/apache/sqoop/job/JobUtils.java b5435ff
> execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 5662120
> execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 1447e00
> repository/repository-derby/bin/pom.xml PRE-CREATION
> repository/repository-derby/bin/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.class PRE-CREATION
> repository/repository-derby/bin/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.class PRE-CREATION
> repository/repository-derby/bin/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.class PRE-CREATION
> repository/repository-derby/bin/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.class PRE-CREATION
> repository/repository-derby/bin/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.class PRE-CREATION
> repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.class PRE-CREATION
> repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.class PRE-CREATION
> repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/TestDriverConfigHandling.class PRE-CREATION
> repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.class PRE-CREATION
> repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/TestInternals$TestDerbyRepositoryHandler.class PRE-CREATION
> repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/TestInternals.class PRE-CREATION
> repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.class PRE-CREATION
> repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.class PRE-CREATION
> repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.class PRE-CREATION
> repository/repository-derby/bin/src/test/resources/log4j.properties PRE-CREATION
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 61dc3b4
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 5dd7970
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 58eed2d
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java ad42901
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 4b95687
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java 15306c2
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverConfigHandling.java 9b18bd3
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java d744693
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java 47350ea
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 8dd1ce2
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java cf0944d
> server/bin/pom.xml PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/handler/JobRequestHandler.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/server/RequestContext$Method.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/server/RequestContext.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/server/RequestHandler.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/server/ServerInitializer.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/server/SqoopProtocolServlet.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/server/VersionServlet.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/server/common/ServerError.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/server/v1/JobServlet.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/server/v1/LinkServlet.class PRE-CREATION
> server/bin/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.class PRE-CREATION
> server/bin/src/main/webapp/WEB-INF/web.xml PRE-CREATION
> server/bin/src/main/webapp/index.html PRE-CREATION
> server/bin/src/test/resources/log4j.properties PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java d1b6b9a
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java c0d363e
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java b61d3f5
> server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 23fc9f1
> shell/bin/pom.xml PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/CloneCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/CloneJobFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/CloneLinkFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/CreateCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/CreateJobFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/CreateLinkFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/DeleteCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/DeleteJobFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/DeleteLinkFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/DisableCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/DisableJobFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/DisableLinkFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/EnableCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/EnableJobFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/EnableLinkFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/HelpCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/SetCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/SetOptionFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/SetServerFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/ShellEnvironment.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/ShowCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/ShowDriverConfigFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/ShowJobFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/ShowOptionFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/ShowServerFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/ShowSubmissionFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/ShowVersionFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/SqoopCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/SqoopFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/SqoopShell.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/StartCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/StartJobFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/StatusCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/StatusJobFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/StopCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/StopJobFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/UpdateCommand.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/core/Constants.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/core/ShellError.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/utils/DynamicFormOptions.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/utils/FormDisplayer.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/utils/FormFiller.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/utils/FormOptions.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/utils/JobDynamicFormOptions.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicFormOptions.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/utils/SubmissionDisplayer.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/utils/TableDisplayer.class PRE-CREATION
> shell/bin/src/main/java/org/apache/sqoop/shell/utils/ThrowableDisplayer.class PRE-CREATION
> shell/bin/src/main/resources/log4j.properties PRE-CREATION
> shell/bin/src/main/resources/shell-resource.properties PRE-CREATION
> shell/bin/src/test/resources/log4j.properties PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java 97d8e6f
> shell/src/main/java/org/apache/sqoop/shell/CloneLinkFunction.java d9babe0
> shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java ccfed31
> shell/src/main/java/org/apache/sqoop/shell/CreateLinkFunction.java 33d60c8
> shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java 2ba75b4
> shell/src/main/java/org/apache/sqoop/shell/ShowDriverConfigFunction.java e6e1004
> shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java e3f1f47
> shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java f500b9e
> shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java 5d69c2a
> shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java 96d1fd8
> shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 30bb63e
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 4d3838c
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigOptions.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/DynamicConfigOptions.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/DynamicFormOptions.java cc63610
> shell/src/main/java/org/apache/sqoop/shell/utils/FormDisplayer.java dcbccef
> shell/src/main/java/org/apache/sqoop/shell/utils/FormFiller.java a0a5dc2
> shell/src/main/java/org/apache/sqoop/shell/utils/FormOptions.java efd002e
> shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicConfigOptions.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicFormOptions.java 87c0776
> shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicConfigOptions.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicFormOptions.java 2952be2
> spi/bin/pom.xml PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/job/Constants.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/job/etl/Destroyer.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/job/etl/Extractor.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/job/etl/From.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/job/etl/Initializer.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/job/etl/Loader.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/job/etl/Partition.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/job/etl/Partitioner.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/job/etl/To.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/job/etl/Transferable.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/validation/Validator$EmptyClass.class PRE-CREATION
> spi/bin/src/main/java/org/apache/sqoop/validation/Validator.class PRE-CREATION
> spi/bin/src/test/resources/log4j.properties PRE-CREATION
> spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java e00b404
> spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 7b78ba0
> spi/src/main/java/org/apache/sqoop/validation/Validator.java 894f412
> submission/mapreduce/bin/pom.xml PRE-CREATION
> submission/mapreduce/bin/src/main/java/org/apache/sqoop/submission/mapreduce/Constants.class PRE-CREATION
> submission/mapreduce/bin/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.class PRE-CREATION
> submission/mapreduce/bin/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionError.class PRE-CREATION
> submission/mapreduce/bin/src/test/resources/log4j.properties PRE-CREATION
> submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 25255ae
> test/bin/pom.xml PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/asserts/HdfsAsserts.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/asserts/ProviderAsserts.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/data/Cities.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/data/DataSet.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/data/UbuntuReleases.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/db/DatabaseProvider.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/db/DatabaseProviderFactory.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/db/DerbyProvider.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/db/MySQLProvider.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/db/NetezzaProvider.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/db/OracleProvider.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/db/PostgreSQLProvider.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/db/SqlServerProvider.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/db/TeradataProvider.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/hadoop/HadoopLocalRunner.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/hadoop/HadoopMiniClusterRunner.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/hadoop/HadoopRunner.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/hadoop/HadoopRunnerFactory.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/minicluster/InProcessSqoopMiniCluster.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/utils/HdfsUtils.class PRE-CREATION
> test/bin/src/main/java/org/apache/sqoop/test/utils/ParametrizedUtils.class PRE-CREATION
> test/bin/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.class PRE-CREATION
> test/bin/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.class PRE-CREATION
> test/bin/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.class PRE-CREATION
> test/bin/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.class PRE-CREATION
> test/bin/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.class PRE-CREATION
> test/bin/src/test/java/org/apache/sqoop/integration/server/VersionTest.class PRE-CREATION
> test/bin/src/test/resources/log4j.properties PRE-CREATION
> test/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.java 9ecc9da
> test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 6074d36
> test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 63736ab
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java 5e1abc1
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 2dc0613
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java 729f95e
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java 562a6a6
> test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java 507ac53
> tomcat/bin/pom.xml PRE-CREATION
> tomcat/bin/src/main/java/org/apache/sqoop/tomcat/TomcatToolRunner.class PRE-CREATION
> tools/bin/pom.xml PRE-CREATION
> tools/bin/src/main/java/org/apache/sqoop/tools/ConfiguredTool.class PRE-CREATION
> tools/bin/src/main/java/org/apache/sqoop/tools/Tool.class PRE-CREATION
> tools/bin/src/main/java/org/apache/sqoop/tools/ToolRunner.class PRE-CREATION
> tools/bin/src/main/java/org/apache/sqoop/tools/tool/BuiltinTools.class PRE-CREATION
> tools/bin/src/main/java/org/apache/sqoop/tools/tool/UpgradeTool.class PRE-CREATION
> tools/bin/src/main/java/org/apache/sqoop/tools/tool/VerifyTool.class PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26145/diff/
>
>
> Testing
> -------
>
> mvn test, integration tests
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 26145: SQOOP-1498: Sqoop2 Repository Object
refactoring + renamaing forms to configs
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26145/
-----------------------------------------------------------
(Updated Oct. 2, 2014, 1:09 p.m.)
Review request for Sqoop.
Changes
-------
after rebase and another round of testing
Bugs: SQOOP-1498
https://issues.apache.org/jira/browse/SQOOP-1498
Repository: sqoop-SQOOP-1367
Description
-------
Sqoop2 Repository Object refactoring
- see JIRA for the details on the changes to the model objects MConnector, MJob, MLink, M*Config
- rename forms to configs
- renames to the db repository to accomodate the renames in models/ fields
- rename validator to reflect that they actually validate configs
Diffs (updated)
-----
client/bin/pom.xml PRE-CREATION
client/bin/src/main/java/org/apache/sqoop/client/ClientError.class PRE-CREATION
client/bin/src/main/java/org/apache/sqoop/client/SqoopClient$SubmissionStatus.class PRE-CREATION
client/bin/src/main/java/org/apache/sqoop/client/SqoopClient.class PRE-CREATION
client/bin/src/main/java/org/apache/sqoop/client/SubmissionCallback.class PRE-CREATION
client/bin/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.class PRE-CREATION
client/bin/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.class PRE-CREATION
client/bin/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.class PRE-CREATION
client/bin/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.class PRE-CREATION
client/bin/src/main/java/org/apache/sqoop/client/request/ResourceRequest$ServerExceptionFilter.class PRE-CREATION
client/bin/src/main/java/org/apache/sqoop/client/request/ResourceRequest.class PRE-CREATION
client/bin/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.class PRE-CREATION
client/bin/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.class PRE-CREATION
client/bin/src/main/java/org/apache/sqoop/client/request/VersionResourceRequest.class PRE-CREATION
client/bin/src/main/resources/log4j.properties PRE-CREATION
client/bin/src/test/java/org/apache/sqoop/client/TestSqoopClient.class PRE-CREATION
client/bin/src/test/resources/log4j.properties PRE-CREATION
client/src/main/java/org/apache/sqoop/client/SqoopClient.java d7e6768
client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java 2855de6
client/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.java 7b2ddc2
client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java fd858ec
client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java 2b784c8
client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java 54ea3d2
common/.gitignore PRE-CREATION
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d726a14
common/src/main/java/org/apache/sqoop/json/DriverConfigBean.java a2cc8b8
common/src/main/java/org/apache/sqoop/json/JobBean.java a3e6071
common/src/main/java/org/apache/sqoop/json/JobValidationBean.java 34c0a4b
common/src/main/java/org/apache/sqoop/json/LinkBean.java 8981ea7
common/src/main/java/org/apache/sqoop/json/LinkValidationBean.java a6a6b65
common/src/main/java/org/apache/sqoop/json/ThrowableBean.java fc63ed4
common/src/main/java/org/apache/sqoop/json/ValidationResultBean.java 89bc8db
common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 77f6191
common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java 20ee5f3
common/src/main/java/org/apache/sqoop/model/Config.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigClass.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigUtils.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigurationClass.java 73374d8
common/src/main/java/org/apache/sqoop/model/ConfigurationGroupClass.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/Form.java 4321582
common/src/main/java/org/apache/sqoop/model/FormClass.java 6048d03
common/src/main/java/org/apache/sqoop/model/FormUtils.java ae025ab
common/src/main/java/org/apache/sqoop/model/MConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConfigList.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConfigType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConnectionForms.java 457ccdb
common/src/main/java/org/apache/sqoop/model/MConnector.java 7999b08
common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 62eb197
common/src/main/java/org/apache/sqoop/model/MForm.java ff94660
common/src/main/java/org/apache/sqoop/model/MFormList.java 9130ada
common/src/main/java/org/apache/sqoop/model/MFormType.java 2f403df
common/src/main/java/org/apache/sqoop/model/MFromConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MJob.java c9b45a5
common/src/main/java/org/apache/sqoop/model/MJobForms.java 08b9a78
common/src/main/java/org/apache/sqoop/model/MLink.java 6a8c424
common/src/main/java/org/apache/sqoop/model/MLinkConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MToConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ModelError.java 470b61c
common/src/main/java/org/apache/sqoop/validation/ConfigValidationError.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/ConfigValidationResult.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/ConfigValidationRunner.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/Validation.java fce6e88
common/src/main/java/org/apache/sqoop/validation/ValidationError.java 264d6e3
common/src/main/java/org/apache/sqoop/validation/ValidationResult.java ae8f1d1
common/src/main/java/org/apache/sqoop/validation/ValidationRunner.java f36faf2
common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java fe75ee0
common/src/test/java/org/apache/sqoop/json/TestDriverConfigBean.java fcce7b5
common/src/test/java/org/apache/sqoop/json/TestJobBean.java 78a3420
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 9ca6b64
common/src/test/java/org/apache/sqoop/json/TestUtil.java 9875219
common/src/test/java/org/apache/sqoop/json/TestValidationBean.java f5f3389
common/src/test/java/org/apache/sqoop/json/TestValidationResultBean.java 5c094fb
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/util/TestFormSerialization.java c4223ec
common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestFormUtils.java 18c9692
common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java af0f450
common/src/test/java/org/apache/sqoop/model/TestMConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMConnectionForms.java 243fff9
common/src/test/java/org/apache/sqoop/model/TestMConnector.java d8bc94d
common/src/test/java/org/apache/sqoop/model/TestMDriverConfig.java 9c23cc3
common/src/test/java/org/apache/sqoop/model/TestMForm.java 536b650
common/src/test/java/org/apache/sqoop/model/TestMFormList.java b8d3d37
common/src/test/java/org/apache/sqoop/model/TestMJob.java 8f2943e
common/src/test/java/org/apache/sqoop/model/TestMJobConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMJobForms.java e59b282
common/src/test/java/org/apache/sqoop/model/TestMLink.java 77fa2a9
common/src/test/java/org/apache/sqoop/model/TestMLinkConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/validation/TestValidation.java 85e9e1c
common/src/test/java/org/apache/sqoop/validation/TestValidationRunner.java 647abe0
connector/connector-generic-jdbc/.gitignore PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java b4b6966
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java 8deddb0
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java ad1ee5c
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java 8b23144
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfiguration.java b036421
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfig.java 7b76eeb
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfiguration.java 7d614f7
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfig.java a42a6ec
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfiguration.java ad68681
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java 1022370
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java a87ce7a
connector/connector-hdfs/.gitignore PRE-CREATION
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java 47b186c
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java cd5350e
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsValidator.java dfa3659
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 2c98051
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfiguration.java f861237
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java b689854
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfiguration.java 4970821
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java b1308db
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfiguration.java bba249c
connector/connector-sdk/.gitignore PRE-CREATION
core/bin/pom.xml PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/audit/AuditLogger.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/audit/AuditLoggerConstants.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/audit/AuditLoggerError.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/audit/FileAuditLogger.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/connector/ConnectorError.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/connector/ConnectorHandler.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/connector/ConnectorManager.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/connector/ConnectorManagerUtils.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/core/ConfigurationConstants.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/core/ConfigurationListener.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/core/ConfigurationProvider.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/core/CoreError.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/core/PropertiesConfigurationProvider$ConfigFilePoller.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/core/PropertiesConfigurationProvider.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/core/Reconfigurable.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/core/SqoopConfiguration$CoreConfigurationListener.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/core/SqoopConfiguration.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/core/SqoopServer.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/driver/Driver.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/driver/DriverConstants.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/driver/DriverError.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/driver/DriverValidator.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/driver/ExecutionEngine.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/driver/JobManager$PurgeThread.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/driver/JobManager$UpdateThread.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/driver/JobManager.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/driver/JobRequest.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/driver/SubmissionEngine.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/driver/configuration/LinkConfiguration.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingForm.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/repository/JdbcRepository$DoWithConnection.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/repository/JdbcRepository.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/repository/JdbcRepositoryContext.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/repository/JdbcRepositoryTransaction.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/repository/JdbcRepositoryTransactionFactory.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/repository/JdbcTransactionIsolation.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/repository/RepoConfigurationConstants.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/repository/Repository.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/repository/RepositoryError.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/repository/RepositoryManager.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/repository/RepositoryProvider.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/repository/RepositoryTransaction.class PRE-CREATION
core/bin/src/main/java/org/apache/sqoop/request/HttpEventContext.class PRE-CREATION
core/bin/src/main/resources/driver-config.properties PRE-CREATION
core/bin/src/test/java/org/apache/sqoop/core/MockInvalidConfigurationProvider.class PRE-CREATION
core/bin/src/test/java/org/apache/sqoop/core/TestSqoopConfiguration.class PRE-CREATION
core/bin/src/test/java/org/apache/sqoop/core/TestUtils.class PRE-CREATION
core/bin/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.class PRE-CREATION
core/bin/src/test/java/org/apache/sqoop/driver/TestJobManager.class PRE-CREATION
core/bin/src/test/java/org/apache/sqoop/driver/TestJobRequest.class PRE-CREATION
core/bin/src/test/java/org/apache/sqoop/repository/TestJdbcRepository$EmptyConfigurationClass.class PRE-CREATION
core/bin/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.class PRE-CREATION
core/bin/src/test/java/org/apache/sqoop/repository/TestRepositoryManager.class PRE-CREATION
core/bin/src/test/resources/log4j.properties PRE-CREATION
core/bin/src/test/resources/test_config.properties PRE-CREATION
core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java dbfdc03
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java c87df84
core/src/main/java/org/apache/sqoop/driver/Driver.java 5297bde
core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 8d6eb78
core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/DriverValidator.java 9cc51dd
core/src/main/java/org/apache/sqoop/driver/JobManager.java e91c436
core/src/main/java/org/apache/sqoop/driver/JobRequest.java 63e1e49
core/src/main/java/org/apache/sqoop/driver/configuration/DriverConfiguration.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.java 908a4eb
core/src/main/java/org/apache/sqoop/driver/configuration/LinkConfiguration.java 3202844
core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingConfig.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingForm.java e73007e
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3466116
core/src/main/java/org/apache/sqoop/repository/Repository.java ea1608a
core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java ae7be82
core/src/main/resources/driver-config.properties 9ec5d9e
core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java 9c39d23
core/src/test/java/org/apache/sqoop/driver/TestJobManager.java aa3af89
core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 19b0023
docs/.gitignore PRE-CREATION
execution/mapreduce/bin/pom.xml PRE-CREATION
execution/mapreduce/bin/src/main/java/org/apache/sqoop/execution/mapreduce/MRJobRequest.class PRE-CREATION
execution/mapreduce/bin/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.class PRE-CREATION
execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/JobConstants.class PRE-CREATION
execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.class PRE-CREATION
execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/io/Data.class PRE-CREATION
execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/io/FieldTypes.class PRE-CREATION
execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/io/SqoopWritable.class PRE-CREATION
execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.class PRE-CREATION
execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/ProgressRunnable.class PRE-CREATION
execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.class PRE-CREATION
execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat$DestroyerFileOutputCommitter.class PRE-CREATION
execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.class PRE-CREATION
execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat$SqoopRecordReader.class PRE-CREATION
execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.class PRE-CREATION
execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopMapper$SqoopMapDataWriter.class PRE-CREATION
execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.class PRE-CREATION
execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat$DestroyerOutputCommitter.class PRE-CREATION
execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.class PRE-CREATION
execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor$ConsumerThread.class PRE-CREATION
execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor$SqoopOutputFormatDataReader.class PRE-CREATION
execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor$SqoopRecordWriter.class PRE-CREATION
execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.class PRE-CREATION
execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.class PRE-CREATION
execution/mapreduce/bin/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.class PRE-CREATION
execution/mapreduce/bin/src/main/resources/META-INF/log4j.properties PRE-CREATION
execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/JobUtils.class PRE-CREATION
execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyExtractor.class PRE-CREATION
execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyFromDestroyer.class PRE-CREATION
execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyLoader.class PRE-CREATION
execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyOutputFormat$DummyOutputCommitter.class PRE-CREATION
execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyOutputFormat$DummyRecordWriter.class PRE-CREATION
execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyOutputFormat.class PRE-CREATION
execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyPartition.class PRE-CREATION
execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyPartitioner.class PRE-CREATION
execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce$DummyToDestroyer.class PRE-CREATION
execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/TestMapReduce.class PRE-CREATION
execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.class PRE-CREATION
execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/io/TestData.class PRE-CREATION
execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils$Config.class PRE-CREATION
execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils$F.class PRE-CREATION
execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.class PRE-CREATION
execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor$GoodContinuousLoader.class PRE-CREATION
execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor$GoodLoader.class PRE-CREATION
execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor$ThrowingContinuousLoader.class PRE-CREATION
execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor$ThrowingLoader.class PRE-CREATION
execution/mapreduce/bin/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.class PRE-CREATION
execution/mapreduce/bin/src/test/resources/log4j.properties PRE-CREATION
execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 83c670c
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java b533837
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java aecde40
execution/mapreduce/src/test/java/org/apache/sqoop/job/JobUtils.java b5435ff
execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 5662120
execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 1447e00
repository/repository-derby/bin/pom.xml PRE-CREATION
repository/repository-derby/bin/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.class PRE-CREATION
repository/repository-derby/bin/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.class PRE-CREATION
repository/repository-derby/bin/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.class PRE-CREATION
repository/repository-derby/bin/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.class PRE-CREATION
repository/repository-derby/bin/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.class PRE-CREATION
repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.class PRE-CREATION
repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.class PRE-CREATION
repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/TestDriverConfigHandling.class PRE-CREATION
repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.class PRE-CREATION
repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/TestInternals$TestDerbyRepositoryHandler.class PRE-CREATION
repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/TestInternals.class PRE-CREATION
repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.class PRE-CREATION
repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.class PRE-CREATION
repository/repository-derby/bin/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.class PRE-CREATION
repository/repository-derby/bin/src/test/resources/log4j.properties PRE-CREATION
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 61dc3b4
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 5dd7970
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 58eed2d
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java ad42901
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 4b95687
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java 15306c2
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverConfigHandling.java 9b18bd3
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java d744693
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java 47350ea
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 8dd1ce2
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java cf0944d
server/bin/pom.xml PRE-CREATION
server/bin/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.class PRE-CREATION
server/bin/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.class PRE-CREATION
server/bin/src/main/java/org/apache/sqoop/handler/JobRequestHandler.class PRE-CREATION
server/bin/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.class PRE-CREATION
server/bin/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.class PRE-CREATION
server/bin/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.class PRE-CREATION
server/bin/src/main/java/org/apache/sqoop/server/RequestContext$Method.class PRE-CREATION
server/bin/src/main/java/org/apache/sqoop/server/RequestContext.class PRE-CREATION
server/bin/src/main/java/org/apache/sqoop/server/RequestHandler.class PRE-CREATION
server/bin/src/main/java/org/apache/sqoop/server/ServerInitializer.class PRE-CREATION
server/bin/src/main/java/org/apache/sqoop/server/SqoopProtocolServlet.class PRE-CREATION
server/bin/src/main/java/org/apache/sqoop/server/VersionServlet.class PRE-CREATION
server/bin/src/main/java/org/apache/sqoop/server/common/ServerError.class PRE-CREATION
server/bin/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.class PRE-CREATION
server/bin/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.class PRE-CREATION
server/bin/src/main/java/org/apache/sqoop/server/v1/JobServlet.class PRE-CREATION
server/bin/src/main/java/org/apache/sqoop/server/v1/LinkServlet.class PRE-CREATION
server/bin/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.class PRE-CREATION
server/bin/src/main/webapp/WEB-INF/web.xml PRE-CREATION
server/bin/src/main/webapp/index.html PRE-CREATION
server/bin/src/test/resources/log4j.properties PRE-CREATION
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java d1b6b9a
server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java c0d363e
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java b61d3f5
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 23fc9f1
shell/bin/pom.xml PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/CloneCommand.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/CloneJobFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/CloneLinkFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/CreateCommand.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/CreateJobFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/CreateLinkFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/DeleteCommand.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/DeleteJobFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/DeleteLinkFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/DisableCommand.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/DisableJobFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/DisableLinkFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/EnableCommand.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/EnableJobFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/EnableLinkFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/HelpCommand.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/SetCommand.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/SetOptionFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/SetServerFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/ShellEnvironment.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/ShowCommand.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/ShowDriverConfigFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/ShowJobFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/ShowOptionFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/ShowServerFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/ShowSubmissionFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/ShowVersionFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/SqoopCommand.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/SqoopFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/SqoopShell.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/StartCommand.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/StartJobFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/StatusCommand.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/StatusJobFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/StopCommand.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/StopJobFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/UpdateCommand.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/core/Constants.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/core/ShellError.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/utils/DynamicFormOptions.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/utils/FormDisplayer.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/utils/FormFiller.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/utils/FormOptions.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/utils/JobDynamicFormOptions.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicFormOptions.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/utils/SubmissionDisplayer.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/utils/TableDisplayer.class PRE-CREATION
shell/bin/src/main/java/org/apache/sqoop/shell/utils/ThrowableDisplayer.class PRE-CREATION
shell/bin/src/main/resources/log4j.properties PRE-CREATION
shell/bin/src/main/resources/shell-resource.properties PRE-CREATION
shell/bin/src/test/resources/log4j.properties PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java 97d8e6f
shell/src/main/java/org/apache/sqoop/shell/CloneLinkFunction.java d9babe0
shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java ccfed31
shell/src/main/java/org/apache/sqoop/shell/CreateLinkFunction.java 33d60c8
shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java 2ba75b4
shell/src/main/java/org/apache/sqoop/shell/ShowDriverConfigFunction.java e6e1004
shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java e3f1f47
shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java f500b9e
shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java 5d69c2a
shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java 96d1fd8
shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 30bb63e
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 4d3838c
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/DynamicConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/DynamicFormOptions.java cc63610
shell/src/main/java/org/apache/sqoop/shell/utils/FormDisplayer.java dcbccef
shell/src/main/java/org/apache/sqoop/shell/utils/FormFiller.java a0a5dc2
shell/src/main/java/org/apache/sqoop/shell/utils/FormOptions.java efd002e
shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicFormOptions.java 87c0776
shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicFormOptions.java 2952be2
spi/bin/pom.xml PRE-CREATION
spi/bin/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.class PRE-CREATION
spi/bin/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.class PRE-CREATION
spi/bin/src/main/java/org/apache/sqoop/job/Constants.class PRE-CREATION
spi/bin/src/main/java/org/apache/sqoop/job/etl/Destroyer.class PRE-CREATION
spi/bin/src/main/java/org/apache/sqoop/job/etl/Extractor.class PRE-CREATION
spi/bin/src/main/java/org/apache/sqoop/job/etl/From.class PRE-CREATION
spi/bin/src/main/java/org/apache/sqoop/job/etl/Initializer.class PRE-CREATION
spi/bin/src/main/java/org/apache/sqoop/job/etl/Loader.class PRE-CREATION
spi/bin/src/main/java/org/apache/sqoop/job/etl/Partition.class PRE-CREATION
spi/bin/src/main/java/org/apache/sqoop/job/etl/Partitioner.class PRE-CREATION
spi/bin/src/main/java/org/apache/sqoop/job/etl/To.class PRE-CREATION
spi/bin/src/main/java/org/apache/sqoop/job/etl/Transferable.class PRE-CREATION
spi/bin/src/main/java/org/apache/sqoop/validation/Validator$EmptyClass.class PRE-CREATION
spi/bin/src/main/java/org/apache/sqoop/validation/Validator.class PRE-CREATION
spi/bin/src/test/resources/log4j.properties PRE-CREATION
spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java e00b404
spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 7b78ba0
spi/src/main/java/org/apache/sqoop/validation/Validator.java 894f412
submission/mapreduce/bin/pom.xml PRE-CREATION
submission/mapreduce/bin/src/main/java/org/apache/sqoop/submission/mapreduce/Constants.class PRE-CREATION
submission/mapreduce/bin/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.class PRE-CREATION
submission/mapreduce/bin/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionError.class PRE-CREATION
submission/mapreduce/bin/src/test/resources/log4j.properties PRE-CREATION
submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 25255ae
test/bin/pom.xml PRE-CREATION
test/bin/src/main/java/org/apache/sqoop/test/asserts/HdfsAsserts.class PRE-CREATION
test/bin/src/main/java/org/apache/sqoop/test/asserts/ProviderAsserts.class PRE-CREATION
test/bin/src/main/java/org/apache/sqoop/test/data/Cities.class PRE-CREATION
test/bin/src/main/java/org/apache/sqoop/test/data/DataSet.class PRE-CREATION
test/bin/src/main/java/org/apache/sqoop/test/data/UbuntuReleases.class PRE-CREATION
test/bin/src/main/java/org/apache/sqoop/test/db/DatabaseProvider.class PRE-CREATION
test/bin/src/main/java/org/apache/sqoop/test/db/DatabaseProviderFactory.class PRE-CREATION
test/bin/src/main/java/org/apache/sqoop/test/db/DerbyProvider.class PRE-CREATION
test/bin/src/main/java/org/apache/sqoop/test/db/MySQLProvider.class PRE-CREATION
test/bin/src/main/java/org/apache/sqoop/test/db/NetezzaProvider.class PRE-CREATION
test/bin/src/main/java/org/apache/sqoop/test/db/OracleProvider.class PRE-CREATION
test/bin/src/main/java/org/apache/sqoop/test/db/PostgreSQLProvider.class PRE-CREATION
test/bin/src/main/java/org/apache/sqoop/test/db/SqlServerProvider.class PRE-CREATION
test/bin/src/main/java/org/apache/sqoop/test/db/TeradataProvider.class PRE-CREATION
test/bin/src/main/java/org/apache/sqoop/test/hadoop/HadoopLocalRunner.class PRE-CREATION
test/bin/src/main/java/org/apache/sqoop/test/hadoop/HadoopMiniClusterRunner.class PRE-CREATION
test/bin/src/main/java/org/apache/sqoop/test/hadoop/HadoopRunner.class PRE-CREATION
test/bin/src/main/java/org/apache/sqoop/test/hadoop/HadoopRunnerFactory.class PRE-CREATION
test/bin/src/main/java/org/apache/sqoop/test/minicluster/InProcessSqoopMiniCluster.class PRE-CREATION
test/bin/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.class PRE-CREATION
test/bin/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.class PRE-CREATION
test/bin/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.class PRE-CREATION
test/bin/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.class PRE-CREATION
test/bin/src/main/java/org/apache/sqoop/test/utils/HdfsUtils.class PRE-CREATION
test/bin/src/main/java/org/apache/sqoop/test/utils/ParametrizedUtils.class PRE-CREATION
test/bin/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.class PRE-CREATION
test/bin/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.class PRE-CREATION
test/bin/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.class PRE-CREATION
test/bin/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.class PRE-CREATION
test/bin/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.class PRE-CREATION
test/bin/src/test/java/org/apache/sqoop/integration/server/VersionTest.class PRE-CREATION
test/bin/src/test/resources/log4j.properties PRE-CREATION
test/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.java 9ecc9da
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 6074d36
test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 63736ab
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java 5e1abc1
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 2dc0613
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java 729f95e
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java 562a6a6
test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java 507ac53
tomcat/bin/pom.xml PRE-CREATION
tomcat/bin/src/main/java/org/apache/sqoop/tomcat/TomcatToolRunner.class PRE-CREATION
tools/bin/pom.xml PRE-CREATION
tools/bin/src/main/java/org/apache/sqoop/tools/ConfiguredTool.class PRE-CREATION
tools/bin/src/main/java/org/apache/sqoop/tools/Tool.class PRE-CREATION
tools/bin/src/main/java/org/apache/sqoop/tools/ToolRunner.class PRE-CREATION
tools/bin/src/main/java/org/apache/sqoop/tools/tool/BuiltinTools.class PRE-CREATION
tools/bin/src/main/java/org/apache/sqoop/tools/tool/UpgradeTool.class PRE-CREATION
tools/bin/src/main/java/org/apache/sqoop/tools/tool/VerifyTool.class PRE-CREATION
Diff: https://reviews.apache.org/r/26145/diff/
Testing
-------
mvn test, integration tests
Thanks,
Veena Basavaraj
Re: Review Request 26145: SQOOP-1498: Sqoop2 Repository Object
refactoring + renamaing forms to configs
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26145/
-----------------------------------------------------------
(Updated Oct. 2, 2014, 8:31 a.m.)
Review request for Sqoop.
Changes
-------
address spacing issues
Bugs: SQOOP-1498
https://issues.apache.org/jira/browse/SQOOP-1498
Repository: sqoop-SQOOP-1367
Description
-------
Sqoop2 Repository Object refactoring
- see JIRA for the details on the changes to the model objects MConnector, MJob, MLink, M*Config
- rename forms to configs
- renames to the db repository to accomodate the renames in models/ fields
- rename validator to reflect that they actually validate configs
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java d7e6768
client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java 2855de6
client/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.java 7b2ddc2
client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java fd858ec
client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java 2b784c8
client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java 54ea3d2
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java 465dd69
common/src/main/java/org/apache/sqoop/json/DriverConfigBean.java a2cc8b8
common/src/main/java/org/apache/sqoop/json/JobBean.java a3e6071
common/src/main/java/org/apache/sqoop/json/JobValidationBean.java 34c0a4b
common/src/main/java/org/apache/sqoop/json/LinkBean.java 8981ea7
common/src/main/java/org/apache/sqoop/json/LinkValidationBean.java a6a6b65
common/src/main/java/org/apache/sqoop/json/ThrowableBean.java fc63ed4
common/src/main/java/org/apache/sqoop/json/ValidationResultBean.java 89bc8db
common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 77f6191
common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java 20ee5f3
common/src/main/java/org/apache/sqoop/model/Config.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigClass.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigUtils.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigurationClass.java 73374d8
common/src/main/java/org/apache/sqoop/model/ConfigurationGroupClass.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/Form.java 4321582
common/src/main/java/org/apache/sqoop/model/FormClass.java 6048d03
common/src/main/java/org/apache/sqoop/model/FormUtils.java ae025ab
common/src/main/java/org/apache/sqoop/model/MConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConfigList.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConfigType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConnectionForms.java 457ccdb
common/src/main/java/org/apache/sqoop/model/MConnector.java 3dc1014
common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 62eb197
common/src/main/java/org/apache/sqoop/model/MForm.java ff94660
common/src/main/java/org/apache/sqoop/model/MFormList.java 9130ada
common/src/main/java/org/apache/sqoop/model/MFormType.java 2f403df
common/src/main/java/org/apache/sqoop/model/MFromConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MJob.java c9b45a5
common/src/main/java/org/apache/sqoop/model/MJobForms.java 08b9a78
common/src/main/java/org/apache/sqoop/model/MLink.java 6a8c424
common/src/main/java/org/apache/sqoop/model/MLinkConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MToConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ModelError.java 470b61c
common/src/main/java/org/apache/sqoop/validation/ConfigValidationError.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/ConfigValidationResult.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/ConfigValidationRunner.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/Validation.java fce6e88
common/src/main/java/org/apache/sqoop/validation/ValidationError.java 264d6e3
common/src/main/java/org/apache/sqoop/validation/ValidationResult.java ae8f1d1
common/src/main/java/org/apache/sqoop/validation/ValidationRunner.java f36faf2
common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java e078474
common/src/test/java/org/apache/sqoop/json/TestDriverConfigBean.java 4309f10
common/src/test/java/org/apache/sqoop/json/TestJobBean.java c6461bf
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 8235275
common/src/test/java/org/apache/sqoop/json/TestUtil.java eaf9122
common/src/test/java/org/apache/sqoop/json/TestValidationBean.java f5f3389
common/src/test/java/org/apache/sqoop/json/TestValidationResultBean.java d9c2043
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/util/TestFormSerialization.java c4223ec
common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestFormUtils.java ba85d11
common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java d56e165
common/src/test/java/org/apache/sqoop/model/TestMConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMConnectionForms.java e2d2717
common/src/test/java/org/apache/sqoop/model/TestMConnector.java 3fde47b
common/src/test/java/org/apache/sqoop/model/TestMDriverConfig.java 9c23cc3
common/src/test/java/org/apache/sqoop/model/TestMForm.java 0bd55d9
common/src/test/java/org/apache/sqoop/model/TestMFormList.java c7ee682
common/src/test/java/org/apache/sqoop/model/TestMJob.java 96c316a
common/src/test/java/org/apache/sqoop/model/TestMJobConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMJobForms.java 81a8614
common/src/test/java/org/apache/sqoop/model/TestMLink.java 1be37a1
common/src/test/java/org/apache/sqoop/model/TestMLinkConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/validation/TestValidation.java bf0ade5
common/src/test/java/org/apache/sqoop/validation/TestValidationRunner.java 647abe0
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java b4b6966
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java 8deddb0
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java ad1ee5c
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java 8b23144
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfiguration.java b036421
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfig.java 7b76eeb
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfiguration.java 7d614f7
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfig.java a42a6ec
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfiguration.java ad68681
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java e10a5b4
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java 00c2aab
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java 47b186c
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 70833a0
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsValidator.java dfa3659
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 2c98051
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfiguration.java f861237
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java b689854
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfiguration.java 4970821
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java b1308db
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfiguration.java bba249c
core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java dbfdc03
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java c87df84
core/src/main/java/org/apache/sqoop/driver/Driver.java 5297bde
core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 8d6eb78
core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/DriverValidator.java 9cc51dd
core/src/main/java/org/apache/sqoop/driver/JobManager.java 277c6be
core/src/main/java/org/apache/sqoop/driver/JobRequest.java 63e1e49
core/src/main/java/org/apache/sqoop/driver/configuration/DriverConfiguration.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.java 908a4eb
core/src/main/java/org/apache/sqoop/driver/configuration/LinkConfiguration.java 3202844
core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingConfig.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingForm.java e73007e
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3466116
core/src/main/java/org/apache/sqoop/repository/Repository.java ea1608a
core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java ae7be82
core/src/main/resources/driver-config.properties 9ec5d9e
core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java 9c39d23
core/src/test/java/org/apache/sqoop/driver/TestJobManager.java 80f45e5
core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 796b021
execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 83c670c
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 2ed06a8
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java aecde40
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java eea0623
execution/mapreduce/src/test/java/org/apache/sqoop/job/JobUtils.java 09e5ec5
execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 869c727
execution/mapreduce/src/test/java/org/apache/sqoop/job/io/TestData.java 91df426
execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 1447e00
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 61dc3b4
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 5dd7970
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 58eed2d
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java ad42901
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 998f5b7
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java 8a5823d
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverConfigHandling.java 567dda6
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java c4a5829
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java f22c351
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 7378eda
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 38a995f
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java d1b6b9a
server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java c0d363e
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java b61d3f5
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 23fc9f1
shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java 97d8e6f
shell/src/main/java/org/apache/sqoop/shell/CloneLinkFunction.java d9babe0
shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java ccfed31
shell/src/main/java/org/apache/sqoop/shell/CreateLinkFunction.java 33d60c8
shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java 2ba75b4
shell/src/main/java/org/apache/sqoop/shell/ShowDriverConfigFunction.java e6e1004
shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java e3f1f47
shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java f500b9e
shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java 5d69c2a
shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java 96d1fd8
shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 30bb63e
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 4d3838c
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/DynamicConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/DynamicFormOptions.java cc63610
shell/src/main/java/org/apache/sqoop/shell/utils/FormDisplayer.java dcbccef
shell/src/main/java/org/apache/sqoop/shell/utils/FormFiller.java a0a5dc2
shell/src/main/java/org/apache/sqoop/shell/utils/FormOptions.java efd002e
shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicFormOptions.java 87c0776
shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicFormOptions.java 2952be2
spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java e00b404
spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 7b78ba0
spi/src/main/java/org/apache/sqoop/validation/Validator.java 894f412
submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java fe92ac4
test/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.java 9ecc9da
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 6074d36
test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 63736ab
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java 5e1abc1
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 2dc0613
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java 729f95e
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java 562a6a6
test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java 507ac53
Diff: https://reviews.apache.org/r/26145/diff/
Testing
-------
mvn test, integration tests
Thanks,
Veena Basavaraj
Re: Review Request 26145: SQOOP-1498: Sqoop2 Repository Object
refactoring + renamaing forms to configs
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26145/
-----------------------------------------------------------
(Updated Oct. 2, 2014, 8:24 a.m.)
Review request for Sqoop.
Bugs: SQOOP-1498
https://issues.apache.org/jira/browse/SQOOP-1498
Repository: sqoop-SQOOP-1367
Description (updated)
-------
Sqoop2 Repository Object refactoring
- see JIRA for the details on the changes to the model objects MConnector, MJob, MLink, M*Config
- rename forms to configs
- renames to the db repository to accomodate the renames in models/ fields
- rename validator to reflect that they actually validate configs
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java d7e6768
client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java 2855de6
client/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.java 7b2ddc2
client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java fd858ec
client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java 2b784c8
client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java 54ea3d2
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java 465dd69
common/src/main/java/org/apache/sqoop/json/DriverConfigBean.java a2cc8b8
common/src/main/java/org/apache/sqoop/json/JobBean.java a3e6071
common/src/main/java/org/apache/sqoop/json/JobValidationBean.java 34c0a4b
common/src/main/java/org/apache/sqoop/json/LinkBean.java 8981ea7
common/src/main/java/org/apache/sqoop/json/LinkValidationBean.java a6a6b65
common/src/main/java/org/apache/sqoop/json/ThrowableBean.java fc63ed4
common/src/main/java/org/apache/sqoop/json/ValidationResultBean.java 89bc8db
common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 77f6191
common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java 20ee5f3
common/src/main/java/org/apache/sqoop/model/Config.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigClass.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigUtils.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigurationClass.java 73374d8
common/src/main/java/org/apache/sqoop/model/ConfigurationGroupClass.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/Form.java 4321582
common/src/main/java/org/apache/sqoop/model/FormClass.java 6048d03
common/src/main/java/org/apache/sqoop/model/FormUtils.java ae025ab
common/src/main/java/org/apache/sqoop/model/MConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConfigList.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConfigType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConnectionForms.java 457ccdb
common/src/main/java/org/apache/sqoop/model/MConnector.java 3dc1014
common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 62eb197
common/src/main/java/org/apache/sqoop/model/MForm.java ff94660
common/src/main/java/org/apache/sqoop/model/MFormList.java 9130ada
common/src/main/java/org/apache/sqoop/model/MFormType.java 2f403df
common/src/main/java/org/apache/sqoop/model/MFromConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MJob.java c9b45a5
common/src/main/java/org/apache/sqoop/model/MJobForms.java 08b9a78
common/src/main/java/org/apache/sqoop/model/MLink.java 6a8c424
common/src/main/java/org/apache/sqoop/model/MLinkConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MToConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ModelError.java 470b61c
common/src/main/java/org/apache/sqoop/validation/ConfigValidationError.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/ConfigValidationResult.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/ConfigValidationRunner.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/Validation.java fce6e88
common/src/main/java/org/apache/sqoop/validation/ValidationError.java 264d6e3
common/src/main/java/org/apache/sqoop/validation/ValidationResult.java ae8f1d1
common/src/main/java/org/apache/sqoop/validation/ValidationRunner.java f36faf2
common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java e078474
common/src/test/java/org/apache/sqoop/json/TestDriverConfigBean.java 4309f10
common/src/test/java/org/apache/sqoop/json/TestJobBean.java c6461bf
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 8235275
common/src/test/java/org/apache/sqoop/json/TestUtil.java eaf9122
common/src/test/java/org/apache/sqoop/json/TestValidationBean.java f5f3389
common/src/test/java/org/apache/sqoop/json/TestValidationResultBean.java d9c2043
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/util/TestFormSerialization.java c4223ec
common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestFormUtils.java ba85d11
common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java d56e165
common/src/test/java/org/apache/sqoop/model/TestMConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMConnectionForms.java e2d2717
common/src/test/java/org/apache/sqoop/model/TestMConnector.java 3fde47b
common/src/test/java/org/apache/sqoop/model/TestMDriverConfig.java 9c23cc3
common/src/test/java/org/apache/sqoop/model/TestMForm.java 0bd55d9
common/src/test/java/org/apache/sqoop/model/TestMFormList.java c7ee682
common/src/test/java/org/apache/sqoop/model/TestMJob.java 96c316a
common/src/test/java/org/apache/sqoop/model/TestMJobConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMJobForms.java 81a8614
common/src/test/java/org/apache/sqoop/model/TestMLink.java 1be37a1
common/src/test/java/org/apache/sqoop/model/TestMLinkConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/validation/TestValidation.java bf0ade5
common/src/test/java/org/apache/sqoop/validation/TestValidationRunner.java 647abe0
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java b4b6966
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java 8deddb0
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java ad1ee5c
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java 8b23144
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfiguration.java b036421
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfig.java 7b76eeb
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfiguration.java 7d614f7
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfig.java a42a6ec
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfiguration.java ad68681
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java e10a5b4
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java 00c2aab
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java 47b186c
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 70833a0
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsValidator.java dfa3659
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 2c98051
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfiguration.java f861237
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java b689854
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfiguration.java 4970821
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java b1308db
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfiguration.java bba249c
core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java dbfdc03
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java c87df84
core/src/main/java/org/apache/sqoop/driver/Driver.java 5297bde
core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 8d6eb78
core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/DriverValidator.java 9cc51dd
core/src/main/java/org/apache/sqoop/driver/JobManager.java 277c6be
core/src/main/java/org/apache/sqoop/driver/JobRequest.java 63e1e49
core/src/main/java/org/apache/sqoop/driver/configuration/DriverConfiguration.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.java 908a4eb
core/src/main/java/org/apache/sqoop/driver/configuration/LinkConfiguration.java 3202844
core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingConfig.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingForm.java e73007e
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3466116
core/src/main/java/org/apache/sqoop/repository/Repository.java ea1608a
core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java ae7be82
core/src/main/resources/driver-config.properties 9ec5d9e
core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java 9c39d23
core/src/test/java/org/apache/sqoop/driver/TestJobManager.java 80f45e5
core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 796b021
execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 83c670c
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 2ed06a8
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java aecde40
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java eea0623
execution/mapreduce/src/test/java/org/apache/sqoop/job/JobUtils.java 09e5ec5
execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 869c727
execution/mapreduce/src/test/java/org/apache/sqoop/job/io/TestData.java 91df426
execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 1447e00
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 61dc3b4
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 5dd7970
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 58eed2d
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java ad42901
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 998f5b7
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java 8a5823d
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverConfigHandling.java 567dda6
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java c4a5829
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java f22c351
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 7378eda
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 38a995f
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java d1b6b9a
server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java c0d363e
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java b61d3f5
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 23fc9f1
shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java 97d8e6f
shell/src/main/java/org/apache/sqoop/shell/CloneLinkFunction.java d9babe0
shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java ccfed31
shell/src/main/java/org/apache/sqoop/shell/CreateLinkFunction.java 33d60c8
shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java 2ba75b4
shell/src/main/java/org/apache/sqoop/shell/ShowDriverConfigFunction.java e6e1004
shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java e3f1f47
shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java f500b9e
shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java 5d69c2a
shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java 96d1fd8
shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 30bb63e
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 4d3838c
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/DynamicConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/DynamicFormOptions.java cc63610
shell/src/main/java/org/apache/sqoop/shell/utils/FormDisplayer.java dcbccef
shell/src/main/java/org/apache/sqoop/shell/utils/FormFiller.java a0a5dc2
shell/src/main/java/org/apache/sqoop/shell/utils/FormOptions.java efd002e
shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicFormOptions.java 87c0776
shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicFormOptions.java 2952be2
spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java e00b404
spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 7b78ba0
spi/src/main/java/org/apache/sqoop/validation/Validator.java 894f412
submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java fe92ac4
test/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.java 9ecc9da
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 6074d36
test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 63736ab
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java 5e1abc1
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 2dc0613
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java 729f95e
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java 562a6a6
test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java 507ac53
Diff: https://reviews.apache.org/r/26145/diff/
Testing
-------
mvn test, integration tests
Thanks,
Veena Basavaraj
Re: Review Request 26145: SQOOP-1498: Sqoop2 Repository Object
refactoring + renamaing forms to configs
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26145/
-----------------------------------------------------------
(Updated Sept. 30, 2014, 9:13 a.m.)
Review request for Sqoop.
Changes
-------
fixed tests and some more clean up
Bugs: SQOOP-1498
https://issues.apache.org/jira/browse/SQOOP-1498
Repository: sqoop-SQOOP-1367
Description (updated)
-------
Sqoop2 Repository Object refactoring
- see JIRA for the details on the changes to the model objects MConnector, MJob, MLink, M*Config
- rename forms to configs
- renames to the db repository to accomodate the renames in models/ fields
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java d7e6768
client/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.java 7b2ddc2
client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java 54ea3d2
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java 465dd69
common/src/main/java/org/apache/sqoop/json/DriverConfigBean.java a2cc8b8
common/src/main/java/org/apache/sqoop/json/JobBean.java a3e6071
common/src/main/java/org/apache/sqoop/json/JobValidationBean.java 34c0a4b
common/src/main/java/org/apache/sqoop/json/LinkBean.java 8981ea7
common/src/main/java/org/apache/sqoop/json/LinkValidationBean.java a6a6b65
common/src/main/java/org/apache/sqoop/json/ThrowableBean.java fc63ed4
common/src/main/java/org/apache/sqoop/json/ValidationResultBean.java 89bc8db
common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 77f6191
common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java 20ee5f3
common/src/main/java/org/apache/sqoop/model/Config.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigClass.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigUtils.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigurationClass.java 73374d8
common/src/main/java/org/apache/sqoop/model/ConfigurationGroupClass.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/Form.java 4321582
common/src/main/java/org/apache/sqoop/model/FormClass.java 6048d03
common/src/main/java/org/apache/sqoop/model/FormUtils.java ae025ab
common/src/main/java/org/apache/sqoop/model/MConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConfigList.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConfigType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConnectionForms.java 457ccdb
common/src/main/java/org/apache/sqoop/model/MConnector.java 3dc1014
common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 62eb197
common/src/main/java/org/apache/sqoop/model/MForm.java ff94660
common/src/main/java/org/apache/sqoop/model/MFormList.java 9130ada
common/src/main/java/org/apache/sqoop/model/MFormType.java 2f403df
common/src/main/java/org/apache/sqoop/model/MFromConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MJob.java c9b45a5
common/src/main/java/org/apache/sqoop/model/MJobForms.java 08b9a78
common/src/main/java/org/apache/sqoop/model/MLink.java 6a8c424
common/src/main/java/org/apache/sqoop/model/MLinkConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MToConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/ConfigValidationError.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/ConfigValidationResult.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/ConfigValidationRunner.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/Validation.java fce6e88
common/src/main/java/org/apache/sqoop/validation/ValidationError.java 264d6e3
common/src/main/java/org/apache/sqoop/validation/ValidationResult.java ae8f1d1
common/src/main/java/org/apache/sqoop/validation/ValidationRunner.java f36faf2
common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java e078474
common/src/test/java/org/apache/sqoop/json/TestDriverConfigBean.java 4309f10
common/src/test/java/org/apache/sqoop/json/TestJobBean.java c6461bf
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 8235275
common/src/test/java/org/apache/sqoop/json/TestUtil.java eaf9122
common/src/test/java/org/apache/sqoop/json/TestValidationBean.java f5f3389
common/src/test/java/org/apache/sqoop/json/TestValidationResultBean.java d9c2043
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/util/TestFormSerialization.java c4223ec
common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestFormUtils.java ba85d11
common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java d56e165
common/src/test/java/org/apache/sqoop/model/TestMConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMConnectionForms.java e2d2717
common/src/test/java/org/apache/sqoop/model/TestMConnector.java 3fde47b
common/src/test/java/org/apache/sqoop/model/TestMDriverConfig.java 9c23cc3
common/src/test/java/org/apache/sqoop/model/TestMForm.java 0bd55d9
common/src/test/java/org/apache/sqoop/model/TestMFormList.java c7ee682
common/src/test/java/org/apache/sqoop/model/TestMJob.java 96c316a
common/src/test/java/org/apache/sqoop/model/TestMJobConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMJobForms.java 81a8614
common/src/test/java/org/apache/sqoop/model/TestMLink.java 1be37a1
common/src/test/java/org/apache/sqoop/model/TestMLinkConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/validation/TestValidation.java bf0ade5
common/src/test/java/org/apache/sqoop/validation/TestValidationRunner.java 647abe0
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java b4b6966
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java 8deddb0
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java ad1ee5c
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java 8b23144
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfiguration.java b036421
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfig.java 7b76eeb
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfiguration.java 7d614f7
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfig.java a42a6ec
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfiguration.java ad68681
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java e10a5b4
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java 00c2aab
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java 47b186c
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 70833a0
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsValidator.java dfa3659
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 2c98051
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfiguration.java f861237
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java b689854
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfiguration.java 4970821
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java b1308db
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfiguration.java bba249c
core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java dbfdc03
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java c87df84
core/src/main/java/org/apache/sqoop/driver/Driver.java 5297bde
core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 8d6eb78
core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/DriverValidator.java 9cc51dd
core/src/main/java/org/apache/sqoop/driver/JobManager.java 277c6be
core/src/main/java/org/apache/sqoop/driver/JobRequest.java 63e1e49
core/src/main/java/org/apache/sqoop/driver/configuration/DriverConfiguration.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.java 908a4eb
core/src/main/java/org/apache/sqoop/driver/configuration/LinkConfiguration.java 3202844
core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingConfig.java PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingForm.java e73007e
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3466116
core/src/main/java/org/apache/sqoop/repository/Repository.java ea1608a
core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java ae7be82
core/src/main/resources/driver-config.properties 9ec5d9e
core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java 9c39d23
core/src/test/java/org/apache/sqoop/driver/TestJobManager.java 80f45e5
core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 796b021
execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 83c670c
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 2ed06a8
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java aecde40
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java eea0623
execution/mapreduce/src/test/java/org/apache/sqoop/job/JobUtils.java 09e5ec5
execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 869c727
execution/mapreduce/src/test/java/org/apache/sqoop/job/io/TestData.java 91df426
execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 1447e00
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 61dc3b4
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 5dd7970
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 58eed2d
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java ad42901
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 998f5b7
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java 8a5823d
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverConfigHandling.java 567dda6
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java c4a5829
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java f22c351
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 7378eda
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 38a995f
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java d1b6b9a
server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java c0d363e
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java b61d3f5
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 23fc9f1
shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java 97d8e6f
shell/src/main/java/org/apache/sqoop/shell/CloneLinkFunction.java d9babe0
shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java ccfed31
shell/src/main/java/org/apache/sqoop/shell/CreateLinkFunction.java 33d60c8
shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java 2ba75b4
shell/src/main/java/org/apache/sqoop/shell/ShowDriverConfigFunction.java e6e1004
shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java e3f1f47
shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java f500b9e
shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java 5d69c2a
shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java 96d1fd8
shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 30bb63e
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 4d3838c
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/DynamicConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/DynamicFormOptions.java cc63610
shell/src/main/java/org/apache/sqoop/shell/utils/FormDisplayer.java dcbccef
shell/src/main/java/org/apache/sqoop/shell/utils/FormFiller.java a0a5dc2
shell/src/main/java/org/apache/sqoop/shell/utils/FormOptions.java efd002e
shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicFormOptions.java 87c0776
shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicConfigOptions.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicFormOptions.java 2952be2
spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java e00b404
spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 7b78ba0
spi/src/main/java/org/apache/sqoop/validation/Validator.java 894f412
submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java fe92ac4
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 6074d36
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java 5e1abc1
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 2dc0613
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java 729f95e
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java 562a6a6
test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java 507ac53
Diff: https://reviews.apache.org/r/26145/diff/
Testing (updated)
-------
mvn test, integration tests
Thanks,
Veena Basavaraj