You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Romain Manni-Bucau <rm...@gmail.com> on 2014/02/18 11:12:36 UTC
false in filter?
Hi
<async-supported>false</async-supported> is no more supported by
default int tomcat for filter?
it is used in tcks and seems broken now
Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: false in filter?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
2014-02-19 21:12 GMT+01:00 Mark Thomas <ma...@apache.org>:
> On 19/02/2014 18:16, Romain Manni-Bucau wrote:
>> Le 19 févr. 2014 19:01, "Mark Thomas" <ma...@apache.org> a écrit :
>
>>> I think I am done for 8.0.x. It is a little verbose but it isn't too bad
>>> considering.
>>
>> Will you backport it on v7?
>
> Yes.
>
>> Any idea when a relase fixing this issues could be out? TomEE needs a
>> security release and would be better to not introduce hacks like the ones
>> we use ATM inside patch versions IMO.
>
> No fixed date I am aware of but I suspect fairly soon.
>
> Mark
>
Thank you (again ;)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: false in filter?
Posted by Mark Thomas <ma...@apache.org>.
On 19/02/2014 18:16, Romain Manni-Bucau wrote:
> Le 19 févr. 2014 19:01, "Mark Thomas" <ma...@apache.org> a écrit :
>> I think I am done for 8.0.x. It is a little verbose but it isn't too bad
>> considering.
>
> Will you backport it on v7?
Yes.
> Any idea when a relase fixing this issues could be out? TomEE needs a
> security release and would be better to not introduce hacks like the ones
> we use ATM inside patch versions IMO.
No fixed date I am aware of but I suspect fairly soon.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: false in filter?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Le 19 févr. 2014 19:01, "Mark Thomas" <ma...@apache.org> a écrit :
>
> On 19/02/2014 14:15, Konstantin Kolinko wrote:
> > 2014-02-19 17:21 GMT+04:00 Mark Thomas <ma...@apache.org>:
> >> There are two issues here.
> >>
> >> One is the issue cited above although it is much wider than just
> >> async-supported. I'm working though the specs now and I'll extend the
> >> test cases as I go.
> >>
> >
> > It it becomes too complicated,
>
> I think I am done for 8.0.x. It is a little verbose but it isn't too bad
> considering.
Will you backport it on v7?
>
> >> The second issue is why tldValidation is controlling this. That I'll
> >> look at once validation is fixed.
> >>
> >
> > From a quick look,
> > a) there is no separate option to control this.
> > (neither in catalina's Globals, nor in jasper's Constants, nor in JspC)
> >
> > b) The parsing itself occurs in
> > jasper.compiler.JspConfig#processWebDotXml()
>
> Agreed. I think something got missed / mis-translated in the back-port.
> The context level xml validation option needs to be passed through to
> Jasper.
>
Any idea when a relase fixing this issues could be out? TomEE needs a
security release and would be better to not introduce hacks like the ones
we use ATM inside patch versions IMO.
> Mark
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
Re: false in filter?
Posted by Mark Thomas <ma...@apache.org>.
On 19/02/2014 14:15, Konstantin Kolinko wrote:
> 2014-02-19 17:21 GMT+04:00 Mark Thomas <ma...@apache.org>:
>> There are two issues here.
>>
>> One is the issue cited above although it is much wider than just
>> async-supported. I'm working though the specs now and I'll extend the
>> test cases as I go.
>>
>
> It it becomes too complicated,
I think I am done for 8.0.x. It is a little verbose but it isn't too bad
considering.
>> The second issue is why tldValidation is controlling this. That I'll
>> look at once validation is fixed.
>>
>
> From a quick look,
> a) there is no separate option to control this.
> (neither in catalina's Globals, nor in jasper's Constants, nor in JspC)
>
> b) The parsing itself occurs in
> jasper.compiler.JspConfig#processWebDotXml()
Agreed. I think something got missed / mis-translated in the back-port.
The context level xml validation option needs to be passed through to
Jasper.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: false in filter?
Posted by Konstantin Kolinko <kn...@gmail.com>.
2014-02-19 17:21 GMT+04:00 Mark Thomas <ma...@apache.org>:
> On 18/02/2014 17:43, Konstantin Kolinko wrote:
>> 2014-02-18 20:05 GMT+04:00 Mark Thomas <ma...@apache.org>:
>>> On 18/02/2014 13:07, Romain Manni-Bucau wrote:
>>>> 2014-02-18 13:10 GMT+01:00 Mark Thomas <ma...@apache.org>:
>>>
>>> <snip/>
>>>
>>>>> Looks like there might be a couple of problems here. Any chance you
>>>>> could debug this and provide the full text of the merged web.xml?
>>>>>
>>>>
>>>> https://gist.github.com/rmannibucau/38292f66783c0d49965b
>>>
>>> OK. The error is valid. You have a 2.5 web.xml using 3.0 syntax.
>>> However, if the base web.xml is using 2.5, then there should not have
>>> been any merging. Hmm.
>>>
>>> What schema does /WEB-INF/web.xml declare in your app and where is
>>> TestFilter declared not to support async?
>>>
>>
>> In WebXml.toXml() lines 715-716 (in trunk)
>> [[[
>> appendElement(sb, INDENT4, "async-supported",
>> filterDef.getAsyncSupported());
>> ]]]
>>
>> needs to be wrapped by an if(version>=...).
>>
>> I tested that default conf/web.xml serializes/parses correctly but it
>> has no <filter>s in it, so apparently it slipped.
>
> There are two issues here.
>
> One is the issue cited above although it is much wider than just
> async-supported. I'm working though the specs now and I'll extend the
> test cases as I go.
>
It it becomes too complicated,
Alternative ways:
a)
Write out only those elements that are read by Jasper.
b) Re-implement asking this info from container,
but keep web.xml parser for standalone JspC.
http://svn.apache.org/viewvc?view=revision&revision=1377511
c)
Just turn off validation.
> The second issue is why tldValidation is controlling this. That I'll
> look at once validation is fixed.
>
>From a quick look,
a) there is no separate option to control this.
(neither in catalina's Globals, nor in jasper's Constants, nor in JspC)
b) The parsing itself occurs in
jasper.compiler.JspConfig#processWebDotXml()
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: false in filter?
Posted by Mark Thomas <ma...@apache.org>.
On 18/02/2014 17:43, Konstantin Kolinko wrote:
> 2014-02-18 20:05 GMT+04:00 Mark Thomas <ma...@apache.org>:
>> On 18/02/2014 13:07, Romain Manni-Bucau wrote:
>>> 2014-02-18 13:10 GMT+01:00 Mark Thomas <ma...@apache.org>:
>>
>> <snip/>
>>
>>>> Looks like there might be a couple of problems here. Any chance you
>>>> could debug this and provide the full text of the merged web.xml?
>>>>
>>>
>>> https://gist.github.com/rmannibucau/38292f66783c0d49965b
>>
>> OK. The error is valid. You have a 2.5 web.xml using 3.0 syntax.
>> However, if the base web.xml is using 2.5, then there should not have
>> been any merging. Hmm.
>>
>> What schema does /WEB-INF/web.xml declare in your app and where is
>> TestFilter declared not to support async?
>>
>
> In WebXml.toXml() lines 715-716 (in trunk)
> [[[
> appendElement(sb, INDENT4, "async-supported",
> filterDef.getAsyncSupported());
> ]]]
>
> needs to be wrapped by an if(version>=...).
>
> I tested that default conf/web.xml serializes/parses correctly but it
> has no <filter>s in it, so apparently it slipped.
There are two issues here.
One is the issue cited above although it is much wider than just
async-supported. I'm working though the specs now and I'll extend the
test cases as I go.
The second issue is why tldValidation is controlling this. That I'll
look at once validation is fixed.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: false in filter?
Posted by Konstantin Kolinko <kn...@gmail.com>.
2014-02-18 20:05 GMT+04:00 Mark Thomas <ma...@apache.org>:
> On 18/02/2014 13:07, Romain Manni-Bucau wrote:
>> 2014-02-18 13:10 GMT+01:00 Mark Thomas <ma...@apache.org>:
>
> <snip/>
>
>>> Looks like there might be a couple of problems here. Any chance you
>>> could debug this and provide the full text of the merged web.xml?
>>>
>>
>> https://gist.github.com/rmannibucau/38292f66783c0d49965b
>
> OK. The error is valid. You have a 2.5 web.xml using 3.0 syntax.
> However, if the base web.xml is using 2.5, then there should not have
> been any merging. Hmm.
>
> What schema does /WEB-INF/web.xml declare in your app and where is
> TestFilter declared not to support async?
>
In WebXml.toXml() lines 715-716 (in trunk)
[[[
appendElement(sb, INDENT4, "async-supported",
filterDef.getAsyncSupported());
]]]
needs to be wrapped by an if(version>=...).
I tested that default conf/web.xml serializes/parses correctly but it
has no <filter>s in it, so apparently it slipped.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: false in filter?
Posted by Mark Thomas <ma...@apache.org>.
On 18/02/2014 16:11, Romain Manni-Bucau wrote:
> 2014-02-18 17:05 GMT+01:00 Mark Thomas <ma...@apache.org>:
>> On 18/02/2014 13:07, Romain Manni-Bucau wrote:
>>> 2014-02-18 13:10 GMT+01:00 Mark Thomas <ma...@apache.org>:
>>
>> <snip/>
>>
>>>> Looks like there might be a couple of problems here. Any chance you
>>>> could debug this and provide the full text of the merged web.xml?
>>>>
>>>
>>> https://gist.github.com/rmannibucau/38292f66783c0d49965b
>>
>> OK. The error is valid. You have a 2.5 web.xml using 3.0 syntax.
>> However, if the base web.xml is using 2.5, then there should not have
>> been any merging. Hmm.
>>
>> What schema does /WEB-INF/web.xml declare in your app and where is
>> TestFilter declared not to support async?
>>
>
> https://github.com/cdi-spec/cdi-tck/blob/1.0/impl/src/main/java/org/jboss/jsr299/tck/tests/lookup/injection/non/contextual/TestFilter.java
Not quite what I meant but I should be able to find what I need. Just to
confirm, you are using version 1.0.0 of the CDI TCK?
> https://github.com/cdi-spec/cdi-tck/blob/1.0/impl/src/main/resources/org/jboss/jsr299/tck/tests/lookup/injection/non/contextual/web.xml
OK. So definitely a 2.5 web app.
>> Exactly how were you enabling/disabling tldValidation? I'm still trying
>> to figure out why enabling that triggered validation of web.xml.
>>
>
> standardContext.setTldValidation(System.getProperty("myprop", "false"));
OK. I can trace it from there.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: false in filter?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
2014-02-18 17:05 GMT+01:00 Mark Thomas <ma...@apache.org>:
> On 18/02/2014 13:07, Romain Manni-Bucau wrote:
>> 2014-02-18 13:10 GMT+01:00 Mark Thomas <ma...@apache.org>:
>
> <snip/>
>
>>> Looks like there might be a couple of problems here. Any chance you
>>> could debug this and provide the full text of the merged web.xml?
>>>
>>
>> https://gist.github.com/rmannibucau/38292f66783c0d49965b
>
> OK. The error is valid. You have a 2.5 web.xml using 3.0 syntax.
> However, if the base web.xml is using 2.5, then there should not have
> been any merging. Hmm.
>
> What schema does /WEB-INF/web.xml declare in your app and where is
> TestFilter declared not to support async?
>
https://github.com/cdi-spec/cdi-tck/blob/1.0/impl/src/main/java/org/jboss/jsr299/tck/tests/lookup/injection/non/contextual/TestFilter.java
https://github.com/cdi-spec/cdi-tck/blob/1.0/impl/src/main/resources/org/jboss/jsr299/tck/tests/lookup/injection/non/contextual/web.xml
> Exactly how were you enabling/disabling tldValidation? I'm still trying
> to figure out why enabling that triggered validation of web.xml.
>
standardContext.setTldValidation(System.getProperty("myprop", "false"));
> Mark
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: false in filter?
Posted by Mark Thomas <ma...@apache.org>.
On 18/02/2014 13:07, Romain Manni-Bucau wrote:
> 2014-02-18 13:10 GMT+01:00 Mark Thomas <ma...@apache.org>:
<snip/>
>> Looks like there might be a couple of problems here. Any chance you
>> could debug this and provide the full text of the merged web.xml?
>>
>
> https://gist.github.com/rmannibucau/38292f66783c0d49965b
OK. The error is valid. You have a 2.5 web.xml using 3.0 syntax.
However, if the base web.xml is using 2.5, then there should not have
been any merging. Hmm.
What schema does /WEB-INF/web.xml declare in your app and where is
TestFilter declared not to support async?
Exactly how were you enabling/disabling tldValidation? I'm still trying
to figure out why enabling that triggered validation of web.xml.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: false in filter?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
2014-02-18 13:10 GMT+01:00 Mark Thomas <ma...@apache.org>:
> On 18/02/2014 12:01, Romain Manni-Bucau wrote:
>> 2014-02-18 12:15 GMT+01:00 Mark Thomas <ma...@apache.org>:
>>> On 18/02/2014 11:06, Romain Manni-Bucau wrote:
>
> <snip/>
>
>>>> I got it from JspConfig:
>>>
>>> Got what from JspConfig?
>>
>> the previous stack:
>>
>> INFO: <html><head><title>Apache Tomcat (TomEE)/7.0.52 (1.6.1-SNAPSHOT)
>> - Error report</title><style><!--H1
>> {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:22px;}
>> H2 {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:16px;}
>> H3 {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:14px;}
>> BODY {font-family:Tahoma,Arial,sans-serif;color:black;background-color:white;}
>> B {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;}
>> P {font-family:Tahoma,Arial,sans-serif;background:white;color:black;font-size:12px;}A
>> {color : black;}A.name {color : black;}HR {color :
>> #525D76;}--></style> </head><body><h1>HTTP Status 500 -
>> org.apache.jasper.JasperException: XML parsing error on file
>> org.apache.tomcat.util.scan.MergedWebXml: (line 13, col 22)</h1><HR
>> size="1" noshade="noshade"><p><b>type</b> Exception
>> report</p><p><b>message</b> <u>org.apache.jasper.JasperException: XML
>> parsing error on file org.apache.tomcat.util.scan.MergedWebXml: (line
>> 13, col 22)</u></p><p><b>description</b> <u>The server encountered an
>> internal error that prevented it from fulfilling this
>> request.</u></p><p><b>exception</b>
>> <pre>org.apache.jasper.JasperException:
>> org.apache.jasper.JasperException: XML parsing error on file
>> org.apache.tomcat.util.scan.MergedWebXml: (line 13, col 22)
>> org.apache.jasper.compiler.JspConfig.processWebDotXml(JspConfig.java:230)
>> org.apache.jasper.compiler.JspConfig.init(JspConfig.java:243)
>> org.apache.jasper.compiler.JspConfig.findJspProperty(JspConfig.java:302)
>
> <snip/>
>
>>> I don't understand how TLD validation is triggering a problem with async
>>> (unless a whole web application is failing to start) and I'd like to. If
>>> disabling TLD validation enables the TCK to pass then I don't see an
>>> issue with doing that.
>>
>> me neither seems tomcat is parsing web.xml using tld validation property
>
> Looks like there might be a couple of problems here. Any chance you
> could debug this and provide the full text of the merged web.xml?
>
https://gist.github.com/rmannibucau/38292f66783c0d49965b
> Mark
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: false in filter?
Posted by Mark Thomas <ma...@apache.org>.
On 18/02/2014 12:01, Romain Manni-Bucau wrote:
> 2014-02-18 12:15 GMT+01:00 Mark Thomas <ma...@apache.org>:
>> On 18/02/2014 11:06, Romain Manni-Bucau wrote:
<snip/>
>>> I got it from JspConfig:
>>
>> Got what from JspConfig?
>
> the previous stack:
>
> INFO: <html><head><title>Apache Tomcat (TomEE)/7.0.52 (1.6.1-SNAPSHOT)
> - Error report</title><style><!--H1
> {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:22px;}
> H2 {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:16px;}
> H3 {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:14px;}
> BODY {font-family:Tahoma,Arial,sans-serif;color:black;background-color:white;}
> B {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;}
> P {font-family:Tahoma,Arial,sans-serif;background:white;color:black;font-size:12px;}A
> {color : black;}A.name {color : black;}HR {color :
> #525D76;}--></style> </head><body><h1>HTTP Status 500 -
> org.apache.jasper.JasperException: XML parsing error on file
> org.apache.tomcat.util.scan.MergedWebXml: (line 13, col 22)</h1><HR
> size="1" noshade="noshade"><p><b>type</b> Exception
> report</p><p><b>message</b> <u>org.apache.jasper.JasperException: XML
> parsing error on file org.apache.tomcat.util.scan.MergedWebXml: (line
> 13, col 22)</u></p><p><b>description</b> <u>The server encountered an
> internal error that prevented it from fulfilling this
> request.</u></p><p><b>exception</b>
> <pre>org.apache.jasper.JasperException:
> org.apache.jasper.JasperException: XML parsing error on file
> org.apache.tomcat.util.scan.MergedWebXml: (line 13, col 22)
> org.apache.jasper.compiler.JspConfig.processWebDotXml(JspConfig.java:230)
> org.apache.jasper.compiler.JspConfig.init(JspConfig.java:243)
> org.apache.jasper.compiler.JspConfig.findJspProperty(JspConfig.java:302)
<snip/>
>> I don't understand how TLD validation is triggering a problem with async
>> (unless a whole web application is failing to start) and I'd like to. If
>> disabling TLD validation enables the TCK to pass then I don't see an
>> issue with doing that.
>
> me neither seems tomcat is parsing web.xml using tld validation property
Looks like there might be a couple of problems here. Any chance you
could debug this and provide the full text of the merged web.xml?
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: false in filter?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
2014-02-18 12:15 GMT+01:00 Mark Thomas <ma...@apache.org>:
> On 18/02/2014 11:06, Romain Manni-Bucau wrote:
>> 2014-02-18 11:54 GMT+01:00 Mark Thomas <ma...@apache.org>:
>>> Yet again, please don't top post.
>>>
>>> On 18/02/2014 10:21, Romain Manni-Bucau wrote:
>>>> edit: org.apache.jasper.compiler.JspConfig#processWebDotXml validates
>>>> the xml immediately and doesn't read the version from WebXml - from
>>>> ContextConfig with getMajorVersion, getMinorVersion methods
>>>
>>> Which Tomcat release are you referring to?
>>
>> 7.0.52
>>
>>>
>>> What has Jasper's processing of web.xml (which is looking at a sub-set
>>> of configuration that doesn't include async support) got to do with this
>>> issue?
>>>
>>
>> I got it from JspConfig:
>
> Got what from JspConfig?
the previous stack:
INFO: <html><head><title>Apache Tomcat (TomEE)/7.0.52 (1.6.1-SNAPSHOT)
- Error report</title><style><!--H1
{font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:22px;}
H2 {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:16px;}
H3 {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:14px;}
BODY {font-family:Tahoma,Arial,sans-serif;color:black;background-color:white;}
B {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;}
P {font-family:Tahoma,Arial,sans-serif;background:white;color:black;font-size:12px;}A
{color : black;}A.name {color : black;}HR {color :
#525D76;}--></style> </head><body><h1>HTTP Status 500 -
org.apache.jasper.JasperException: XML parsing error on file
org.apache.tomcat.util.scan.MergedWebXml: (line 13, col 22)</h1><HR
size="1" noshade="noshade"><p><b>type</b> Exception
report</p><p><b>message</b> <u>org.apache.jasper.JasperException: XML
parsing error on file org.apache.tomcat.util.scan.MergedWebXml: (line
13, col 22)</u></p><p><b>description</b> <u>The server encountered an
internal error that prevented it from fulfilling this
request.</u></p><p><b>exception</b>
<pre>org.apache.jasper.JasperException:
org.apache.jasper.JasperException: XML parsing error on file
org.apache.tomcat.util.scan.MergedWebXml: (line 13, col 22)
org.apache.jasper.compiler.JspConfig.processWebDotXml(JspConfig.java:230)
org.apache.jasper.compiler.JspConfig.init(JspConfig.java:243)
org.apache.jasper.compiler.JspConfig.findJspProperty(JspConfig.java:302)
>
> And how does this relate to an issue with async processing?
>
>> basically deactivated tldValidation to make it passing
>
> That doesn't surprise me. The Servlet TCK won't pass either unless
> tldValidation is disabled. The specs don't mandate tldValidation so
> disabling it for the TCKs should be OK.
>
>>>>> it is used in tcks and seems broken now
>>>
>>> Which TCK? With which Tomcat version?
>>
>> CDI TCKs (didnt check JavaEE ones yet)
>
> I don't understand how TLD validation is triggering a problem with async
> (unless a whole web application is failing to start) and I'd like to. If
> disabling TLD validation enables the TCK to pass then I don't see an
> issue with doing that.
me neither seems tomcat is parsing web.xml using tld validation property
>
> Mark
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: false in filter?
Posted by Mark Thomas <ma...@apache.org>.
On 18/02/2014 11:06, Romain Manni-Bucau wrote:
> 2014-02-18 11:54 GMT+01:00 Mark Thomas <ma...@apache.org>:
>> Yet again, please don't top post.
>>
>> On 18/02/2014 10:21, Romain Manni-Bucau wrote:
>>> edit: org.apache.jasper.compiler.JspConfig#processWebDotXml validates
>>> the xml immediately and doesn't read the version from WebXml - from
>>> ContextConfig with getMajorVersion, getMinorVersion methods
>>
>> Which Tomcat release are you referring to?
>
> 7.0.52
>
>>
>> What has Jasper's processing of web.xml (which is looking at a sub-set
>> of configuration that doesn't include async support) got to do with this
>> issue?
>>
>
> I got it from JspConfig:
Got what from JspConfig?
And how does this relate to an issue with async processing?
> basically deactivated tldValidation to make it passing
That doesn't surprise me. The Servlet TCK won't pass either unless
tldValidation is disabled. The specs don't mandate tldValidation so
disabling it for the TCKs should be OK.
>>>> it is used in tcks and seems broken now
>>
>> Which TCK? With which Tomcat version?
>
> CDI TCKs (didnt check JavaEE ones yet)
I don't understand how TLD validation is triggering a problem with async
(unless a whole web application is failing to start) and I'd like to. If
disabling TLD validation enables the TCK to pass then I don't see an
issue with doing that.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: false in filter?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
2014-02-18 11:54 GMT+01:00 Mark Thomas <ma...@apache.org>:
> Yet again, please don't top post.
>
> On 18/02/2014 10:21, Romain Manni-Bucau wrote:
>> edit: org.apache.jasper.compiler.JspConfig#processWebDotXml validates
>> the xml immediately and doesn't read the version from WebXml - from
>> ContextConfig with getMajorVersion, getMinorVersion methods
>
> Which Tomcat release are you referring to?
7.0.52
>
> What has Jasper's processing of web.xml (which is looking at a sub-set
> of configuration that doesn't include async support) got to do with this
> issue?
>
I got it from JspConfig:
org.apache.jasper.compiler.JspConfig.processWebDotXml(JspConfig.java:230)
org.apache.jasper.compiler.JspConfig.init(JspConfig.java:243)
org.apache.jasper.compiler.JspConfig.findJspProperty(JspConfig.java:302)
org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:114)
org.apache.jasper.compiler.Compiler.compile(Compiler.java:373)
org.apache.jasper.compiler.Compiler.compile(Compiler.java:353)
org.apache.jasper.compiler.Compiler.compile(Compiler.java:340)
org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:657)
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:357)
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:390)
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:334)
javax.servlet.http.HttpServlet.service(HttpServlet.java:727)
>> Romain Manni-Bucau
>> Twitter: @rmannibucau
>> Blog: http://rmannibucau.wordpress.com/
>> LinkedIn: http://fr.linkedin.com/in/rmannibucau
>> Github: https://github.com/rmannibucau
>>
>>
>>
>> 2014-02-18 11:12 GMT+01:00 Romain Manni-Bucau <rm...@gmail.com>:
>>> Hi
>>>
>>> <async-supported>false</async-supported> is no more supported by
>>> default int tomcat for filter?
>
> It should be supported. There were some changes to xml parsing to
> improve validation but that shouldn't impact this. I don't recall any
> other changes but it isn't impossible that something has been missed.
>
basically deactivated tldValidation to make it passing
>>> it is used in tcks and seems broken now
>
> Which TCK? With which Tomcat version?
CDI TCKs (didnt check JavaEE ones yet)
>
> Mark
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: false in filter?
Posted by Mark Thomas <ma...@apache.org>.
Yet again, please don't top post.
On 18/02/2014 10:21, Romain Manni-Bucau wrote:
> edit: org.apache.jasper.compiler.JspConfig#processWebDotXml validates
> the xml immediately and doesn't read the version from WebXml - from
> ContextConfig with getMajorVersion, getMinorVersion methods
Which Tomcat release are you referring to?
What has Jasper's processing of web.xml (which is looking at a sub-set
of configuration that doesn't include async support) got to do with this
issue?
> Romain Manni-Bucau
> Twitter: @rmannibucau
> Blog: http://rmannibucau.wordpress.com/
> LinkedIn: http://fr.linkedin.com/in/rmannibucau
> Github: https://github.com/rmannibucau
>
>
>
> 2014-02-18 11:12 GMT+01:00 Romain Manni-Bucau <rm...@gmail.com>:
>> Hi
>>
>> <async-supported>false</async-supported> is no more supported by
>> default int tomcat for filter?
It should be supported. There were some changes to xml parsing to
improve validation but that shouldn't impact this. I don't recall any
other changes but it isn't impossible that something has been missed.
>> it is used in tcks and seems broken now
Which TCK? With which Tomcat version?
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: false in filter?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
edit: org.apache.jasper.compiler.JspConfig#processWebDotXml validates
the xml immediately and doesn't read the version from WebXml - from
ContextConfig with getMajorVersion, getMinorVersion methods
Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau
2014-02-18 11:12 GMT+01:00 Romain Manni-Bucau <rm...@gmail.com>:
> Hi
>
> <async-supported>false</async-supported> is no more supported by
> default int tomcat for filter?
>
> it is used in tcks and seems broken now
>
> Romain Manni-Bucau
> Twitter: @rmannibucau
> Blog: http://rmannibucau.wordpress.com/
> LinkedIn: http://fr.linkedin.com/in/rmannibucau
> Github: https://github.com/rmannibucau
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org