You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by "JiaLiangC (via GitHub)" <gi...@apache.org> on 2024/01/25 09:13:36 UTC
[PR] BIGTOP-4059: Add Documentation for Parallel Maven Compilation in Bigtop [bigtop]
JiaLiangC opened a new pull request, #1232:
URL: https://github.com/apache/bigtop/pull/1232
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g., 'BIGTOP-3638: Your PR title ...'.
-->
### Description of PR
Add Documentation for Parallel Maven Compilation in Bigtop
### How was this patch tested?
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
- [ ] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BIGTOP-4059: Add Documentation for Parallel Maven Compilation in Bigtop [bigtop]
Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC commented on PR #1232:
URL: https://github.com/apache/bigtop/pull/1232#issuecomment-1915850086
@guyuqi Could you help review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BIGTOP-4059: Add Documentation for Parallel Maven Compilation in Bigtop [bigtop]
Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC commented on code in PR #1232:
URL: https://github.com/apache/bigtop/pull/1232#discussion_r1470501678
##########
bigtop.bom:
##########
@@ -86,7 +86,10 @@
packaging = 'rpm' // *optional* If this component can be built only as either
// DEB or RPM, specify that packaging format explicitly.
// If both formats are supported, omit this option.
- maven_parallel_build = true
+ maven_parallel_build = true // *optional* maven_parallel_build indicates whether the component can be built in parallel.
+ // Components with this flag can have the Maven parallel build parameter -PbuildThreads=2C or -PbuildThreads=2
Review Comment:
> Currently `-PbuildThread=2` is not allowed. How about fix [the code](https://github.com/apache/bigtop/blob/fc93b76a8d3f51531af730f9f6397e91fd6b91cb/packages.gradle#L456-L457) here? @JiaLiangC
@iwasakims Thank you for the reminder. I will fix the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BIGTOP-4059: Add Documentation for Parallel Maven Compilation in Bigtop [bigtop]
Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC commented on PR #1232:
URL: https://github.com/apache/bigtop/pull/1232#issuecomment-1909717757
@iwasakims Could you help review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BIGTOP-4059: Add Documentation for Parallel Maven Compilation in Bigtop [bigtop]
Posted by "guyuqi (via GitHub)" <gi...@apache.org>.
guyuqi commented on PR #1232:
URL: https://github.com/apache/bigtop/pull/1232#issuecomment-1915927560
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BIGTOP-4059: Add Documentation for Parallel Maven Compilation in Bigtop [bigtop]
Posted by "guyuqi (via GitHub)" <gi...@apache.org>.
guyuqi merged PR #1232:
URL: https://github.com/apache/bigtop/pull/1232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BIGTOP-4059: Add Documentation for Parallel Maven Compilation in Bigtop [bigtop]
Posted by "iwasakims (via GitHub)" <gi...@apache.org>.
iwasakims commented on code in PR #1232:
URL: https://github.com/apache/bigtop/pull/1232#discussion_r1470498519
##########
bigtop.bom:
##########
@@ -86,7 +86,10 @@
packaging = 'rpm' // *optional* If this component can be built only as either
// DEB or RPM, specify that packaging format explicitly.
// If both formats are supported, omit this option.
- maven_parallel_build = true
+ maven_parallel_build = true // *optional* maven_parallel_build indicates whether the component can be built in parallel.
+ // Components with this flag can have the Maven parallel build parameter -PbuildThreads=2C or -PbuildThreads=2
Review Comment:
Currently `-PbuildThread=2` is not allowed. How about fix [the code](https://github.com/apache/bigtop/blob/fc93b76a8d3f51531af730f9f6397e91fd6b91cb/packages.gradle#L456-L457) here? @JiaLiangC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BIGTOP-4059: Add Documentation for Parallel Maven Compilation in Bigtop [bigtop]
Posted by "iwasakims (via GitHub)" <gi...@apache.org>.
iwasakims commented on code in PR #1232:
URL: https://github.com/apache/bigtop/pull/1232#discussion_r1470499836
##########
bigtop.bom:
##########
@@ -86,7 +86,10 @@
packaging = 'rpm' // *optional* If this component can be built only as either
// DEB or RPM, specify that packaging format explicitly.
// If both formats are supported, omit this option.
- maven_parallel_build = true
+ maven_parallel_build = true // *optional* maven_parallel_build indicates whether the component can be built in parallel.
+ // Components with this flag can have the Maven parallel build parameter -PbuildThreads=2C or -PbuildThreads=2
Review Comment:
Oops. My comment conflicts with @guyuqi. We can fix this with follow-up JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org