[GitHub] [apisix] dmsolr opened a new pull request #4060: update skywalking componentId

[GitBox <gi...@apache.org>]

dmsolr opened a new pull request #4060:
URL: https://github.com/apache/apisix/pull/4060


   ### What this PR does / why we need it:
   
   SkyWalking has assigned a new component id for APISIX. For more information see #4059 
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ### Pre-submission checklist:
   
   * [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander merged pull request #4060: feat: update skywalking componentId

[GitBox <gi...@apache.org>]

spacewander merged pull request #4060:
URL: https://github.com/apache/apisix/pull/4060


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] Firstsawyou commented on a change in pull request #4060: feat: update skywalking componentId

[GitBox <gi...@apache.org>]

Firstsawyou commented on a change in pull request #4060:
URL: https://github.com/apache/apisix/pull/4060#discussion_r614574061



##########
File path: apisix/plugins/skywalking.lua
##########
@@ -17,6 +17,7 @@
 local sw_tracer = require("skywalking.tracer")
 local core = require("apisix.core")
 local process = require("ngx.process")
+local Span = require('skywalking.span')

Review comment:
       I think it would be better to keep the style uniform.
   
   ```suggestion
   local Span = require("skywalking.span")
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org