You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/11/07 17:35:05 UTC
[GitHub] [netbeans] sdedic opened a new pull request, #4936: #4923: access to gradle internal APIs is protected from failing the project load, just logs a notification.
sdedic opened a new pull request, #4936:
URL: https://github.com/apache/netbeans/pull/4936
The culprit for the reported error (see #4923) is a `LinkageError` as the gradle version configured for the build changed its internal APIs (a change needed to adopt Groovy 4.0). It's true that now the gradle project loader accesses even gradle internal APIs that can be less stable than the proper APIs.
This PR centralizes the gradle internal access to `GradleInternalAdapter` class. Each call to an internal API should be now guarded with `safeCall` that blocks thrown `Errors` and `RuntimeExceptions` and logs them as problems, but continue the loading process.
The main `NbProjectInfoBuilder` should be now free of references to Gradle internals. To accommodate different API versions, the Adapter can be subclassed with alternative implementations for both newer or older versions that the one the gradle tooling is compiled againts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4936: #4923: access to gradle internal APIs is protected from failing the project load, just logs a notification.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4936:
URL: https://github.com/apache/netbeans/pull/4936#issuecomment-1307026976
OK, @MartinBalin made the call - we're having RC4! :smile:
Let's hold off merge until @lkishalmi is happy with what's going in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #4936: #4923: access to gradle internal APIs is protected from failing the project load, just logs a notification.
Posted by GitBox <gi...@apache.org>.
sdedic commented on PR #4936:
URL: https://github.com/apache/netbeans/pull/4936#issuecomment-1306738654
> I've created a branch for Gradle 7.6-rc-1 upgrade. This one cannot compile with Gradle 7.6 as of:
>
The same reason as `hasFixedValue` could not compile on pre-7.6-rc-1. The PR uses regular call for the bundled gradle, and reflection for 'the other versions'. I thought the code will change to compile against 7.6 when the bundled APIs are upgraded (and will use reflection to work with earlier versions).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] swpalmer commented on pull request #4936: #4923: access to gradle internal APIs is protected from failing the project load, just logs a notification.
Posted by GitBox <gi...@apache.org>.
swpalmer commented on PR #4936:
URL: https://github.com/apache/netbeans/pull/4936#issuecomment-1307753473
Gradle 7.6-RC-2 has become available, so it will be at least another week before a Gradle 7.6 release is possible. Makes sense not to hold up NB 16 when we have this PR to cover the gap until NB 17 can include the updated Gradle.ScottOn Nov 8, 2022, at 11:52 AM, Laszlo Kishalmi ***@***.***> wrote:
@lkishalmi approved this pull request.
Well, re-checked the implementation. Changing my vote.
I'm more on favor to have this one on NB16, then probably have the Gradle upgrade on NB17.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] MartinBalin commented on pull request #4936: #4923: access to gradle internal APIs is protected from failing the project load, just logs a notification.
Posted by GitBox <gi...@apache.org>.
MartinBalin commented on PR #4936:
URL: https://github.com/apache/netbeans/pull/4936#issuecomment-1307016999
I would like to proceed and merge this PR for RC4 NB16 don't wait for next release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #4936: #4923: access to gradle internal APIs is protected from failing the project load, just logs a notification.
Posted by GitBox <gi...@apache.org>.
sdedic commented on PR #4936:
URL: https://github.com/apache/netbeans/pull/4936#issuecomment-1306771023
re.: using internal APIs -- currently the usage is rather minimalistic and the benefit of getting default + all conventions applied is enormous (configured values), compared to 'hand-made' extraction and approximation - given all the flexibility an imperative buildscript gives to the user. It's still an API, internal - but still with some degree of maintenance, as it provides interface between Gradle subprojects.
So let me disagree with cutting it out. Maybe @swpalmer / @errael suggestion would be ideal: ask to export a minimalistic introspection API (see discussion in #4923)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #4936: #4923: access to gradle internal APIs is protected from failing the project load, just logs a notification.
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on PR #4936:
URL: https://github.com/apache/netbeans/pull/4936#issuecomment-1306669324
Well, better than none, though I feel we have cut ourselves by using Gradle internal stuff. I fear this is just a bandaid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #4936: #4923: access to gradle internal APIs is protected from failing the project load, just logs a notification.
Posted by GitBox <gi...@apache.org>.
sdedic commented on PR #4936:
URL: https://github.com/apache/netbeans/pull/4936#issuecomment-1306902430
@neilcsmith-net please decide on the solution with respect to the release schedule:
1. leave unattended for NB16
2. go with the PR as it is, then upgrade to Gradle 7.6-rc1 to cover JDK19
3. make calls for both versions reflective for NB16, then discuss whether that is appropriate
4. other solution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #4936: #4923: access to gradle internal APIs is protected from failing the project load, just logs a notification.
Posted by GitBox <gi...@apache.org>.
sdedic commented on PR #4936:
URL: https://github.com/apache/netbeans/pull/4936#issuecomment-1306954288
> @sdedic I'd rather stay out of making that call if possible.
OK, let's wait (even with RC4 ?) on how the consensus evolves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #4936: #4923: access to gradle internal APIs is protected from failing the project load, just logs a notification.
Posted by GitBox <gi...@apache.org>.
sdedic commented on PR #4936:
URL: https://github.com/apache/netbeans/pull/4936#issuecomment-1306789622
@lkishalmi if you point me to the branch for 7.6 update, I can contribute apdated reflection code there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] MartinBalin commented on pull request #4936: #4923: access to gradle internal APIs is protected from failing the project load, just logs a notification.
Posted by GitBox <gi...@apache.org>.
MartinBalin commented on PR #4936:
URL: https://github.com/apache/netbeans/pull/4936#issuecomment-1307677232
Thank's all, merged to delivery to be in NB16.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] MartinBalin merged pull request #4936: #4923: access to gradle internal APIs is protected from failing the project load, just logs a notification.
Posted by GitBox <gi...@apache.org>.
MartinBalin merged PR #4936:
URL: https://github.com/apache/netbeans/pull/4936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4936: #4923: access to gradle internal APIs is protected from failing the project load, just logs a notification.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4936:
URL: https://github.com/apache/netbeans/pull/4936#issuecomment-1306924082
@sdedic I'd rather stay out of making that call if possible. That's one for you and other reviewers to make primarily - this is covered at https://lists.apache.org/thread/hyjbsz55zb9xfcnccghkrsvqsnt83nwf
Maybe @MartinBalin has a view from releases side? If this was in Maven support I'd feel more comfortable taking a view. @ebarboni ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists