You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/09/24 13:51:21 UTC
[GitHub] [ignite] alamar opened a new pull request #8277: IGNITE-13431 Fix NPE when PRIMITIVE strategy is used with BLOB value.
alamar opened a new pull request #8277:
URL: https://github.com/apache/ignite/pull/8277
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] AMashenkov merged pull request #8277: IGNITE-13431 Fix NPE when PRIMITIVE strategy is used with BLOB value.
Posted by GitBox <gi...@apache.org>.
AMashenkov merged pull request #8277:
URL: https://github.com/apache/ignite/pull/8277
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] AMashenkov commented on a change in pull request #8277: IGNITE-13431 Fix NPE when PRIMITIVE strategy is used with BLOB value.
Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #8277:
URL: https://github.com/apache/ignite/pull/8277#discussion_r498759250
##########
File path: modules/cassandra/store/src/main/java/org/apache/ignite/cache/store/cassandra/persistence/PersistenceSettings.java
##########
@@ -544,14 +544,14 @@ private void readObject(java.io.ObjectInputStream in) throws IOException, ClassN
*/
protected List<F> enrichFields(List<F> src) {
if (src != null) {
- List<F> enriched = new ArrayList<>(src.size());
+ List<F> enriched = new ArrayList<>();
Review comment:
Why are you drop ArrayList initial size to default one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] AMashenkov merged pull request #8277: IGNITE-13431 Fix NPE when PRIMITIVE strategy is used with BLOB value.
Posted by GitBox <gi...@apache.org>.
AMashenkov merged pull request #8277:
URL: https://github.com/apache/ignite/pull/8277
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alamar commented on a change in pull request #8277: IGNITE-13431 Fix NPE when PRIMITIVE strategy is used with BLOB value.
Posted by GitBox <gi...@apache.org>.
alamar commented on a change in pull request #8277:
URL: https://github.com/apache/ignite/pull/8277#discussion_r498873944
##########
File path: modules/cassandra/store/src/main/java/org/apache/ignite/cache/store/cassandra/persistence/PersistenceSettings.java
##########
@@ -544,14 +544,14 @@ private void readObject(java.io.ObjectInputStream in) throws IOException, ClassN
*/
protected List<F> enrichFields(List<F> src) {
if (src != null) {
- List<F> enriched = new ArrayList<>(src.size());
+ List<F> enriched = new ArrayList<>();
Review comment:
This list is only created once per cache initialization, and is expected to have small size (<1000 entries), making initial size specification superfluous in my opinion. Do you have any specific reason why this exact ArrayList needs initial size?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org