You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by be...@apache.org on 2023/10/04 23:51:46 UTC
[superset] branch small_fixes_test_db created (now e3e2731059)
This is an automated email from the ASF dual-hosted git repository.
beto pushed a change to branch small_fixes_test_db
in repository https://gitbox.apache.org/repos/asf/superset.git
at e3e2731059 fix(test-db): removed colum
This branch includes the following new commits:
new e3e2731059 fix(test-db): removed colum
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[superset] 01/01: fix(test-db): removed colum
Posted by be...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
beto pushed a commit to branch small_fixes_test_db
in repository https://gitbox.apache.org/repos/asf/superset.git
commit e3e2731059b2cdbac83fec31459a6edac9377489
Author: Beto Dealmeida <ro...@dealmeida.net>
AuthorDate: Wed Oct 4 16:49:15 2023 -0700
fix(test-db): removed colum
---
superset/cli/test_db.py | 15 ++++++++++-----
superset/db_engine_specs/lib.py | 2 --
2 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/superset/cli/test_db.py b/superset/cli/test_db.py
index 7ec69b044c..78063a639f 100644
--- a/superset/cli/test_db.py
+++ b/superset/cli/test_db.py
@@ -67,7 +67,12 @@ user_prefs = Table(
"tmp_superset_test_table_user_prefs",
metadata_obj,
Column("pref_id", Integer, primary_key=True),
- Column("user_id", Integer, ForeignKey("user.user_id"), nullable=False),
+ Column(
+ "user_id",
+ Integer,
+ ForeignKey("tmp_superset_test_table_user.user_id"),
+ nullable=False,
+ ),
Column("pref_name", String(40), nullable=False),
Column("pref_value", String(100)),
)
@@ -118,12 +123,12 @@ def test_datetime(console: Console, engine: Engine) -> None:
now = datetime.now()
console.print("Inserting timestamp value...")
- stmt = insert(table).values(ts=now)
- engine.execute(stmt)
+ insert_stmt = insert(table).values(ts=now)
+ engine.execute(insert_stmt)
console.print("Reading timestamp value...")
- stmt = select(table)
- row = engine.execute(stmt).fetchone()
+ select_stmt = select(table)
+ row = engine.execute(select_stmt).fetchone()
assert row[0] == now
console.print(":thumbs_up: [green]Success!")
except Exception as ex: # pylint: disable=broad-except
diff --git a/superset/db_engine_specs/lib.py b/superset/db_engine_specs/lib.py
index 2c7d3a3e62..4e9937c537 100644
--- a/superset/db_engine_specs/lib.py
+++ b/superset/db_engine_specs/lib.py
@@ -39,7 +39,6 @@ DATABASE_DETAILS = {
"subqueries": "Supports subqueries",
"alias_in_select": "Allows aliases in the SELECT statement",
"alias_in_orderby": "Allows referencing aliases in the ORDER BY statement",
- "secondary_time_columns": "Supports secondary time columns",
"time_groupby_inline": (
"Allows omitting time filters from inline GROUP BYs"
), # E: line too long (80 > 79 characters)
@@ -230,7 +229,6 @@ def generate_table() -> list[list[Any]]:
"subqueries",
"alias_in_select",
"alias_in_orderby",
- "secondary_time_columns",
"time_groupby_inline",
"alias_to_source_column",
"order_by_not_in_select",