You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@predictionio.apache.org by mars <gi...@git.apache.org> on 2017/07/18 02:09:28 UTC

[GitHub] incubator-predictionio issue #412: [PIO-105] Batch Predictions

Github user mars commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/412
  
    @takezoe thank you for the feedback. As a relatively-new Scala programmer I really appreciate this kind of review.
    
    I am a bit hesitant to make these changes. I'm trying to maintain likeness with the [`CreateServer.scala`](https://github.com/mars/incubator-predictionio/blob/e7c6ebd8cfe2d4a150319025876520fc39be9a34/core/src/main/scala/org/apache/predictionio/workflow/CreateServer.scala) code, to minimize differences in prediction behavior between `pio deploy` and `pio batchpredict`. Any of these stylistic points should probably be matched in CreateServer, so that it continues to be easy to reason about their similarity.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---