You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "P. Taylor Goetz" <pt...@gmail.com> on 2015/11/04 21:16:18 UTC
JStorm Code Import
Longda and JStorm team:
I’m working on importing the JStorm code into the Apache Storm repository and have a few comments/questions.
1) Currently the top-level pom.xml builds only the `jstorm-core` and `jstorm-ui` submodules. Can the other maven submodules be removed?
2) The `jstorm-on-yarn` module appears to be a direct copy of Yahoo’s `storm-yarn` project [1] with the packages renamed and the license headers removed. I will need to remove this.
3) The `jstorm-utility/toplogy-monitor` appears to be a copy of a repository belonging to dianping.com [2]. I will need to remove this as it is not covered by the software grant.
4) The `jstorm-utility/rocket-mq` module is a git submodule pointing to https://github.com/rocketmq/rocketmq-storm <https://github.com/rocketmq/rocketmq-storm>. I would like to remove it.
5) Overall, the `jstorm-utility` looks like it contains components that are add-ons not required for core functionality (and presumably why they are not part of the main build). I would like to remove that directory in the interest of focusing on merging the core functionality of the two codebases. Any useful integration/utility components can always be contributed at a later time.
Let me know if you have any opinions.
-Taylor
[1] https://github.com/yahoo/storm-yarn
[2] https://github.com/dianping/storm-util
Re: JStorm Code Import
Posted by "P. Taylor Goetz" <pt...@gmail.com>.
Thanks Bobby.
There have been a number of different approaches suggested across multiple email threads. I’m working on distilling those suggestions for a more focused discussion.
-Taylor
> On Nov 6, 2015, at 10:48 AM, Bobby Evans <ev...@yahoo-inc.com.INVALID> wrote:
>
> Great to hear it, now we need to come up with a plan/process for integrating the two.
> Taylor if you need/want any help with that plan please feel free to reach out to me.
>
> - Bobby
>
>
> On Thursday, November 5, 2015 3:47 PM, P. Taylor Goetz <pt...@gmail.com> wrote:
>
>
> The JStorm code has been imported into the “jstorm-import” branch, with commit history preserved.
>
> I added the following commits:
>
> * 27fb31c - remove netbeans configuration file
> * 75df7c2 - add missing Apache license headers
> * dbc1236 - remove IDE-specific project files
> * 5744ac3 - remove .gitmodules
> * e8f64d5 - remove jstorm-utility directory
> * e1f6844 - removed jstorm-on-yarn subdirectory
>
> In addition to what we discussed, I added the Apache license header to several files that were missing them. I also deleted several IDE-specific configuration files.
>
> I was able to build from source and run the unit tests successfully.
>
> -Taylor
>
>> On Nov 5, 2015, at 2:22 AM, 封仲淹(纪君祥LongdaFeng) <zh...@alibaba-inc.com> wrote:
>>
>> anser inline
>> RegardsLongda------------------------------------------------------------------From:P. Taylor Goetz <pt...@gmail.com>Send Time:2015年11月5日(星期四) 04:16To:dev <de...@storm.apache.org>Subject:JStorm Code Import
>> Longda and JStorm team:
>> I’m working on importing the JStorm code into the Apache Storm repository and have a few comments/questions.
>> 1) Currently the top-level pom.xml builds only the `jstorm-core` and `jstorm-ui` submodules. Can the other maven submodules be removed?［longda］ok, for the other module, just remove them right now. But I think the example is very useful, It provide a lot of scenario. later we will merge it into storm-starter.
>> 2) The `jstorm-on-yarn` module appears to be a direct copy of Yahoo’s `storm-yarn` project [1] with the packages renamed and the license headers removed. I will need to remove this.[longda] just remove it.
>> 3) The `jstorm-utility/toplogy-monitor` appears to be a copy of a repository belonging to dianping.com [2]. I will need to remove this as it is not covered by the software grant.[longda] just remove it right now, but this is a very useful monitor topology solution. the owner of the topology-monitor is a friend of mine, later if we need it, I will try to persuade dianping to donate it.
>> 4) The `jstorm-utility/rocket-mq` module is a git submodule pointing to https://github.com/rocketmq/rocketmq-storm. I would like to remove it.[longda] just remove it.
>> 5) Overall, the `jstorm-utility` looks like it contains components that are add-ons not required for core functionality (and presumably why they are not part of the main build). I would like to remove that directory in the interest of focusing on merging the core functionality of the two codebases. Any useful integration/utility components can always be contributed at a later time.［longda］ i agree with you, we can later contribute them if we need them.
>>
>> Let me know if you have any opinions.
>>
>> -Taylor
>>
>> [1] https://github.com/yahoo/storm-yarn[2] https://github.com/dianping/storm-util
>
>
Re: JStorm Code Import
Posted by Bobby Evans <ev...@yahoo-inc.com.INVALID>.
Great to hear it, now we need to come up with a plan/process for integrating the two.
Taylor if you need/want any help with that plan please feel free to reach out to me.
- Bobby
On Thursday, November 5, 2015 3:47 PM, P. Taylor Goetz <pt...@gmail.com> wrote:
The JStorm code has been imported into the “jstorm-import” branch, with commit history preserved.
I added the following commits:
* 27fb31c - remove netbeans configuration file
* 75df7c2 - add missing Apache license headers
* dbc1236 - remove IDE-specific project files
* 5744ac3 - remove .gitmodules
* e8f64d5 - remove jstorm-utility directory
* e1f6844 - removed jstorm-on-yarn subdirectory
In addition to what we discussed, I added the Apache license header to several files that were missing them. I also deleted several IDE-specific configuration files.
I was able to build from source and run the unit tests successfully.
-Taylor
> On Nov 5, 2015, at 2:22 AM, 封仲淹(纪君祥LongdaFeng) <zh...@alibaba-inc.com> wrote:
>
> anser inline
> RegardsLongda------------------------------------------------------------------From:P. Taylor Goetz <pt...@gmail.com>Send Time:2015年11月5日(星期四) 04:16To:dev <de...@storm.apache.org>Subject:JStorm Code Import
> Longda and JStorm team:
> I’m working on importing the JStorm code into the Apache Storm repository and have a few comments/questions.
> 1) Currently the top-level pom.xml builds only the `jstorm-core` and `jstorm-ui` submodules. Can the other maven submodules be removed?［longda］ok, for the other module, just remove them right now. But I think the example is very useful, It provide a lot of scenario. later we will merge it into storm-starter.
> 2) The `jstorm-on-yarn` module appears to be a direct copy of Yahoo’s `storm-yarn` project [1] with the packages renamed and the license headers removed. I will need to remove this.[longda] just remove it.
> 3) The `jstorm-utility/toplogy-monitor` appears to be a copy of a repository belonging to dianping.com [2]. I will need to remove this as it is not covered by the software grant.[longda] just remove it right now, but this is a very useful monitor topology solution. the owner of the topology-monitor is a friend of mine, later if we need it, I will try to persuade dianping to donate it.
> 4) The `jstorm-utility/rocket-mq` module is a git submodule pointing to https://github.com/rocketmq/rocketmq-storm. I would like to remove it.[longda] just remove it.
> 5) Overall, the `jstorm-utility` looks like it contains components that are add-ons not required for core functionality (and presumably why they are not part of the main build). I would like to remove that directory in the interest of focusing on merging the core functionality of the two codebases. Any useful integration/utility components can always be contributed at a later time.［longda］ i agree with you, we can later contribute them if we need them.
>
> Let me know if you have any opinions.
>
> -Taylor
>
> [1] https://github.com/yahoo/storm-yarn[2] https://github.com/dianping/storm-util
Re: JStorm Code Import
Posted by "P. Taylor Goetz" <pt...@gmail.com>.
The JStorm code has been imported into the “jstorm-import” branch, with commit history preserved.
I added the following commits:
* 27fb31c - remove netbeans configuration file
* 75df7c2 - add missing Apache license headers
* dbc1236 - remove IDE-specific project files
* 5744ac3 - remove .gitmodules
* e8f64d5 - remove jstorm-utility directory
* e1f6844 - removed jstorm-on-yarn subdirectory
In addition to what we discussed, I added the Apache license header to several files that were missing them. I also deleted several IDE-specific configuration files.
I was able to build from source and run the unit tests successfully.
-Taylor
> On Nov 5, 2015, at 2:22 AM, 封仲淹(纪君祥LongdaFeng) <zh...@alibaba-inc.com> wrote:
>
> anser inline
> RegardsLongda------------------------------------------------------------------From:P. Taylor Goetz <pt...@gmail.com>Send Time:2015年11月5日(星期四) 04:16To:dev <de...@storm.apache.org>Subject:JStorm Code Import
> Longda and JStorm team:
> I’m working on importing the JStorm code into the Apache Storm repository and have a few comments/questions.
> 1) Currently the top-level pom.xml builds only the `jstorm-core` and `jstorm-ui` submodules. Can the other maven submodules be removed?［longda］ok, for the other module, just remove them right now. But I think the example is very useful, It provide a lot of scenario. later we will merge it into storm-starter.
> 2) The `jstorm-on-yarn` module appears to be a direct copy of Yahoo’s `storm-yarn` project [1] with the packages renamed and the license headers removed. I will need to remove this.[longda] just remove it.
> 3) The `jstorm-utility/toplogy-monitor` appears to be a copy of a repository belonging to dianping.com [2]. I will need to remove this as it is not covered by the software grant.[longda] just remove it right now, but this is a very useful monitor topology solution. the owner of the topology-monitor is a friend of mine, later if we need it, I will try to persuade dianping to donate it.
> 4) The `jstorm-utility/rocket-mq` module is a git submodule pointing to https://github.com/rocketmq/rocketmq-storm. I would like to remove it.[longda] just remove it.
> 5) Overall, the `jstorm-utility` looks like it contains components that are add-ons not required for core functionality (and presumably why they are not part of the main build). I would like to remove that directory in the interest of focusing on merging the core functionality of the two codebases. Any useful integration/utility components can always be contributed at a later time.［longda］ i agree with you, we can later contribute them if we need them.
>
> Let me know if you have any opinions.
>
> -Taylor
>
> [1] https://github.com/yahoo/storm-yarn[2] https://github.com/dianping/storm-util
Re: JStorm Code Import
Posted by "封仲淹(纪君祥LongdaFeng)" <zh...@alibaba-inc.com>.
anser inline
RegardsLongda------------------------------------------------------------------From:P. Taylor Goetz <pt...@gmail.com>Send Time:2015年11月5日(星期四) 04:16To:dev <de...@storm.apache.org>Subject:JStorm Code Import
Longda and JStorm team:
I’m working on importing the JStorm code into the Apache Storm repository and have a few comments/questions.
1) Currently the top-level pom.xml builds only the `jstorm-core` and `jstorm-ui` submodules. Can the other maven submodules be removed?［longda］ok, for the other module, just remove them right now. But I think the example is very useful, It provide a lot of scenario. later we will merge it into storm-starter.
2) The `jstorm-on-yarn` module appears to be a direct copy of Yahoo’s `storm-yarn` project [1] with the packages renamed and the license headers removed. I will need to remove this.[longda] just remove it.
3) The `jstorm-utility/toplogy-monitor` appears to be a copy of a repository belonging to dianping.com [2]. I will need to remove this as it is not covered by the software grant.[longda] just remove it right now, but this is a very useful monitor topology solution. the owner of the topology-monitor is a friend of mine, later if we need it, I will try to persuade dianping to donate it.
4) The `jstorm-utility/rocket-mq` module is a git submodule pointing to https://github.com/rocketmq/rocketmq-storm. I would like to remove it.[longda] just remove it.
5) Overall, the `jstorm-utility` looks like it contains components that are add-ons not required for core functionality (and presumably why they are not part of the main build). I would like to remove that directory in the interest of focusing on merging the core functionality of the two codebases. Any useful integration/utility components can always be contributed at a later time.［longda］ i agree with you, we can later contribute them if we need them.
Let me know if you have any opinions.
-Taylor
[1] https://github.com/yahoo/storm-yarn[2] https://github.com/dianping/storm-util