You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Hudson <gh...@MIT.EDU> on 2002/01/21 20:18:28 UTC
Spaces for function calls (was Re: [PATCH] fix for issue #591)
On Mon, 2002-01-21 at 13:36, Karl Fogel wrote:
> Actually Sander, the predominant style is with the space, and some
> code (e.g., libsvn_ra_dav and mod_dav_svn) leave the space out,
> because the primary author there (gstein) *hates* the space. :-)
I sometimes wonder if anyone really likes the space. In my work
environment, we use the Gnu coding style guidelines, but we punt the
space because (a) it's annoying, and (b) it makes it a little harder to
distinguish control-flow statements from function calls.
Well, water under the bridge at this point.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Spaces for function calls
Posted by cm...@collab.net.
Greg Stein <gs...@lyra.org> writes:
> Who besides Karl *likes* them? Ben? Mike?
>
> Is Karl the only holdout?
I like them, as part of a general pleasure gained in seeing code with
whitespace. It's the same reason I like:
for
{
...
}
instead of:
for {
...
}
and:
do
{
...
}
while;
rather than:
do {
...
} while;
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Spaces for function calls
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On Mon, Jan 21, 2002 at 04:28:18PM -0600, Karl Fogel wrote:
> Garrett Rooney <ro...@electricjellyfish.net> writes:
> > you guys are just plain weird...
>
> :-)
>
> > (who has to go over every patch he sends to make sure he remembers the
> > damn space, and still forgets every now and then.)
>
> Yeah, I forget to omit the space in the dav code too, sometimes. But
> consistency helps readability, so it's worth it (within a given file)
> to be consistent.
oh, so you're the one who left those spaces in the ra_dav code that
were confusing me as to the expected style there...
damn 'space before the paren people'... can't be satisfied having
their section of the code being all ugly, they have to dirty up the
nice parts of the tree...
;-)
> Of course, it's not a showstopper if something gets committed without
> the space. It can always be fixed up later.
yeah, that's true.
-garrett
--
garrett rooney Unix was not designed to stop you from
rooneg@electricjellyfish.net doing stupid things, because that would
http://electricjellyfish.net/ stop you from doing clever things.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Spaces for function calls
Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Garrett Rooney <ro...@electricjellyfish.net> writes:
> you guys are just plain weird...
:-)
> (who has to go over every patch he sends to make sure he remembers the
> damn space, and still forgets every now and then.)
Yeah, I forget to omit the space in the dav code too, sometimes. But
consistency helps readability, so it's worth it (within a given file)
to be consistent.
Of course, it's not a showstopper if something gets committed without
the space. It can always be fixed up later.
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Spaces for function calls
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On Mon, Jan 21, 2002 at 03:59:18PM -0600, Ben Collins-Sussman wrote:
> Greg Stein <gs...@lyra.org> writes:
>
> > Who besides Karl *likes* them? Ben? Mike?
> >
> > Is Karl the only holdout?
>
> I love them too!
you guys are just plain weird...
-garrett
(who has to go over every patch he sends to make sure he remembers the
damn space, and still forgets every now and then.)
--
garrett rooney Unix was not designed to stop you from
rooneg@electricjellyfish.net doing stupid things, because that would
http://electricjellyfish.net/ stop you from doing clever things.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Spaces for function calls
Posted by Ben Collins-Sussman <su...@collab.net>.
Greg Stein <gs...@lyra.org> writes:
> Who besides Karl *likes* them? Ben? Mike?
>
> Is Karl the only holdout?
I love them too!
Are we gonna start a war? ;-)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Spaces for function calls
Posted by Greg Stein <gs...@lyra.org>.
On Mon, Jan 21, 2002 at 03:57:58PM -0600, Karl Fogel wrote:
> Greg Hudson <gh...@MIT.EDU> writes:
> > I sometimes wonder if anyone really likes the space. In my work
> > environment, we use the Gnu coding style guidelines, but we punt the
> > space because (a) it's annoying, and (b) it makes it a little harder to
> > distinguish control-flow statements from function calls.
>
> I do, so there's some sort of existence proof for you. :-)
Who besides Karl *likes* them? Ben? Mike?
Is Karl the only holdout?
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Spaces for function calls (was Re: [PATCH] fix for issue #591)
Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Greg Hudson <gh...@MIT.EDU> writes:
> I sometimes wonder if anyone really likes the space. In my work
> environment, we use the Gnu coding style guidelines, but we punt the
> space because (a) it's annoying, and (b) it makes it a little harder to
> distinguish control-flow statements from function calls.
I do, so there's some sort of existence proof for you. :-)
> Well, water under the bridge at this point.
Yup.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org