You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/01 03:09:49 UTC

[GitHub] [kafka] guozhangwang opened a new pull request #9358: MINOR: Refactor unit tests around RocksDBConfigSetter

guozhangwang opened a new pull request #9358:
URL: https://github.com/apache/kafka/pull/9358


   1. Extract the mock RocksDBConfigSetter into a separate class.
   2. De-dup unit tests covering RocksDBConfigSetter.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on pull request #9358: MINOR: Refactor unit tests around RocksDBConfigSetter

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #9358:
URL: https://github.com/apache/kafka/pull/9358#issuecomment-701817991


   I created this PR mainly to illustrate that one can pass in shared object or configurable values to the setter as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang merged pull request #9358: MINOR: Refactor unit tests around RocksDBConfigSetter

Posted by GitBox <gi...@apache.org>.
guozhangwang merged pull request #9358:
URL: https://github.com/apache/kafka/pull/9358


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on a change in pull request #9358: MINOR: Refactor unit tests around RocksDBConfigSetter

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on a change in pull request #9358:
URL: https://github.com/apache/kafka/pull/9358#discussion_r497959829



##########
File path: streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java
##########
@@ -297,9 +298,21 @@ public void shouldNotThrowExceptionOnRestoreWhenThereIsPreExistingRocksDbFiles()
     public void shouldCallRocksDbConfigSetter() {
         MockRocksDbConfigSetter.called = false;
 
+        final Properties props = StreamsTestUtils.getStreamsConfig();

Review comment:
       This is to illustrate the usage of passing in any user-customized configurable value or shared objects to the setter. @rodesai @brianbushree 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on pull request #9358: MINOR: Refactor unit tests around RocksDBConfigSetter

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #9358:
URL: https://github.com/apache/kafka/pull/9358#issuecomment-702452211


   test this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on pull request #9358: MINOR: Refactor unit tests around RocksDBConfigSetter

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #9358:
URL: https://github.com/apache/kafka/pull/9358#issuecomment-704386882


   Thanks @abbccdda for the reviews!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org