You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "ikun-Lg (via GitHub)" <gi...@apache.org> on 2024/11/10 12:49:56 UTC

[PR] Make the fields of mock JS simulated data consistent with the real interface. [dubbo-kubernetes]

ikun-Lg opened a new pull request, #500:
URL: https://github.com/apache/dubbo-kubernetes/pull/500

   ## What is the purpose of the change
   The aim is to ensure that the fields of mock JS simulated data precisely match those of the real interface. This will enhance the accuracy and reliability of testing and development processes by providing a more realistic simulation environment.
   
   ## Brief changelog
   Updated the fields of mock JS simulated data to conform to the real interface.
   
   ## Verifying this change
   
   
   <!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
   
   ## CheckList
   - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo-kubernetes/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
   - [ ] Each commit in the pull request should have a meaningful subject line and body.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. 
   - [ ] GitHub Actions works fine on your own branch.
   - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Make the fields of mock JS simulated data consistent with the real interface. [dubbo-kubernetes]

Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj merged PR #500:
URL: https://github.com/apache/dubbo-kubernetes/pull/500


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Make the fields of mock JS simulated data consistent with the real interface. [dubbo-kubernetes]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #500:
URL: https://github.com/apache/dubbo-kubernetes/pull/500#issuecomment-2466724597

   ## [Codecov](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/500?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 14.74%. Comparing base [(`950f2aa`)](https://app.codecov.io/gh/apache/dubbo-kubernetes/commit/950f2aa0135e9de802f7fb0b50f8586cdb06b9c6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`cc9b87d`)](https://app.codecov.io/gh/apache/dubbo-kubernetes/commit/cc9b87d0dd5d7e634ddbe1905d2533d9313c81a9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 88 commits behind head on master.
   
   > :exclamation: **Current head cc9b87d differs from pull request most recent head 2ee99ea**
   > 
   > Please [upload](https://docs.codecov.com/docs/codecov-uploader) reports for the commit 2ee99ea to get more accurate results.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff             @@
   ##           master     #500       +/-   ##
   ===========================================
   - Coverage   33.54%   14.74%   -18.80%     
   ===========================================
     Files         160      590      +430     
     Lines        9474    30300    +20826     
     Branches       41       41               
   ===========================================
   + Hits         3178     4468     +1290     
   - Misses       5955    25338    +19383     
   - Partials      341      494      +153     
   ```
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/500?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org