You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/06/12 14:02:17 UTC
[GitHub] [spark] tgravescs commented on a change in pull request #24841:
[SPARK-27369][CORE] Setup resources when Standalone Worker starts up
tgravescs commented on a change in pull request #24841: [SPARK-27369][CORE] Setup resources when Standalone Worker starts up
URL: https://github.com/apache/spark/pull/24841#discussion_r292922457
##########
File path: core/src/main/scala/org/apache/spark/deploy/worker/WorkerArguments.scala
##########
@@ -36,6 +36,8 @@ private[worker] class WorkerArguments(args: Array[String], conf: SparkConf) {
var memory = inferDefaultMemory()
var masters: Array[String] = null
var workDir: String = null
+ var resourceFile: Option[String] = None
+ var resourceDiscoveryScript: Map[String, String] = Map()
Review comment:
= Map.empty might be more clear that this is immutable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org