[GitHub] nickva commented on a change in pull request #830: Make stats interval into config parameter

[gi...@git.apache.org]

nickva commented on a change in pull request #830: Make stats interval into config parameter
URL: https://github.com/apache/couchdb/pull/830#discussion_r140847785
 
 

 ##########
 File path: src/couch_stats/src/couch_stats_aggregator.erl
 ##########
 @@ -30,6 +30,10 @@
     terminate/2
 ]).
 
+
+-define(DEFAULT_INTERVAL, 10).
 
 Review comment:
   The default is repeated in couch_stats.erl as well. Is it worth making an API call in couch_stats which gets the interval and is the only place that knows about the default?
   
   ```
   collect_interval_sec() ->
         config:get_integer("stats", "interval", ?DEFAULT_INTERVAL).
   ```
   
   Then aggregator can call that  to get the interval for the histogram?
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services