You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/13 18:14:38 UTC
[GitHub] [pulsar-site] heesung-sn opened a new pull request, #111: Recommitted the dropped instruction, CI Testing in your Fork
heesung-sn opened a new pull request, #111:
URL: https://github.com/apache/pulsar-site/pull/111
This was originally approved by https://github.com/apache/pulsar/pull/15535.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet merged pull request #111: Recommitted the dropped instruction, CI Testing in your Fork
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged PR #111:
URL: https://github.com/apache/pulsar-site/pull/111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] heesung-sn commented on pull request #111: Recommitted the dropped instruction, CI Testing in your Fork
Posted by GitBox <gi...@apache.org>.
heesung-sn commented on PR #111:
URL: https://github.com/apache/pulsar-site/pull/111#issuecomment-1155557678
> Thanks for your contribution! Have you previewed your changes to ensure everything goes as expected?
>
> If not yet, please [preview your changes locally](https://github.com/apache/pulsar-site/tree/main/site2/website-next#local-preview) and attach the screenshots in the PR description to let others know. In this way, you can get your PR merged more quickly. Thanks!
I added the preview to the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet commented on pull request #111: Recommitted the dropped instruction, CI Testing in your Fork
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #111:
URL: https://github.com/apache/pulsar-site/pull/111#issuecomment-1154810906
Thanks for your contribution! Have you previewed your changes to ensure everything goes as expected?
If not yet, please [preview your changes locally](https://github.com/apache/pulsar-site/tree/main/site2/website-next#local-preview) and attach the screenshots in the PR description to let others know. In this way, you can get your PR merged more quickly. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #111: Recommitted the dropped instruction, CI Testing in your Fork
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #111:
URL: https://github.com/apache/pulsar-site/pull/111#discussion_r896440054
##########
site2/website-next/src/pages/contributing.md:
##########
@@ -156,6 +156,97 @@ Then you can push your local, committed changes to your (forked) repository on G
All code should have appropriate unit testing coverage. New code should have new tests in the same contribution. Bug fixes should include a regression test to prevent the issue from reoccurring.
+### CI Testing in your Fork
+
+The following is copied from the
+[thread](https://lists.apache.org/thread/1ofdbd9j1hhj4c0rw3o7vv8y6rbsxrp0) and [#15385](https://github.com/apache/pulsar/pull/15385).
+
+
+#### Each PR triggers many CI Jobs
+Since we cannot add more resources to Pulsar CI, we need to find other ways
+to reduce the load on Pulsar CI.
+Every developer can help reduce the load on Pulsar CI.
+Please don't open a PR to apache/pulsar when the work is in very initial
+stages.
+Every push to the pull request branch will trigger a lot of concurrent
+builds (about 25).
+By reducing the amount of PR pushes you can reduce the load on Pulsar CI.
+
+#### Run CI from Fork
+You don't have to stop developing and using CI for getting feedback. There
+is a better way to get CI feedback for early stages of development. The
+secret is that everyone has their personal CI on GitHub!
Review Comment:
@maxsxu FYI
##########
site2/website-next/src/pages/contributing.md:
##########
@@ -156,6 +156,97 @@ Then you can push your local, committed changes to your (forked) repository on G
All code should have appropriate unit testing coverage. New code should have new tests in the same contribution. Bug fixes should include a regression test to prevent the issue from reoccurring.
+### CI Testing in your Fork
+
+The following is copied from the
+[thread](https://lists.apache.org/thread/1ofdbd9j1hhj4c0rw3o7vv8y6rbsxrp0) and [#15385](https://github.com/apache/pulsar/pull/15385).
+
+
+#### Each PR triggers many CI Jobs
+Since we cannot add more resources to Pulsar CI, we need to find other ways
Review Comment:
@maxsxu FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] urfreespace commented on pull request #111: Recommitted the dropped instruction, CI Testing in your Fork
Posted by GitBox <gi...@apache.org>.
urfreespace commented on PR #111:
URL: https://github.com/apache/pulsar-site/pull/111#issuecomment-1154603295
@Anonymitaet PTAL, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org