You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stu Hood (JIRA)" <ji...@apache.org> on 2011/05/13 23:34:48 UTC
[jira] [Created] (CASSANDRA-2650) AntiEntropyServiceCounterTest
writes CounterUpdateColumn to disk
AntiEntropyServiceCounterTest writes CounterUpdateColumn to disk
----------------------------------------------------------------
Key: CASSANDRA-2650
URL: https://issues.apache.org/jira/browse/CASSANDRA-2650
Project: Cassandra
Issue Type: Test
Components: Tests
Reporter: Stu Hood
Priority: Minor
Fix For: 1.0
By using an unwrapped RowMutation to apply a counter update, AESCT was applying/flushing a CounterUpdateColumn to disk. I'm still not a fan of the magic that is going on with CUC, but for now fixing misuses is the most reasonable approach.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2650) Tests write CounterUpdateColumns
to disk
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-2650:
--------------------------------
Summary: Tests write CounterUpdateColumns to disk (was: AntiEntropyServiceCounterTest writes CounterUpdateColumn to disk)
> Tests write CounterUpdateColumns to disk
> ----------------------------------------
>
> Key: CASSANDRA-2650
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2650
> Project: Cassandra
> Issue Type: Test
> Components: Tests
> Reporter: Stu Hood
> Assignee: Stu Hood
> Priority: Minor
> Labels: counters
> Fix For: 1.0
>
> Attachments: 0001-Make-IMutation-more-uniform-and-apply-IMutation-in-Uti.txt
>
>
> By using an unwrapped RowMutation to apply a counter update, AESCT was applying/flushing a CounterUpdateColumn to disk. I'm still not a fan of the magic that is going on with CUC, but for now fixing misuses is the most reasonable approach.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2650) AntiEntropyServiceCounterTest
writes CounterUpdateColumn to disk
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043219#comment-13043219 ]
Stu Hood commented on CASSANDRA-2650:
-------------------------------------
Just noticed this issue is still open, which is helpful, because I found a new instance of the problem: {{db.RecoveryManagerTest.testRecoverCounter}} is writing a CounterColumn without using CounterMutation.
> AntiEntropyServiceCounterTest writes CounterUpdateColumn to disk
> ----------------------------------------------------------------
>
> Key: CASSANDRA-2650
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2650
> Project: Cassandra
> Issue Type: Test
> Components: Tests
> Reporter: Stu Hood
> Assignee: Stu Hood
> Priority: Minor
> Labels: counters
> Fix For: 1.0
>
> Attachments: 0001-Make-IMutation-more-uniform-and-apply-IMutation-in-Uti.txt
>
>
> By using an unwrapped RowMutation to apply a counter update, AESCT was applying/flushing a CounterUpdateColumn to disk. I'm still not a fan of the magic that is going on with CUC, but for now fixing misuses is the most reasonable approach.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2650) AntiEntropyServiceCounterTest
writes CounterUpdateColumn to disk
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037899#comment-13037899 ]
Hudson commented on CASSANDRA-2650:
-----------------------------------
Integrated in Cassandra-0.8 #123 (See [https://builds.apache.org/hudson/job/Cassandra-0.8/123/])
Don't write CounterUpdateColumn to disk in tests
patch by stuhood; reviewed by slebresne for CASSANDRA-2650
slebresne : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1126416
Files :
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/RowMutation.java
* /cassandra/branches/cassandra-0.8/test/unit/org/apache/cassandra/service/AntiEntropyServiceTestAbstract.java
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/IMutation.java
* /cassandra/branches/cassandra-0.8/test/unit/org/apache/cassandra/Util.java
* /cassandra/branches/cassandra-0.8/CHANGES.txt
* /cassandra/branches/cassandra-0.8/test/unit/org/apache/cassandra/service/AntiEntropyServiceStandardTest.java
* /cassandra/branches/cassandra-0.8/test/unit/org/apache/cassandra/db/ColumnFamilyStoreTest.java
* /cassandra/branches/cassandra-0.8/test/unit/org/apache/cassandra/service/AntiEntropyServiceCounterTest.java
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/CounterMutation.java
> AntiEntropyServiceCounterTest writes CounterUpdateColumn to disk
> ----------------------------------------------------------------
>
> Key: CASSANDRA-2650
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2650
> Project: Cassandra
> Issue Type: Test
> Components: Tests
> Reporter: Stu Hood
> Assignee: Stu Hood
> Priority: Minor
> Labels: counters
> Fix For: 1.0
>
> Attachments: 0001-Make-IMutation-more-uniform-and-apply-IMutation-in-Uti.txt
>
>
> By using an unwrapped RowMutation to apply a counter update, AESCT was applying/flushing a CounterUpdateColumn to disk. I'm still not a fan of the magic that is going on with CUC, but for now fixing misuses is the most reasonable approach.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-2650) Tests write CounterUpdateColumns
to disk
Posted by "Sylvain Lebresne (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne resolved CASSANDRA-2650.
-----------------------------------------
Resolution: Fixed
Time to close this one.
I don't see the RecoveryManagerTest.testRecoverCounter instance a a real problem since it doesn't write a CounterUpdateColumn (or it was, it has been fixed). Agreed it doesn't use a CounterMutation but given the test, why should it bother.
> Tests write CounterUpdateColumns to disk
> ----------------------------------------
>
> Key: CASSANDRA-2650
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2650
> Project: Cassandra
> Issue Type: Test
> Components: Tests
> Reporter: Stu Hood
> Assignee: Stu Hood
> Priority: Minor
> Labels: counters
> Attachments: 0001-Make-IMutation-more-uniform-and-apply-IMutation-in-Uti.txt
>
>
> By using an unwrapped RowMutation to apply a counter update, AESCT was applying/flushing a CounterUpdateColumn to disk. I'm still not a fan of the magic that is going on with CUC, but for now fixing misuses is the most reasonable approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2650) AntiEntropyServiceCounterTest
writes CounterUpdateColumn to disk
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-2650:
--------------------------------
Attachment: 0001-Make-IMutation-more-uniform-and-apply-IMutation-in-Uti.txt
> AntiEntropyServiceCounterTest writes CounterUpdateColumn to disk
> ----------------------------------------------------------------
>
> Key: CASSANDRA-2650
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2650
> Project: Cassandra
> Issue Type: Test
> Components: Tests
> Reporter: Stu Hood
> Priority: Minor
> Labels: counters
> Fix For: 1.0
>
> Attachments: 0001-Make-IMutation-more-uniform-and-apply-IMutation-in-Uti.txt
>
>
> By using an unwrapped RowMutation to apply a counter update, AESCT was applying/flushing a CounterUpdateColumn to disk. I'm still not a fan of the magic that is going on with CUC, but for now fixing misuses is the most reasonable approach.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira