[PATCH] Provide support for the HTTPS url

[Bhuvaneswaran Arumugam <bh...@collab.net>]

Hello,

Please find attached the patch.
Provide support for the HTTPS url and few more enhancements.

[[
Patch by: Bhuvaneswaran Arumugam <bh...@collab.net>

* tools/client-side/server-vsn.py
  (global): Do not import "string" library when it is not necessary and
  indent the script to 4 whitespaces.
  (print_version): Handle the HTTPS url. In httplib, the HTTP and HTTPS 
  functions are included just for backward compatibility. Moreover,
  HTTPS support is only available if the socket module is compiled with
  SSL support. So, use HTTPConnection and HTTPSConnection functions
  instead.

  Handle redirect requests (302), if the requested resource resides
  temporarily under a different URL.
]]

In addition, i suggest to rename this script as server-version.py as it
makes more sense, imo.
-- 
Regards,
Bhuvaneswaran

Re: [PATCH] Provide support for the HTTPS url

[Daniel Rall <dl...@collab.net>]

On Sat, 29 Jul 2006, Julian Foad wrote:
...
> >In addition, i suggest to rename this script as server-version.py as it
> >makes more sense, imo.
> 
> Yes, I agree that would be better: "vsn" is not a common abbreviation of 
> "version".  I will wait and see if anyone agrees or thinks we would need to 
> leave some kind of link under the old name.

Ick, "vsn" is supposed to mean "version"?  +1 on renaming the script.

Re: [PATCH] Provide support for the HTTPS url

[Julian Foad <ju...@btopenworld.com>]

Bhuvaneswaran Arumugam wrote:
> Provide support for the HTTPS url and few more enhancements.
> 
> [[
> Patch by: Bhuvaneswaran Arumugam <bh...@collab.net>
> 
> * tools/client-side/server-vsn.py
>   (global): Do not import "string" library when it is not necessary and
>   indent the script to 4 whitespaces.
>   (print_version): Handle the HTTPS url. In httplib, the HTTP and HTTPS 
>   functions are included just for backward compatibility. Moreover,
>   HTTPS support is only available if the socket module is compiled with
>   SSL support. So, use HTTPConnection and HTTPSConnection functions
>   instead.
> 
>   Handle redirect requests (302), if the requested resource resides
>   temporarily under a different URL.
> ]]

Thank you for this patch.

I have committed it in 20902, except for the indentation change.  We try to 
keep wide-ranging whitespace changes separate from functional changes.  In this 
case, I can't see the reason for changing it: it appears that more of our 
Python scripts use 2-space indentation than 4-space indentation.

> In addition, i suggest to rename this script as server-version.py as it
> makes more sense, imo.

Yes, I agree that would be better: "vsn" is not a common abbreviation of 
"version".  I will wait and see if anyone agrees or thinks we would need to 
leave some kind of link under the old name.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Provide support for the HTTPS url

[Max Bowsher <ma...@ukf.net>]

Bhuvaneswaran Arumugam wrote:
> Hello,
> 
> Please find attached the patch.
> Provide support for the HTTPS url and few more enhancements.
> 
> [[
> Patch by: Bhuvaneswaran Arumugam <bh...@collab.net>
> 
> * tools/client-side/server-vsn.py
>   (global): Do not import "string" library when it is not necessary and
>   indent the script to 4 whitespaces.
>   (print_version): Handle the HTTPS url. In httplib, the HTTP and HTTPS 
>   functions are included just for backward compatibility. Moreover,
>   HTTPS support is only available if the socket module is compiled with
>   SSL support. So, use HTTPConnection and HTTPSConnection functions
>   instead.
> 
>   Handle redirect requests (302), if the requested resource resides
>   temporarily under a different URL.

Surely 301, 303 and 307 codes should be handled equivalently here too?

Max.