You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "rickyma (via GitHub)" <gi...@apache.org> on 2023/09/12 12:25:55 UTC
[GitHub] [spark] rickyma opened a new pull request, #42890: [SPARK-25689][YARN][FOLLOWUP] Add a missing argument usage description for ApplicationMasterArguments
rickyma opened a new pull request, #42890:
URL: https://github.com/apache/spark/pull/42890
A followup PR for [SPARK-25689](https://github.com/apache/spark/pull/23338)
https://github.com/apache/spark/pull/23338/files#diff-dbb471beb8bb44a98a65b56f069c5d6abb74141073c97b9f5256c971164aedbdR66
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] rickyma commented on pull request #42890: [SPARK-25689][YARN][FOLLOWUP] Add a missing argument usage description for ApplicationMasterArguments
Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #42890:
URL: https://github.com/apache/spark/pull/42890#issuecomment-1716862598
### What changes were proposed in this pull request?
This pull request adds a missing argument usage description for ApplicationMasterArguments.
### Why are the changes needed?
PR for SPARK-25689 missed the description for argument "--dist-cache-conf" in ApplicationMasterArguments.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
This commit doesn't need to be tested. It only affects the usage log.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-25689][YARN][FOLLOWUP] Add a missing argument usage description for ApplicationMasterArguments [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42890:
URL: https://github.com/apache/spark/pull/42890#issuecomment-1870709003
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #42890: [SPARK-25689][YARN][FOLLOWUP] Add a missing argument usage description for ApplicationMasterArguments
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42890:
URL: https://github.com/apache/spark/pull/42890#issuecomment-1716803030
cc @vanzin and @squito
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-25689][YARN][FOLLOWUP] Add a missing argument usage description for ApplicationMasterArguments [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #42890: [SPARK-25689][YARN][FOLLOWUP] Add a missing argument usage description for ApplicationMasterArguments
URL: https://github.com/apache/spark/pull/42890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] rickyma commented on pull request #42890: [SPARK-25689][YARN][FOLLOWUP] Add a missing argument usage description for ApplicationMasterArguments
Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #42890:
URL: https://github.com/apache/spark/pull/42890#issuecomment-1715637479
This commit doesn't need to be tested. It only affects the usage log.
cc @itholic @zhengruifeng @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #42890: [SPARK-25689][YARN][FOLLOWUP] Add a missing argument usage description for ApplicationMasterArguments
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #42890:
URL: https://github.com/apache/spark/pull/42890#issuecomment-1716781973
Thanks for your first contribution to Apache Spark :-)
Could you fill up the PR description according to the [PR template](https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE) to make it clear what you did?
You can also refer to [Contributing to Spark](https://spark.apache.org/contributing.html) if you want to find more detail about the contribution for Apache Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] rickyma commented on pull request #42890: [SPARK-25689][YARN][FOLLOWUP] Add a missing argument usage description for ApplicationMasterArguments
Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #42890:
URL: https://github.com/apache/spark/pull/42890#issuecomment-1716863166
@itholic I've filled up the PR description already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #42890: [SPARK-25689][YARN][FOLLOWUP] Add a missing argument usage description for ApplicationMasterArguments
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #42890:
URL: https://github.com/apache/spark/pull/42890#issuecomment-1720903171
Actually I'm not very used to yarn cluster, so we might need a review from who has enough context for this (maybe @vanzin and @squito one of them?).
Otherwise, can you give me a more context for this PR? What is the major difference or benefit after this PR compare to the current status??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] rickyma commented on pull request #42890: [SPARK-25689][YARN][FOLLOWUP] Add a missing argument usage description for ApplicationMasterArguments
Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #42890:
URL: https://github.com/apache/spark/pull/42890#issuecomment-1720787138
@itholic @HyukjinKwon Hey, can you guys merge this? This pull request doesn't need to be tested. Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] rickyma commented on pull request #42890: [SPARK-25689][YARN][FOLLOWUP] Add a missing argument usage description for ApplicationMasterArguments
Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #42890:
URL: https://github.com/apache/spark/pull/42890#issuecomment-1722877132
hey @vanzin @squito, could you please have a look at this PR? It is a follow-up PR for [SPARK-25689](https://issues.apache.org/jira/browse/SPARK-25689).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org