You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by "chenBright (via GitHub)" <gi...@apache.org> on 2023/02/04 07:38:08 UTC

[GitHub] [brpc] chenBright opened a new pull request, #2108: check invalid port

chenBright opened a new pull request, #2108:
URL: https://github.com/apache/brpc/pull/2108

   ### What problem does this PR solve?
   
   Issue Number:
   
   Problem Summary: 目前未判断PortRange和internal_port的合法性，即使实际的port大于65535（不合法的port），Server::Start()也会返回成功。
   
   ### What is changed and the side effects?
   
   Changed: 检查PortRange和internal_port是否合法，不合法则返回-1表示失败。
   
   Side effects:
   - Performance effects(性能影响):
   
   - Breaking backward compatibility(向后兼容性): 
   
   ---
   ### Check List:
   - Please make sure your changes are compilable(请确保你的更改可以通过编译).
   - When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
   - Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [brpc] wwbmmm merged pull request #2108: check invalid port

Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm merged PR #2108:
URL: https://github.com/apache/brpc/pull/2108


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org