[GitHub] spark pull request #17849: [SPARK-10931][ML][PYSPARK] PySpark Models Copy Pa...

[BryanCutler <gi...@git.apache.org>]

Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17849#discussion_r132330891
  
    --- Diff: python/pyspark/ml/wrapper.py ---
    @@ -263,7 +284,8 @@ def _fit_java(self, dataset):
     
         def _fit(self, dataset):
             java_model = self._fit_java(dataset)
    -        return self._create_model(java_model)
    +        model = self._create_model(java_model)
    +        return self._copyValues(model)
    --- End diff --
    
    This is the crucial line being added in this PR.  Without this, if a Python model defines a param (matching one from Scala), then when the model is fit in Scala that param value will never be sent back to Python.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org