[GitHub] [nifi] jfrazee commented on a change in pull request #5226: NIFI-8784 Make NIFI_WEB_PROXY_HOST work with single user auth

[GitBox <gi...@apache.org>]

jfrazee commented on a change in pull request #5226:
URL: https://github.com/apache/nifi/pull/5226#discussion_r672297689



##########
File path: nifi-docker/dockermaven/sh/start.sh
##########
@@ -66,6 +67,15 @@ if [ -n "${NIFI_WEB_HTTP_PORT}" ]; then
     prop_replace 'truststore'                                 '' ${nifi_toolkit_props_file}
     prop_replace 'truststoreType'                             '' ${nifi_toolkit_props_file}
     prop_replace 'baseUrl' "http://${NIFI_WEB_HTTP_HOST:-$HOSTNAME}:${NIFI_WEB_HTTP_PORT}" ${nifi_toolkit_props_file}
+
+    if [ -n "${NIFI_WEB_PROXY_HOST}" ]; then
+        echo 'NIFI_WEB_PROXY_HOST was set but NiFi is not configured to run in a secure mode. Unsetting nifi.web.proxy.host.'

Review comment:
       That string shouldn't be in the codebase anymore. If you exec in to the container, what's in the start.sh?
   
   Also, looks like you're running an image named apache/nifi:NIFI-8783. This change is NIFI-8784. Is that just a typo in the tag name or was it built off another branch?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org