You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jongyoul <gi...@git.apache.org> on 2016/12/27 08:15:13 UTC
[GitHub] zeppelin pull request #1807: ZEPPELIN-1861 Support custom interpreter.sh scr...
GitHub user jongyoul opened a pull request:
https://github.com/apache/zeppelin/pull/1807
ZEPPELIN-1861 Support custom interpreter.sh script to run interpreter
### What is this PR for?
Supporting custom interpreter.sh for an individual interpreter. Some interpreters doesn't need current complicated interpreter.sh and want to use custom RemoteInterpreterServer class to launch their interpreters.
### What type of PR is it?
[Feature]
### Todos
* [x] - Add new way to be able to run custom interpreter.sh
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1861
### How should this be tested?
Users can add
```
"runner": {
"linux": "interpreter.sh",
"win": "interpreter.cmd"
}
```
in their interpreter-setting.json. This path is relative from `${INTERPRETER_DIR}/${INTERPRETER_NAME}`
### Screenshots (if appropriate)
N/A
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-1861
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1807.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1807
----
commit dc8f74bf0c1a5b8560f35384796b7918345e0316
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-12-27T08:06:58Z
Added InterpreterRunner class for supporting custom runner path
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1807: ZEPPELIN-1861 Support custom interpreter.sh script to ...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1807
interesting. should we have documentation for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1807: ZEPPELIN-1861 Support custom interpreter.sh scr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1807
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1807: ZEPPELIN-1861 Support custom interpreter.sh script to ...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1807
I have tested md for this new way but I didn't add that code because I didn't think it's good to add that example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1807: ZEPPELIN-1861 Support custom interpreter.sh script to ...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1807
Flaky test. Will merge it if there're no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1807: ZEPPELIN-1861 Support custom interpreter.sh script to ...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1807
I made a PR for editing those values in GUI. @felixcheung I think it would be better to make a new PR to describe interpreter-setting.json fully.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---