You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by merrimanr <gi...@git.apache.org> on 2018/06/07 21:00:24 UTC

[GitHub] metron issue #1019: METRON-1555: Update REST to run YARN and MR jobs

Github user merrimanr commented on the issue:

    https://github.com/apache/metron/pull/1019
  
    I added a link to the discuss thread to the description.  There is also a link in the top-level Jira:  https://issues.apache.org/jira/browse/METRON-1554.
    
    The latest commit removes the Service classes so that only a sample controller remains.  I added a comment to that controller stating it should be replaced.  There was a Jira created for service development and API design:  https://issues.apache.org/jira/browse/METRON-1559.  Hopefully that makes it clearer that API design is out of scope for this PR.  I can also add a comment to that Jira once this PR gets accepted.
    
    I feel like spinning up and testing this in full dev should be part of the review.  Most of the changes here are Ambari and Maven related.  To test this properly there will need to be some way to submit a MR job (any job) from REST, hence the throwaway sample controller.  If you want to create your own sample controller and test that way I can remove the one in this PR.  Is there an easier option I'm not thinking of?
    
    Maintaining a needs addressed list sounds like a good idea.  I'm not clear on how this would work in practice though.  Where would we keep it?  Would Jira tasks serve this purpose?  This seems like it could be applicable to all tasks in this feature branch (all feature branches really) so I don't think this is the appropriate place to discuss it.  Can we move it back to a discuss thread so you can clarify and expand on your idea?  I think it needs some more thought if we're to adopt it as a process.
    



---