[GitHub] [tvm] melsonlai commented on a change in pull request #8076: [BYOC][NNAPI]: Implement basic structure of Android NNAPI BYOC

[GitBox <gi...@apache.org>]

melsonlai commented on a change in pull request #8076:
URL: https://github.com/apache/tvm/pull/8076#discussion_r655259193



##########
File path: python/tvm/contrib/target/android_nnapi/relayir_to_nnapi_converter/__init__.py
##########
@@ -0,0 +1,60 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Converts Relay IR subgraph to Android NNAPI source code
+"""
+import tvm
+from .converter import Converter
+
+
+def convert_relayir_to_nnapi(func):

Review comment:
       Hi, I plan to name it "codegen" if that's OK. (I don't want to collide with the Python built-in function "compile")
   As an extra explanation that matters, the external compiler is actually a C++ stub in `src/relay/backend/contrib/android_nnapi/codegen.cc`, and it's that thing that gets registered as `relay.ext.android_nnapi`. 
   The existence of the C++ stub is a historical issue, however, it's not a complex file after all, so would you agree if I completely remove the C++ stub and make all of `relay.ext.android_nnapi` pythonic?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org