You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/02/28 17:04:39 UTC
[GitHub] [skywalking-agent-test-tool] dmsolr opened a new pull request #1:
setup github action & checkout protoc module by commit id
dmsolr opened a new pull request #1: setup github action & checkout protoc module by commit id
URL: https://github.com/apache/skywalking-agent-test-tool/pull/1
1. Setup Github action for CI AND IT
2. Using `git checkout` instead of copy source of protocol files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-agent-test-tool] wu-sheng commented on issue #1: setup
github action & checkout protoc module by commit id
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #1: setup github action & checkout protoc module by commit id
URL: https://github.com/apache/skywalking-agent-test-tool/pull/1#issuecomment-592828585
Please add documents to readme, and the LICENSE should be updated as you are not hosting proto now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-agent-test-tool] wu-sheng merged pull request #1:
Checkout protoc module by commit hash
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #1: Checkout protoc module by commit hash
URL: https://github.com/apache/skywalking-agent-test-tool/pull/1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-agent-test-tool] kezhenxu94 commented on a change in
pull request #1: setup github action & checkout protoc module by commit id
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #1: setup github action & checkout protoc module by commit id
URL: https://github.com/apache/skywalking-agent-test-tool/pull/1#discussion_r386080915
##########
File path: mock-collector/bin/fetch_code.sh
##########
@@ -0,0 +1,9 @@
+#!/bin/bash
Review comment:
license header
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-agent-test-tool] wu-sheng commented on a change in pull
request #1: setup github action & checkout protoc module by commit id
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #1: setup github action & checkout protoc module by commit id
URL: https://github.com/apache/skywalking-agent-test-tool/pull/1#discussion_r385994076
##########
File path: mock-collector/pom.xml
##########
@@ -30,11 +30,13 @@
<artifactId>mock-collector</artifactId>
<packaging>jar</packaging>
- <name>SkyWalking-Mock-Collector</name>
+ <name>SkyWalking Mock Collector</name>
<url>http://maven.apache.org</url>
<properties>
- <repos.protocol>https://github.com/apache/skywalking-data-collect-protocol.git</repos.protocol>
+ <protocol.version>7a22d3e</protocol.version>
Review comment:
The version should be the complete commit id, not the short one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-agent-test-tool] wu-sheng commented on issue #1: setup
github action & checkout protoc module by commit id
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #1: setup github action & checkout protoc module by commit id
URL: https://github.com/apache/skywalking-agent-test-tool/pull/1#issuecomment-593053812
Why CI doesn't exist? Something wrong?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-agent-test-tool] kezhenxu94 commented on issue #1:
setup github action & checkout protoc module by commit id
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #1: setup github action & checkout protoc module by commit id
URL: https://github.com/apache/skywalking-agent-test-tool/pull/1#issuecomment-593053255
Oops, made a mistake
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-agent-test-tool] kezhenxu94 commented on issue #1:
setup github action & checkout protoc module by commit id
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #1: setup github action & checkout protoc module by commit id
URL: https://github.com/apache/skywalking-agent-test-tool/pull/1#issuecomment-593055229
> Why CI doesn't exist? Something wrong?
The workflow yaml is created in the forked repo, thus won't take effect before it's merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services