You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "viirya (via GitHub)" <gi...@apache.org> on 2024/03/23 22:37:55 UTC
[PR] [SPARK-XXXXX][SQL] Add UserDefinedType support to DataTypeUtils.canWrite [spark]
viirya opened a new pull request, #45678:
URL: https://github.com/apache/spark/pull/45678
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This patch adds `UserDefinedType` handling to `DataTypeUtils.canWrite`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Our customer hits an issue recently when they tries to save a DataFrame containing some UDTs as table (`saveAsTable`). The error looks like:
```
- Cannot write 'xxx': struct<...> is incompatible with struct<...>
```
The catalog strings between two sides are actually same which makes the customer confused.
It is because `DataTypeUtils.canWrite` doesn't handle `UserDefinedType`. If the `UserDefinedType`'s underlying sql type is same as read side, `canWrite` should return true for two sides.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. Write side column with `UserDefinedType` can be written into read side column with same sql data type.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Unit test
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47528][SQL] Add UserDefinedType support to DataTypeUtils.canWrite [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #45678:
URL: https://github.com/apache/spark/pull/45678#discussion_r1536733467
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/DataTypeUtils.scala:
##########
@@ -64,6 +64,8 @@ object DataTypeUtils {
* - Both types are structs and have the same number of fields. The type and nullability of each
* field from read/write is compatible. If byName is true, the name of each field from
* read/write needs to be the same.
+ * - it is user defined type and its underlying sql type is same as the read type.
Review Comment:
- We need to capitalize the first char of the sentence.
- Do you mean `If it is` instead of `it is`?
- Also, please remove `-` if this is the continuation of the above paragraph staring line 64.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47528][SQL] Add UserDefinedType support to DataTypeUtils.canWrite [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #45678:
URL: https://github.com/apache/spark/pull/45678#issuecomment-2016879072
Thank you @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47528][SQL] Add UserDefinedType support to DataTypeUtils.canWrite [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #45678:
URL: https://github.com/apache/spark/pull/45678#issuecomment-2016734079
Merged to master. Thank you, @viirya .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47528][SQL] Add UserDefinedType support to DataTypeUtils.canWrite [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #45678:
URL: https://github.com/apache/spark/pull/45678#discussion_r1536736093
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/DataTypeUtils.scala:
##########
@@ -64,6 +64,8 @@ object DataTypeUtils {
* - Both types are structs and have the same number of fields. The type and nullability of each
* field from read/write is compatible. If byName is true, the name of each field from
* read/write needs to be the same.
+ * - it is user defined type and its underlying sql type is same as the read type.
Review Comment:
Fixed.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/DataTypeUtils.scala:
##########
@@ -64,6 +64,8 @@ object DataTypeUtils {
* - Both types are structs and have the same number of fields. The type and nullability of each
* field from read/write is compatible. If byName is true, the name of each field from
* read/write needs to be the same.
+ * - it is user defined type and its underlying sql type is same as the read type.
+ * - the read type is user defined type and its underlying sql type is same as the write type.
Review Comment:
Okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47528][SQL] Add UserDefinedType support to DataTypeUtils.canWrite [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #45678:
URL: https://github.com/apache/spark/pull/45678#issuecomment-2016708668
Could you check the following failures?
```
[info] *** 2 TESTS FAILED ***
[error] Failed: Total 7336, Failed 2, Errors 0, Passed 7334, Ignored 5
[error] Failed tests:
[error] org.apache.spark.sql.types.ANSIDataTypeWriteCompatibilitySuite
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47528][SQL] Add UserDefinedType support to DataTypeUtils.canWrite [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #45678: [SPARK-47528][SQL] Add UserDefinedType support to DataTypeUtils.canWrite
URL: https://github.com/apache/spark/pull/45678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47528][SQL] Add UserDefinedType support to DataTypeUtils.canWrite [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #45678:
URL: https://github.com/apache/spark/pull/45678#discussion_r1536733580
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeWriteCompatibilitySuite.scala:
##########
@@ -510,6 +510,144 @@ abstract class DataTypeWriteCompatibilityBaseSuite extends SparkFunSuite {
"Should allow map of int written to map of long column")
}
+ test("SPARK-47528: Check udt: underlying sql type is same") {
+ val udtType = new UserDefinedType[Any] {
+ override def sqlType: DataType = StructType(Seq(
+ StructField("col1", FloatType, nullable = false),
+ StructField("col2", FloatType, nullable = false)))
+
+ override def userClass: java.lang.Class[Any] = null
+
+ override def serialize(obj: Any): Any = null
+
+ override def deserialize(datum: Any): Any = null
+ }
+
+ val sqlType = StructType(Seq(
+ StructField("col1", FloatType, nullable = false),
+ StructField("col2", FloatType, nullable = false)))
+
+ assertAllowed(udtType, sqlType, "m",
+ "Should allow udt with same sqlType written to struct column")
+
+ assertAllowed(sqlType, udtType, "m",
+ "Should allow udt with same sqlType written to struct column")
+ }
+
+ test("SPARK-47528: Check udt: underlying sql type is same but different nullability") {
+ val udtType = new UserDefinedType[Any] {
+ override def sqlType: DataType = StructType(Seq(
+ StructField("col1", FloatType, nullable = false),
+ StructField("col2", FloatType, nullable = false)))
+
+ override def userClass: java.lang.Class[Any] = null
+
+ override def serialize(obj: Any): Any = null
+
+ override def deserialize(datum: Any): Any = null
+ }
+
+ val sqlType = StructType(Seq(
+ StructField("col1", FloatType, nullable = false),
+ StructField("col2", FloatType, nullable = true)))
+
+ assertAllowed(udtType, sqlType, "m",
+ "Should allow udt with same sqlType written to struct column")
+
+ val errs = new mutable.ArrayBuffer[String]()
+ checkError(
+ exception = intercept[AnalysisException] (
+ DataTypeUtils.canWrite("", sqlType, udtType, true,
+ analysis.caseSensitiveResolution, "t", storeAssignmentPolicy, errMsg => errs += errMsg)
+ ),
+ errorClass = "INCOMPATIBLE_DATA_FOR_TABLE.NULLABLE_COLUMN",
Review Comment:
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47528][SQL] Add UserDefinedType support to DataTypeUtils.canWrite [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #45678:
URL: https://github.com/apache/spark/pull/45678#discussion_r1536729638
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeWriteCompatibilitySuite.scala:
##########
@@ -510,6 +510,110 @@ abstract class DataTypeWriteCompatibilityBaseSuite extends SparkFunSuite {
"Should allow map of int written to map of long column")
}
+ test("Check udt: underlying sql type is same") {
+ val udtType = new UserDefinedType[Any] {
+ override def sqlType: DataType = StructType(Seq(
+ StructField("col1", FloatType, nullable = false),
+ StructField("col2", FloatType, nullable = false)))
+
+ override def userClass: java.lang.Class[Any] = null
+
+ override def serialize(obj: Any): Any = null
+
+ override def deserialize(datum: Any): Any = null
+ }
+
+ val sqlType = StructType(Seq(
+ StructField("col1", FloatType, nullable = false),
+ StructField("col2", FloatType, nullable = false)))
Review Comment:
Yes. I added a test case for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47528][SQL] Add UserDefinedType support to DataTypeUtils.canWrite [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #45678:
URL: https://github.com/apache/spark/pull/45678#discussion_r1536733483
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/DataTypeUtils.scala:
##########
@@ -64,6 +64,8 @@ object DataTypeUtils {
* - Both types are structs and have the same number of fields. The type and nullability of each
* field from read/write is compatible. If byName is true, the name of each field from
* read/write needs to be the same.
+ * - it is user defined type and its underlying sql type is same as the read type.
+ * - the read type is user defined type and its underlying sql type is same as the write type.
Review Comment:
Ditto. please remove `-` in the continuation of the paragraph.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47528][SQL] Add UserDefinedType support to DataTypeUtils.canWrite [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #45678:
URL: https://github.com/apache/spark/pull/45678#discussion_r1536710589
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeWriteCompatibilitySuite.scala:
##########
@@ -510,6 +510,110 @@ abstract class DataTypeWriteCompatibilityBaseSuite extends SparkFunSuite {
"Should allow map of int written to map of long column")
}
+ test("Check udt: underlying sql type is same") {
+ val udtType = new UserDefinedType[Any] {
+ override def sqlType: DataType = StructType(Seq(
+ StructField("col1", FloatType, nullable = false),
+ StructField("col2", FloatType, nullable = false)))
+
+ override def userClass: java.lang.Class[Any] = null
+
+ override def serialize(obj: Any): Any = null
+
+ override def deserialize(datum: Any): Any = null
+ }
+
+ val sqlType = StructType(Seq(
+ StructField("col1", FloatType, nullable = false),
+ StructField("col2", FloatType, nullable = false)))
Review Comment:
To be clear, could you add a test case for the same underlying SQL data types but different nullability?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47528][SQL] Add UserDefinedType support to DataTypeUtils.canWrite [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #45678:
URL: https://github.com/apache/spark/pull/45678#discussion_r1536710392
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeWriteCompatibilitySuite.scala:
##########
@@ -510,6 +510,110 @@ abstract class DataTypeWriteCompatibilityBaseSuite extends SparkFunSuite {
"Should allow map of int written to map of long column")
}
+ test("Check udt: underlying sql type is same") {
Review Comment:
If you don't mind, could you add a test name prefix, `SPARK-47528: `, for the newly added three test cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47528][SQL] Add UserDefinedType support to DataTypeUtils.canWrite [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #45678:
URL: https://github.com/apache/spark/pull/45678#issuecomment-2016714173
Yea, fixed it now. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47528][SQL] Add UserDefinedType support to DataTypeUtils.canWrite [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #45678:
URL: https://github.com/apache/spark/pull/45678#discussion_r1536729612
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/DataTypeUtils.scala:
##########
@@ -180,6 +180,16 @@ object DataTypeUtils {
case (w, r) if DataTypeUtils.sameType(w, r) && !w.isInstanceOf[NullType] =>
true
+ // If write-side data type is a user-defined type, check with its underlying data type.
+ case (w, r) if w.isInstanceOf[UserDefinedType[_]] && !r.isInstanceOf[UserDefinedType[_]] =>
+ canWrite(tableName, w.asInstanceOf[UserDefinedType[_]].sqlType, r, byName, resolver,
+ context, storeAssignmentPolicy, addError)
+
+ // If read-side data type is a user-defined type, check with its underlying data type.
+ case (w, r) if r.isInstanceOf[UserDefinedType[_]] && !w.isInstanceOf[UserDefinedType[_]] =>
+ canWrite(tableName, w, r.asInstanceOf[UserDefinedType[_]].sqlType, byName, resolver,
+ context, storeAssignmentPolicy, addError)
Review Comment:
Okay, updated.
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeWriteCompatibilitySuite.scala:
##########
@@ -510,6 +510,110 @@ abstract class DataTypeWriteCompatibilityBaseSuite extends SparkFunSuite {
"Should allow map of int written to map of long column")
}
+ test("Check udt: underlying sql type is same") {
Review Comment:
Added the prefix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47528][SQL] Add UserDefinedType support to DataTypeUtils.canWrite [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #45678:
URL: https://github.com/apache/spark/pull/45678#discussion_r1536710291
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/DataTypeUtils.scala:
##########
@@ -180,6 +180,16 @@ object DataTypeUtils {
case (w, r) if DataTypeUtils.sameType(w, r) && !w.isInstanceOf[NullType] =>
true
+ // If write-side data type is a user-defined type, check with its underlying data type.
+ case (w, r) if w.isInstanceOf[UserDefinedType[_]] && !r.isInstanceOf[UserDefinedType[_]] =>
+ canWrite(tableName, w.asInstanceOf[UserDefinedType[_]].sqlType, r, byName, resolver,
+ context, storeAssignmentPolicy, addError)
+
+ // If read-side data type is a user-defined type, check with its underlying data type.
+ case (w, r) if r.isInstanceOf[UserDefinedType[_]] && !w.isInstanceOf[UserDefinedType[_]] =>
+ canWrite(tableName, w, r.asInstanceOf[UserDefinedType[_]].sqlType, byName, resolver,
+ context, storeAssignmentPolicy, addError)
Review Comment:
It seems that we need to update the method description accordingly. Could you update it with this new feature, @viirya ?
https://github.com/apache/spark/blob/39500a315166d8e342b678ef3038995a03ce84d6/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/DataTypeUtils.scala#L59-L67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org