You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by "Michael Dick (JIRA)" <ji...@apache.org> on 2008/11/21 22:31:44 UTC

[jira] Resolved: (OPENJPA-778) cleaning up build for openjpa-kernel

     [ https://issues.apache.org/jira/browse/OPENJPA-778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Dick resolved OPENJPA-778.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0
                   1.3.0

Thanks for the patch! 

> cleaning up build for openjpa-kernel
> ------------------------------------
>
>                 Key: OPENJPA-778
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-778
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: kernel
>    Affects Versions: 1.2.0
>            Reporter: Fernando
>            Assignee: Michael Dick
>             Fix For: 1.3.0, 2.0.0
>
>         Attachments: openjpa-kernel.diff
>
>
> I am trying to get started developing on OpenJPA, and I found some minor issues here and there.  Attached is a simple patch to apply to openjpa-kernel, cleaning up how it generates the jjtree-javacc sources.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Resolved: (OPENJPA-778) cleaning up build for openjpa-kernel

Posted by Fernando Padilla <fe...@alum.mit.edu>.
should be ok, i don't think java complains about empty files :)

yah, for some reason svn diff doesn't generate actual delete/add files 
properly, maybe I have to add a command line flag or something.

thank you!! :)



Michael Dick wrote:
> Weird, the diff looked like it was a delete but all it did was empty the
> file. Good catch. I'm just re-running the tests in case I messed something
> up.
> 
> -mike
> 
> On Fri, Nov 21, 2008 at 3:50 PM, Fernando Padilla <fe...@alum.mit.edu> wrote:
> 
>> hey :)  you have to do:
>>
>> svn rm
>> openjpa-kernel/src/main/java/org/apache/openjpa/kernel/jpql/ParseException.java
>>
>>
>>
>>
>> Michael Dick (JIRA) wrote:
>>
>>>     [
>>> https://issues.apache.org/jira/browse/OPENJPA-778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>>>
>>> Michael Dick resolved OPENJPA-778.
>>> ----------------------------------
>>>
>>>       Resolution: Fixed
>>>    Fix Version/s: 2.0.0
>>>                   1.3.0
>>>
>>> Thanks for the patch!
>>>
>>>> cleaning up build for openjpa-kernel
>>>> ------------------------------------
>>>>
>>>>                Key: OPENJPA-778
>>>>                URL: https://issues.apache.org/jira/browse/OPENJPA-778
>>>>            Project: OpenJPA
>>>>         Issue Type: Improvement
>>>>         Components: kernel
>>>>   Affects Versions: 1.2.0
>>>>           Reporter: Fernando
>>>>           Assignee: Michael Dick
>>>>            Fix For: 1.3.0, 2.0.0
>>>>
>>>>        Attachments: openjpa-kernel.diff
>>>>
>>>>
>>>> I am trying to get started developing on OpenJPA, and I found some minor
>>>> issues here and there.  Attached is a simple patch to apply to
>>>> openjpa-kernel, cleaning up how it generates the jjtree-javacc sources.
>>>>
>>>
> 

Re: [jira] Resolved: (OPENJPA-778) cleaning up build for openjpa-kernel

Posted by Michael Dick <mi...@gmail.com>.
Weird, the diff looked like it was a delete but all it did was empty the
file. Good catch. I'm just re-running the tests in case I messed something
up.

-mike

On Fri, Nov 21, 2008 at 3:50 PM, Fernando Padilla <fe...@alum.mit.edu> wrote:

> hey :)  you have to do:
>
> svn rm
> openjpa-kernel/src/main/java/org/apache/openjpa/kernel/jpql/ParseException.java
>
>
>
>
> Michael Dick (JIRA) wrote:
>
>>     [
>> https://issues.apache.org/jira/browse/OPENJPA-778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>>
>> Michael Dick resolved OPENJPA-778.
>> ----------------------------------
>>
>>       Resolution: Fixed
>>    Fix Version/s: 2.0.0
>>                   1.3.0
>>
>> Thanks for the patch!
>>
>>> cleaning up build for openjpa-kernel
>>> ------------------------------------
>>>
>>>                Key: OPENJPA-778
>>>                URL: https://issues.apache.org/jira/browse/OPENJPA-778
>>>            Project: OpenJPA
>>>         Issue Type: Improvement
>>>         Components: kernel
>>>   Affects Versions: 1.2.0
>>>           Reporter: Fernando
>>>           Assignee: Michael Dick
>>>            Fix For: 1.3.0, 2.0.0
>>>
>>>        Attachments: openjpa-kernel.diff
>>>
>>>
>>> I am trying to get started developing on OpenJPA, and I found some minor
>>> issues here and there.  Attached is a simple patch to apply to
>>> openjpa-kernel, cleaning up how it generates the jjtree-javacc sources.
>>>
>>
>>

Re: [jira] Resolved: (OPENJPA-778) cleaning up build for openjpa-kernel

Posted by Fernando Padilla <fe...@alum.mit.edu>.
hey :)  you have to do:

svn rm 
openjpa-kernel/src/main/java/org/apache/openjpa/kernel/jpql/ParseException.java



Michael Dick (JIRA) wrote:
>      [ https://issues.apache.org/jira/browse/OPENJPA-778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
> 
> Michael Dick resolved OPENJPA-778.
> ----------------------------------
> 
>        Resolution: Fixed
>     Fix Version/s: 2.0.0
>                    1.3.0
> 
> Thanks for the patch! 
> 
>> cleaning up build for openjpa-kernel
>> ------------------------------------
>>
>>                 Key: OPENJPA-778
>>                 URL: https://issues.apache.org/jira/browse/OPENJPA-778
>>             Project: OpenJPA
>>          Issue Type: Improvement
>>          Components: kernel
>>    Affects Versions: 1.2.0
>>            Reporter: Fernando
>>            Assignee: Michael Dick
>>             Fix For: 1.3.0, 2.0.0
>>
>>         Attachments: openjpa-kernel.diff
>>
>>
>> I am trying to get started developing on OpenJPA, and I found some minor issues here and there.  Attached is a simple patch to apply to openjpa-kernel, cleaning up how it generates the jjtree-javacc sources.
>