You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by Guillaume Nodet <gn...@apache.org> on 2014/02/26 12:14:53 UTC
[VOTE] Release Apache Felix Gogo Runtime 0.12.0
I'm calling a vote on Felix Gogo Runtime.
Staging repository:
https://repository.apache.org/content/repositories/orgapachefelix-1008/
You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
Usage:
sh check_staged_release.sh 1008 /tmp/felix-staging
Changes:
** Bug
* [FELIX-4336] - The use of inheritable thread locals in ThreadIO can
cause problems
** Improvement
* [FELIX-3590] - Add system property resolution to CommandSessionImpl
* [FELIX-4363] - The CommandSession get/set methods are not thread safe
Please vote to approve this release:
[ ] +1 Approve the release
[ ] -1 Veto the release (please provide specific comments)
Cheers,
Guillaume
Re: [VOTE] Release Apache Felix Gogo Runtime 0.12.0
Posted by "Jamie G." <ja...@gmail.com>.
+1 (non binding)
Cheers,
Jamie
On Thu, Feb 27, 2014 at 9:49 AM, Jan Willem Janssen
<ja...@luminis.eu> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 26/02/14 12:14, Guillaume Nodet wrote:
>> Changes: ** Bug * [FELIX-4336] - The use of inheritable thread
>> locals in ThreadIO can cause problems ** Improvement * [FELIX-3590]
>> - Add system property resolution to CommandSessionImpl *
>> [FELIX-4363] - The CommandSession get/set methods are not thread
>> safe
>>
>> Please vote to approve this release:
>>
>> [ ] +1 Approve the release [ ] -1 Veto the release (please provide
>> specific comments)
>
> +1
>
> One remark: the o.a.f.gogo.commands project currently fails to compile
> using Maven. However, this is, as far as I can see, not because of the
> changes in the runtime project.
>
> - --
> Met vriendelijke groeten | Kind regards
>
> Jan Willem Janssen | Software Architect
> +31 631 765 814
>
> /My world is revolving around PulseOn and Amdatu/
>
> Luminis Technologies B.V.
> J.C. Wilslaan 29
> 7313 HK Apeldoorn
> +31 88 586 46 30
>
> http://www.luminis-technologies.com
> http://www.luminis.eu
>
> KvK (CoC) 09 16 28 93
> BTW (VAT) NL8169.78.566.B.01
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
> Comment: GPGTools - http://gpgtools.org
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iQIcBAEBAgAGBQJTDztSAAoJEKF/mP2eHDc4cX0P/1x207QQAGDLPKFrboiTaLbl
> tu/h8Ovy8HrX0rdz7JGfDI+lZV4YhkZZDhQVWdBh+RrURYwPna2Sic+AnMineJM2
> q+3NOrodIz3v9f/zyVlxzJBOOra78eFjEK6ZvtMp28qhMOIfhItz0H6Di5xhPQsC
> Omb4YcFePUQB2WcKhsJfNSffwxf4rLDn7sl7ETFcLz8C3ukeOqZhvGMnF3ukEo2q
> YRX+ELHnzdGvCBpMvvQTnCpcmr8cajotxAdEYnouPQx9kl87a9zvVo2SWmVs0gjb
> g+YR/Q7E3I2zE8DuAwvkH+T2J2CXmZlz3hGuwlD0KSodbt1Gj8ijBF9W96CWzGkn
> FxfBbebp9hDqKXBKYQezd5tuH9NqE8g86UR2YG0ww/6MVCxRgGMN7vXndAyXTROd
> vXDsFBhEr9AMDTB7SKI7QaZjr5z0PLJXsvh/3cGSB9rvzTDrgwIG2Zt5Kb21+ar8
> xhmorijK0zyv9cMZxoc+R5JZfSSuLrDJSfiM3xK4LSADx5iPqc/svtE0KFAJ6g2z
> pctOB6b4OCz4UJfyKiYiLTZ2T2jEVPVh4cFtIm2td8BhsXmJvWAf0VPfTqxkNFtC
> px6NOY0jUL7cJ3klQ/njzWRebjogDBvxhiRwA8uMnScq74xOFUTPNuwX99LcLzC1
> ovbWQnDPjR4IGlkN1wcr
> =Vk2t
> -----END PGP SIGNATURE-----
Re: [VOTE] Release Apache Felix Gogo Runtime 0.12.0
Posted by Jan Willem Janssen <ja...@luminis.eu>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 26/02/14 12:14, Guillaume Nodet wrote:
> Changes: ** Bug * [FELIX-4336] - The use of inheritable thread
> locals in ThreadIO can cause problems ** Improvement * [FELIX-3590]
> - Add system property resolution to CommandSessionImpl *
> [FELIX-4363] - The CommandSession get/set methods are not thread
> safe
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release [ ] -1 Veto the release (please provide
> specific comments)
+1
One remark: the o.a.f.gogo.commands project currently fails to compile
using Maven. However, this is, as far as I can see, not because of the
changes in the runtime project.
- --
Met vriendelijke groeten | Kind regards
Jan Willem Janssen | Software Architect
+31 631 765 814
/My world is revolving around PulseOn and Amdatu/
Luminis Technologies B.V.
J.C. Wilslaan 29
7313 HK Apeldoorn
+31 88 586 46 30
http://www.luminis-technologies.com
http://www.luminis.eu
KvK (CoC) 09 16 28 93
BTW (VAT) NL8169.78.566.B.01
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJTDztSAAoJEKF/mP2eHDc4cX0P/1x207QQAGDLPKFrboiTaLbl
tu/h8Ovy8HrX0rdz7JGfDI+lZV4YhkZZDhQVWdBh+RrURYwPna2Sic+AnMineJM2
q+3NOrodIz3v9f/zyVlxzJBOOra78eFjEK6ZvtMp28qhMOIfhItz0H6Di5xhPQsC
Omb4YcFePUQB2WcKhsJfNSffwxf4rLDn7sl7ETFcLz8C3ukeOqZhvGMnF3ukEo2q
YRX+ELHnzdGvCBpMvvQTnCpcmr8cajotxAdEYnouPQx9kl87a9zvVo2SWmVs0gjb
g+YR/Q7E3I2zE8DuAwvkH+T2J2CXmZlz3hGuwlD0KSodbt1Gj8ijBF9W96CWzGkn
FxfBbebp9hDqKXBKYQezd5tuH9NqE8g86UR2YG0ww/6MVCxRgGMN7vXndAyXTROd
vXDsFBhEr9AMDTB7SKI7QaZjr5z0PLJXsvh/3cGSB9rvzTDrgwIG2Zt5Kb21+ar8
xhmorijK0zyv9cMZxoc+R5JZfSSuLrDJSfiM3xK4LSADx5iPqc/svtE0KFAJ6g2z
pctOB6b4OCz4UJfyKiYiLTZ2T2jEVPVh4cFtIm2td8BhsXmJvWAf0VPfTqxkNFtC
px6NOY0jUL7cJ3klQ/njzWRebjogDBvxhiRwA8uMnScq74xOFUTPNuwX99LcLzC1
ovbWQnDPjR4IGlkN1wcr
=Vk2t
-----END PGP SIGNATURE-----
Re: [VOTE] Release Apache Felix Gogo Runtime 0.12.0
Posted by Guillaume Nodet <gn...@apache.org>.
Hi Pierre,
Sorry about the delay.
The exception seems to be caused by
https://github.com/apache/felix/commit/ab18b4a3bdcd654e42eaa109d6d7064ab30d360d#diff-77f7cca80e43164a9c73acd5c55ed128
The new ConcurrentHashMap which is used in place of the HashMap does not
support null values, so a NPE is thrown.
That's clearly a problem as session.put(key, null) is the only way to
"remove" a variable from the session.
I'll cancel this vote, fix the problem and start a new release candidate.
Thx !
Cheers,
Guillaume
2014-03-01 10:12 GMT+01:00 Pierre De Rop <pi...@gmail.com>:
> Hi Guillaume,
>
> May be I missed something, but when doing a basic test, then I'm getting
> this exception:
>
> (I just installed the felix 4.2.1 distribution with jdk 1.7.0_45, and
> replaced the old org.apache.felix.gogo.runtime-0.10.0.jar by the new
> org.apache.felix.gogo.runtime-0.12.0.jar bundle):
>
> ->
>
> [nxuser@nx0012 felix-framework-4.2.1]$ java -jar bin/felix.jar
> ____________________________
> Welcome to Apache Felix Gogo
>
> gogo: NullPointerException: null
> java.lang.NullPointerException
> at
> java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:1124)
> at
>
> org.apache.felix.gogo.runtime.CommandSessionImpl.put(CommandSessionImpl.java:156)
> at org.apache.felix.gogo.shell.Shell.source(Shell.java:196)
> at org.apache.felix.gogo.shell.Shell.gosh(Shell.java:109)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
>
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
>
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> org.apache.felix.gogo.runtime.Reflective.invoke(Reflective.java:137)
> at
> org.apache.felix.gogo.runtime.CommandProxy.execute(CommandProxy.java:82)
> at
> org.apache.felix.gogo.runtime.Closure.executeCmd(Closure.java:477)
> at
> org.apache.felix.gogo.runtime.Closure.executeStatement(Closure.java:403)
> at org.apache.felix.gogo.runtime.Pipe.run(Pipe.java:108)
> at org.apache.felix.gogo.runtime.Closure.execute(Closure.java:183)
> at org.apache.felix.gogo.runtime.Closure.execute(Closure.java:120)
> at
>
> org.apache.felix.gogo.runtime.CommandSessionImpl.execute(CommandSessionImpl.java:92)
> at org.apache.felix.gogo.shell.Activator.run(Activator.java:75)
> at java.lang.Thread.run(Thread.java:744)
>
> I'm using the following bundles:
>
> org.apache.felix.bundlerepository-1.6.6.jar
> org.apache.felix.gogo.command-0.12.0.jar
> org.apache.felix.gogo.runtime-0.12.0.jar
> org.apache.felix.gogo.shell-0.10.0.jar
>
>
> do you also have this exception ?
>
> kind regards;
> /Pierre
>
>
>
> On Wed, Feb 26, 2014 at 12:14 PM, Guillaume Nodet <gn...@apache.org>
> wrote:
>
> > I'm calling a vote on Felix Gogo Runtime.
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachefelix-1008/
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> > http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
> >
> > Usage:
> > sh check_staged_release.sh 1008 /tmp/felix-staging
> >
> > Changes:
> > ** Bug
> > * [FELIX-4336] - The use of inheritable thread locals in ThreadIO can
> > cause problems
> > ** Improvement
> > * [FELIX-3590] - Add system property resolution to CommandSessionImpl
> > * [FELIX-4363] - The CommandSession get/set methods are not thread
> safe
> >
> > Please vote to approve this release:
> >
> > [ ] +1 Approve the release
> > [ ] -1 Veto the release (please provide specific comments)
> >
> > Cheers,
> > Guillaume
> >
>
Re: [VOTE] Release Apache Felix Gogo Runtime 0.12.0
Posted by Pierre De Rop <pi...@gmail.com>.
Hi Guillaume,
May be I missed something, but when doing a basic test, then I'm getting
this exception:
(I just installed the felix 4.2.1 distribution with jdk 1.7.0_45, and
replaced the old org.apache.felix.gogo.runtime-0.10.0.jar by the new
org.apache.felix.gogo.runtime-0.12.0.jar bundle):
->
[nxuser@nx0012 felix-framework-4.2.1]$ java -jar bin/felix.jar
____________________________
Welcome to Apache Felix Gogo
gogo: NullPointerException: null
java.lang.NullPointerException
at
java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:1124)
at
org.apache.felix.gogo.runtime.CommandSessionImpl.put(CommandSessionImpl.java:156)
at org.apache.felix.gogo.shell.Shell.source(Shell.java:196)
at org.apache.felix.gogo.shell.Shell.gosh(Shell.java:109)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at
org.apache.felix.gogo.runtime.Reflective.invoke(Reflective.java:137)
at
org.apache.felix.gogo.runtime.CommandProxy.execute(CommandProxy.java:82)
at
org.apache.felix.gogo.runtime.Closure.executeCmd(Closure.java:477)
at
org.apache.felix.gogo.runtime.Closure.executeStatement(Closure.java:403)
at org.apache.felix.gogo.runtime.Pipe.run(Pipe.java:108)
at org.apache.felix.gogo.runtime.Closure.execute(Closure.java:183)
at org.apache.felix.gogo.runtime.Closure.execute(Closure.java:120)
at
org.apache.felix.gogo.runtime.CommandSessionImpl.execute(CommandSessionImpl.java:92)
at org.apache.felix.gogo.shell.Activator.run(Activator.java:75)
at java.lang.Thread.run(Thread.java:744)
I'm using the following bundles:
org.apache.felix.bundlerepository-1.6.6.jar
org.apache.felix.gogo.command-0.12.0.jar
org.apache.felix.gogo.runtime-0.12.0.jar
org.apache.felix.gogo.shell-0.10.0.jar
do you also have this exception ?
kind regards;
/Pierre
On Wed, Feb 26, 2014 at 12:14 PM, Guillaume Nodet <gn...@apache.org> wrote:
> I'm calling a vote on Felix Gogo Runtime.
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachefelix-1008/
>
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 1008 /tmp/felix-staging
>
> Changes:
> ** Bug
> * [FELIX-4336] - The use of inheritable thread locals in ThreadIO can
> cause problems
> ** Improvement
> * [FELIX-3590] - Add system property resolution to CommandSessionImpl
> * [FELIX-4363] - The CommandSession get/set methods are not thread safe
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] -1 Veto the release (please provide specific comments)
>
> Cheers,
> Guillaume
>
Re: [VOTE] Release Apache Felix Gogo Runtime 0.12.0
Posted by "Guillaume Sauthier (Objectweb)" <gu...@objectweb.org>.
+1
--G
2014-02-27 7:54 GMT+01:00 Clement Escoffier <cl...@gmail.com>:
> +1,
>
> Regards,
>
> Clement
>
> On 26 févr. 2014, at 22:39, Carsten Ziegeler <cz...@apache.org> wrote:
>
> > +1
> >
> > Carsten
> >
> >
> > 2014-02-26 18:08 GMT+01:00 Jean-Baptiste Onofré <jb...@nanthrax.net>:
> >
> >> +1 (non binding)
> >>
> >> Regards
> >> JB
> >>
> >>
> >> On 02/26/2014 12:14 PM, Guillaume Nodet wrote:
> >>
> >>> I'm calling a vote on Felix Gogo Runtime.
> >>>
> >>> Staging repository:
> >>>
> https://repository.apache.org/content/repositories/orgapachefelix-1008/
> >>>
> >>> You can use this UNIX script to download the release and verify the
> >>> signatures:
> >>> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
> >>>
> >>> Usage:
> >>> sh check_staged_release.sh 1008 /tmp/felix-staging
> >>>
> >>> Changes:
> >>> ** Bug
> >>> * [FELIX-4336] - The use of inheritable thread locals in ThreadIO
> can
> >>> cause problems
> >>> ** Improvement
> >>> * [FELIX-3590] - Add system property resolution to
> CommandSessionImpl
> >>> * [FELIX-4363] - The CommandSession get/set methods are not thread
> >>> safe
> >>>
> >>> Please vote to approve this release:
> >>>
> >>> [ ] +1 Approve the release
> >>> [ ] -1 Veto the release (please provide specific comments)
> >>>
> >>> Cheers,
> >>> Guillaume
> >>>
> >>>
> >> --
> >> Jean-Baptiste Onofré
> >> jbonofre@apache.org
> >> http://blog.nanthrax.net
> >> Talend - http://www.talend.com
> >>
> >
> >
> >
> > --
> > Carsten Ziegeler
> > cziegeler@apache.org
>
>
Re: [VOTE] Release Apache Felix Gogo Runtime 0.12.0
Posted by Clement Escoffier <cl...@gmail.com>.
+1,
Regards,
Clement
On 26 févr. 2014, at 22:39, Carsten Ziegeler <cz...@apache.org> wrote:
> +1
>
> Carsten
>
>
> 2014-02-26 18:08 GMT+01:00 Jean-Baptiste Onofré <jb...@nanthrax.net>:
>
>> +1 (non binding)
>>
>> Regards
>> JB
>>
>>
>> On 02/26/2014 12:14 PM, Guillaume Nodet wrote:
>>
>>> I'm calling a vote on Felix Gogo Runtime.
>>>
>>> Staging repository:
>>> https://repository.apache.org/content/repositories/orgapachefelix-1008/
>>>
>>> You can use this UNIX script to download the release and verify the
>>> signatures:
>>> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
>>>
>>> Usage:
>>> sh check_staged_release.sh 1008 /tmp/felix-staging
>>>
>>> Changes:
>>> ** Bug
>>> * [FELIX-4336] - The use of inheritable thread locals in ThreadIO can
>>> cause problems
>>> ** Improvement
>>> * [FELIX-3590] - Add system property resolution to CommandSessionImpl
>>> * [FELIX-4363] - The CommandSession get/set methods are not thread
>>> safe
>>>
>>> Please vote to approve this release:
>>>
>>> [ ] +1 Approve the release
>>> [ ] -1 Veto the release (please provide specific comments)
>>>
>>> Cheers,
>>> Guillaume
>>>
>>>
>> --
>> Jean-Baptiste Onofré
>> jbonofre@apache.org
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
>>
>
>
>
> --
> Carsten Ziegeler
> cziegeler@apache.org
Re: [VOTE] Release Apache Felix Gogo Runtime 0.12.0
Posted by Carsten Ziegeler <cz...@apache.org>.
+1
Carsten
2014-02-26 18:08 GMT+01:00 Jean-Baptiste Onofré <jb...@nanthrax.net>:
> +1 (non binding)
>
> Regards
> JB
>
>
> On 02/26/2014 12:14 PM, Guillaume Nodet wrote:
>
>> I'm calling a vote on Felix Gogo Runtime.
>>
>> Staging repository:
>> https://repository.apache.org/content/repositories/orgapachefelix-1008/
>>
>> You can use this UNIX script to download the release and verify the
>> signatures:
>> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
>>
>> Usage:
>> sh check_staged_release.sh 1008 /tmp/felix-staging
>>
>> Changes:
>> ** Bug
>> * [FELIX-4336] - The use of inheritable thread locals in ThreadIO can
>> cause problems
>> ** Improvement
>> * [FELIX-3590] - Add system property resolution to CommandSessionImpl
>> * [FELIX-4363] - The CommandSession get/set methods are not thread
>> safe
>>
>> Please vote to approve this release:
>>
>> [ ] +1 Approve the release
>> [ ] -1 Veto the release (please provide specific comments)
>>
>> Cheers,
>> Guillaume
>>
>>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>
--
Carsten Ziegeler
cziegeler@apache.org
Re: [VOTE] Release Apache Felix Gogo Runtime 0.12.0
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
+1 (non binding)
Regards
JB
On 02/26/2014 12:14 PM, Guillaume Nodet wrote:
> I'm calling a vote on Felix Gogo Runtime.
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachefelix-1008/
>
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 1008 /tmp/felix-staging
>
> Changes:
> ** Bug
> * [FELIX-4336] - The use of inheritable thread locals in ThreadIO can
> cause problems
> ** Improvement
> * [FELIX-3590] - Add system property resolution to CommandSessionImpl
> * [FELIX-4363] - The CommandSession get/set methods are not thread safe
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] -1 Veto the release (please provide specific comments)
>
> Cheers,
> Guillaume
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: [VOTE] Release Apache Felix Gogo Runtime 0.12.0
Posted by David Bosschaert <da...@gmail.com>.
+1 from me.
Cheers,
David
On 26 February 2014 12:14, Guillaume Nodet <gn...@apache.org> wrote:
> I'm calling a vote on Felix Gogo Runtime.
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachefelix-1008/
>
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 1008 /tmp/felix-staging
>
> Changes:
> ** Bug
> * [FELIX-4336] - The use of inheritable thread locals in ThreadIO can
> cause problems
> ** Improvement
> * [FELIX-3590] - Add system property resolution to CommandSessionImpl
> * [FELIX-4363] - The CommandSession get/set methods are not thread safe
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] -1 Veto the release (please provide specific comments)
>
> Cheers,
> Guillaume