You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ash211 <gi...@git.apache.org> on 2014/10/05 23:39:37 UTC
[GitHub] spark pull request: SPARK-3805 Set spark.worker.cleanup.enabled to...
GitHub user ash211 opened a pull request:
https://github.com/apache/spark/pull/2664
SPARK-3805 Set spark.worker.cleanup.enabled to true by default
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ash211/spark SPARK-3805
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2664.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2664
----
commit 60ba8948f2ce3a7c4c0ccf5da70d13cef6565657
Author: Andrew Ash <an...@andrewash.com>
Date: 2014-10-05T21:36:00Z
SPARK-3805 Set spark.worker.cleanup.enabled to true by default
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-3805 Set spark.worker.cleanup.enabled to...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2664#issuecomment-57955684
[QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21316/consoleFull) for PR 2664 at commit [`60ba894`](https://github.com/apache/spark/commit/60ba8948f2ce3a7c4c0ccf5da70d13cef6565657).
* This patch **passes** unit tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-3805 Set spark.worker.cleanup.enabled to...
Posted by ash211 <gi...@git.apache.org>.
Github user ash211 commented on the pull request:
https://github.com/apache/spark/pull/2664#issuecomment-58454687
That sounds very reasonable -- I'll close. Maybe in the future we should have a "things to think about when going into production" section of the docs but I don't have the time to invest in that right now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-3805 Set spark.worker.cleanup.enabled to...
Posted by ash211 <gi...@git.apache.org>.
Github user ash211 closed the pull request at:
https://github.com/apache/spark/pull/2664
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-3805 Set spark.worker.cleanup.enabled to...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2664#issuecomment-57969633
Back when we introduced this feature we decided to have it be false based on the principle of least surprise. The concern was, say someone upgrades spark and now without any actions suddenly log data is being deleted when they might have been counting on those logs being present. I'm sort of hesitant to enable default behavior that deletes user data for this reason.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-3805 Set spark.worker.cleanup.enabled to...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2664#issuecomment-57953537
[QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21316/consoleFull) for PR 2664 at commit [`60ba894`](https://github.com/apache/spark/commit/60ba8948f2ce3a7c4c0ccf5da70d13cef6565657).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-3805 Set spark.worker.cleanup.enabled to...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2664#issuecomment-57955685
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21316/Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org