[GitHub] [airflow] o-nikolas commented on pull request #28375: AIP-51 - Misc. Compatibility Checks

[GitBox <gi...@apache.org>]

o-nikolas commented on PR #28375:
URL: https://github.com/apache/airflow/pull/28375#issuecomment-1371385753

   > Hey Niko, I've submitted some more changes based on the feedback and requests. I reworked the pickling support attribute, switched to using your get executor class helper method, and implemented tests for pickling and sentry support for all of the executors. CI pipeline failed so I rebased the branch off main which fixed a failure in integration tests, but it's still failing static checks. Pre-commit was passing for me locally before rebasing, seems like something changed here. When I ran it locally after rebase it was changing several files so I didn't commit those changes.
   > 
   > Also, I didn't mean to remove all of the other reviewers, I clicked on request re-review and it did it automatically.
   
   Thanks @rkarish! Sorry for the delayed response but I have been on year end/holiday vacation. I'm just trying to get caught up now. I'll have a look at this PR very soon :pray: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org