You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/02/08 18:27:00 UTC
[jira] [Work logged] (KNOX-2227) Strip Leading and Trailing
Whitespace from Headers in KnoxShellTable
[ https://issues.apache.org/jira/browse/KNOX-2227?focusedWorklogId=383999&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383999 ]
ASF GitHub Bot logged work on KNOX-2227:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Feb/20 18:26
Start Date: 08/Feb/20 18:26
Worklog Time Spent: 10m
Work Description: lmccay commented on pull request #258: KNOX-2227 - Strip Leading and Trailing Whitespace from Headers in KnoxShellTable
URL: https://github.com/apache/knox/pull/258
## What changes were proposed in this pull request?
Currently headers are added to KnoxShellTable with any trailing or leading spaces intact. This makes any operations on the table that take a header name as a parameter difficult to use. There is no way to determine whether there are such spaces in the table even when rendered due to the padding in the cell.
I can't think of any reason that such spaces need to be retained even for CSV files when they exist in the source file.
This patch will trim the spaces so that header name based operations are more easily done and coded.
## How was this patch tested?
Added new unit test, tested manually and ran all unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 383999)
Remaining Estimate: 0h
Time Spent: 10m
> Strip Leading and Trailing Whitespace from Headers in KnoxShellTable
> --------------------------------------------------------------------
>
> Key: KNOX-2227
> URL: https://issues.apache.org/jira/browse/KNOX-2227
> Project: Apache Knox
> Issue Type: Improvement
> Components: KnoxShell
> Reporter: Larry McCay
> Assignee: Larry McCay
> Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently headers are added to KnoxShellTable with any trailing or leading spaces intact. This makes any operations on the table that take a header name as a parameter difficult to use. There is no way to determine whether there are such spaces in the table even when rendered due to the padding in the cell.
> I can't think of any reason that such spaces need to be retained even for CSV files when they exist in the source file.
> This patch will trim the spaces so that header name based operations are more easily done and coded.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)