You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/09/20 14:36:59 UTC

[GitHub] [jackrabbit-oak] nfsantos opened a new pull request, #711: OAK-9948 - Migrate search suggestions request from RHLC to new Java Client

nfsantos opened a new pull request, #711:
URL: https://github.com/apache/jackrabbit-oak/pull/711

   Migrate Elasticsearch usage of HLRC to new Java Client in call to suggestions for spellchecking and in a test for similarity.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jackrabbit-oak] fabriziofortino merged pull request #711: OAK-9948 - Migrate search suggestions request from RHLC to new Java Client

Posted by GitBox <gi...@apache.org>.
fabriziofortino merged PR #711:
URL: https://github.com/apache/jackrabbit-oak/pull/711


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #711: OAK-9948 - Migrate search suggestions request from RHLC to new Java Client

Posted by GitBox <gi...@apache.org>.
nfsantos commented on code in PR #711:
URL: https://github.com/apache/jackrabbit-oak/pull/711#discussion_r977598229


##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java:
##########
@@ -445,6 +445,12 @@ public PhraseSuggester suggestQuery() {
         return PhraseSuggester.of(ps -> ps
                 .field(FieldNames.SPELLCHECK)
                 .size(10)
+                // The Elasticsearch Java client fails parsing a response to suggest queries if the highlight is not set.
+                // Caused by: co.elastic.clients.util.MissingRequiredPropertyException: Missing required property 'PhraseSuggestOption.highlighted'
+                //	at co.elastic.clients.util.ApiTypeHelper.requireNonNull(ApiTypeHelper.java:76)
+                //	at co.elastic.clients.elasticsearch.core.search.PhraseSuggestOption.<init>(PhraseSuggestOption.java:64)
+                // Happens with Elasticsearch server 8.4.1 and client 7.17.6
+                .highlight(f -> f.preTag("").postTag(""))

Review Comment:
   I opened this issue: https://github.com/elastic/elasticsearch-java/issues/404



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jackrabbit-oak] fabriziofortino commented on a diff in pull request #711: OAK-9948 - Migrate search suggestions request from RHLC to new Java Client

Posted by GitBox <gi...@apache.org>.
fabriziofortino commented on code in PR #711:
URL: https://github.com/apache/jackrabbit-oak/pull/711#discussion_r977465765


##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java:
##########
@@ -445,6 +445,12 @@ public PhraseSuggester suggestQuery() {
         return PhraseSuggester.of(ps -> ps
                 .field(FieldNames.SPELLCHECK)
                 .size(10)
+                // The Elasticsearch Java client fails parsing a response to suggest queries if the highlight is not set.
+                // Caused by: co.elastic.clients.util.MissingRequiredPropertyException: Missing required property 'PhraseSuggestOption.highlighted'
+                //	at co.elastic.clients.util.ApiTypeHelper.requireNonNull(ApiTypeHelper.java:76)
+                //	at co.elastic.clients.elasticsearch.core.search.PhraseSuggestOption.<init>(PhraseSuggestOption.java:64)
+                // Happens with Elasticsearch server 8.4.1 and client 7.17.6
+                .highlight(f -> f.preTag("").postTag(""))

Review Comment:
   Is there already an open issue on that? In that case, can we link it? Otherwise we should create one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org