You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by dhalperi <gi...@git.apache.org> on 2017/03/23 01:40:32 UTC
[GitHub] beam pull request #2298: [BEAM-1780] BigtableIO: better handling of bad spli...
GitHub user dhalperi opened a pull request:
https://github.com/apache/beam/pull/2298
[BEAM-1780] BigtableIO: better handling of bad split requests
The contract for `splitIntoFraction` is that it should only throw if the
reader is in an unknown, bad state. The proper way to reject invalid or
unsatisfiable split requests is to return null.
However, `BigtableIO.Read` will currently throw for simply invalid input
it should reject. This can lead to less effective dynamic work
rebalancing and even stuck jobs.
Related to, but probably not a complete solution for, BEAM-1751.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dhalperi/beam bigtable-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2298.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2298
----
commit 3172c0ace419355aa050073194337ac0f3b27802
Author: Dan Halperin <dh...@google.com>
Date: 2017-03-22T17:21:33Z
[BEAM-1780] BigtableIO: better handling of bad split requests
The contract for `splitIntoFraction` is that it should only throw if the
reader is in an unknown, bad state. The proper way to reject invalid or
unsatisfiable split requests is to return null.
However, `BigtableIO.Read` will currently throw for simply invalid input
it should reject. This can lead to less effective dynamic work
rebalancing and even stuck jobs.
Related to, but probably not a complete solution for, BEAM-1751.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #2298: [BEAM-1780] BigtableIO: better handling of bad spli...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/2298
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---