[Bug 55435] New: ComboStringEditor could be simplified to make most settings final

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=55435

            Bug ID: 55435
           Summary: ComboStringEditor could be simplified to make most
                    settings final
           Product: JMeter
           Version: 2.9
          Hardware: PC
                OS: Windows XP
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: sebb@apache.org

The package-private ComboStringEditor can be reconfigured to change the tags,
edit and undefined behaviour after creation. 

This makes the code more complicated than it needs to be. Currently JMeter does
not change the settings after the class has been created, so it could be
simplified by removing the setTags(), setNoEdit() and setNoUndefined() methods,
replacing them with constructor parameters.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55435] ComboStringEditor could be simplified to make most settings final

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=55435

Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Sebb <se...@apache.org> ---
URL: http://svn.apache.org/r1514823
Log:
ComboStringEditor could be simplified to make most settings final
Bugzilla Id: 55435

Modified:
   
jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/ComboStringEditor.java
    jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/FileEditor.java
   
jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/GenericTestBeanCustomizer.java
    jmeter/trunk/xdocs/changes.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.