You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "zhuqi-lucas (via GitHub)" <gi...@apache.org> on 2025/07/01 07:37:05 UTC
Re: [PR] Perf: fast CursorValues compare for StringViewArray using inline_key_… [datafusion]
zhuqi-lucas commented on code in PR #16630:
URL: https://github.com/apache/datafusion/pull/16630#discussion_r2176661122
##########
datafusion/physical-plan/src/sorts/merge.rs:
##########
@@ -493,13 +493,12 @@ impl<C: CursorValues> SortPreservingMergeStream<C> {
if self.enable_round_robin_tie_breaker && cmp_node == 1 {
match (&self.cursors[winner], &self.cursors[challenger]) {
(Some(ac), Some(bc)) => {
- let ord = ac.cmp(bc);
- if ord.is_eq() {
+ if ac == bc {
Review Comment:
I also change this to using eq instead of compare first, this should also optimize some cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org