You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "saLeox (via GitHub)" <gi...@apache.org> on 2023/02/28 02:25:51 UTC
[GitHub] [incubator-streampark] saLeox opened a new pull request, #2375: [Feature][Issue-2191][Issue-2215] Support external link #2331
saLeox opened a new pull request, #2375:
URL: https://github.com/apache/incubator-streampark/pull/2375
<!--
Thank you for contributing to StreamPark! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
## Contribution Checklist
- If this is your first time, please read our contributor guidelines: [Submit Code](https://streampark.apache.org/community/submit_guide/submit_code).
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-streampark/issues).
- Name the pull request in the form "[Feature] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- If the PR is unfinished, add `[WIP]` in your PR title, e.g., `[WIP][Feature] Title of the pull request`.
-->
## What changes were proposed in this pull request
Issue Number: close #2191 #2215
<!--(For example: This pull request proposed to add checkstyle plugin).-->
## Brief change log
There should be a place to hold and display the useful external link (such as Job Metrics / Savepoint root path, etc) for each Flink Job.
This feature will allow user to customise their own external link, display it as a badge inside the Flink Application detail page, and jump to other page after clicking it.
For example, I am using Grafana, the link url format will be fixed in the following way:
[https://grafana/{template_name}/flink-monitoring?var-JobId=var-JobId={job_id}](https://grafana/%7Btemplate_name%7D/flink-monitoring?var-JobId=var-JobId=%7Bjob_id%7D)
The value of place holder, job_id, can be fetched from existing meta data of Flink Job easily.
Outcome:
<img width="1466" alt="image" src="https://user-images.githubusercontent.com/23732067/218972555-4406f5af-db38-468a-8fa9-6759c186c042.png">
<img width="848" alt="image" src="https://user-images.githubusercontent.com/23732067/220818004-30181a06-de10-4cb2-b147-e851570ae5f1.png">
<img width="862" alt="image" src="https://user-images.githubusercontent.com/23732067/218972616-3ca529b5-9bb2-4cb4-8758-244290a065c6.png">
The links are bound with each Flink Job, and the place holders are replaced automatically with actual value.
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verifying this change
<!--*(Please pick either of the following options)*-->
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts
- Dependencies (does it add or upgrade a dependency): (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] asuiah commented on a diff in pull request #2375: [Feature][Issue-2191][Issue-2215] Support external link #2331
Posted by "asuiah (via GitHub)" <gi...@apache.org>.
asuiah commented on code in PR #2375:
URL: https://github.com/apache/incubator-streampark/pull/2375#discussion_r1119768931
##########
streampark-console/streampark-console-webapp/src/api/flink/setting/types/externalLink.type.ts:
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+export interface ExternalLink {
+ id: string;
Review Comment:
Yeah correct. I will update this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on pull request #2375: [Feature][Issue-2191][Issue-2215] Support external link #2331
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #2375:
URL: https://github.com/apache/incubator-streampark/pull/2375#issuecomment-1447778596
cc @wangsizhu0504 PTAL. thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys merged pull request #2375: [Feature][Issue-2191][Issue-2215] Support external link #2331
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys merged PR #2375:
URL: https://github.com/apache/incubator-streampark/pull/2375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wangsizhu0504 commented on a diff in pull request #2375: [Feature][Issue-2191][Issue-2215] Support external link #2331
Posted by "wangsizhu0504 (via GitHub)" <gi...@apache.org>.
wangsizhu0504 commented on code in PR #2375:
URL: https://github.com/apache/incubator-streampark/pull/2375#discussion_r1119749428
##########
streampark-console/streampark-console-webapp/src/api/flink/setting/types/externalLink.type.ts:
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+export interface ExternalLink {
+ id: string;
Review Comment:
id should be an optional parameter, as there will be no id when it is created
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org