[GitHub] SudharmaJain commented on a change in pull request #2188: CLOUDSTACK-10004 : On deletion, Vmware volume snapshots are left behind with message 'the snapshot has child, can't delete it on the storage'

[gi...@git.apache.org]

SudharmaJain commented on a change in pull request #2188: CLOUDSTACK-10004 : On deletion, Vmware volume snapshots are left behind with message 'the snapshot has child, can't delete it on the storage'
URL: https://github.com/apache/cloudstack/pull/2188#discussion_r127668453
 
 

 ##########
 File path: engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java
 ##########
 @@ -171,7 +171,10 @@ public DataObject create(DataObject obj, DataStore dataStore) {
                     ss.setVolumeId(snapshot.getVolumeId());
                     SnapshotDataStoreVO snapshotDataStoreVO = snapshotDataStoreDao.findParent(dataStore.getRole(), dataStore.getId(), snapshot.getVolumeId());
                     if (snapshotDataStoreVO != null) {
-                        ss.setParentSnapshotId(snapshotDataStoreVO.getSnapshotId());
 
 Review comment:
   @niteshsarda findParent method is not giving the correct result. Lets fix that rather than taking a decision later. Also we should not hardcode it as vmware, better to use hypervisorType enum. Differential snapshots are only applicable for XenServer, should use that not vmware.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services